[Bug 20588] New: Elasticsearch - Apply dataTable on search fields and mapping tables

classic Classic list List threaded Threaded
20 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] New: Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

            Bug ID: 20588
           Summary: Elasticsearch - Apply dataTable on search fields and
                    mapping tables
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: [hidden email]
          Reporter: [hidden email]

Apply dataTable on search fields and mapping tables to be able to sort and
filter data.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

--- Comment #1 from Alex Arnaud <[hidden email]> ---
Created attachment 74241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74241&action=edit
Bug 20588 - Apply dataTable on search fields and mapping tables

This add the following capabilities:
  - Pagination,
  - columns sorting,
  - data filtering

Test plan:
  - apply this patch,
  - update DB and schema files,
  - add/remove search fields and mappings

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20388


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388
[Bug 20388] Elasticsearch - Ability to add search fields from UI
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Nicolas Legrand <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Nicolas Legrand <[hidden email]> ---
Hiya Alex,

Applying: Bug 20588 - Apply dataTable on search fields and mapping tables
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 20588 - Apply dataTable on search fields and mapping
tables

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

--- Comment #3 from Alex Arnaud <[hidden email]> ---
(In reply to Nicolas Legrand from comment #2)

> Hiya Alex,
>
> Applying: Bug 20588 - Apply dataTable on search fields and mapping tables
> fatal: sha1 information is lacking or useless
> (koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/
> mappings.tt).
> Repository lacks necessary blobs to fall back on 3-way merge.
> Cannot fall back to three-way merge.
> Patch failed at 0001 Bug 20588 - Apply dataTable on search fields and
> mapping tables

Hello Nicolas,

Did you apply in order: 18316 and 20388 ?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

--- Comment #4 from Nicolas Legrand <[hidden email]> ---
I applied it with Jonathan autoapply :

 $ git bz apply 20588

Bug 20588 Depends on bug 20388
Follow? [(y)es, (n)o] y

Bug 20388 Depends on bug 18316
Follow? [(y)es, (n)o] y
Bug 18316 - Add weighting/relevancy options to ElasticSearch

74115 - Bug 18316: Ability to weight search fields
74116 - Bug 18316: Add weighting/relevancy options to ES query on simple search
74117 - Bug 18316: String changes

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 18316: Ability to weight search fields
Applying: Bug 18316: Add weighting/relevancy options to ES query on simple
search
Applying: Bug 18316: String changes
Bug 20388 - Elasticsearch - Ability to add search fields from UI

73945 - Bug 20388 - Add/delete search fields from search engine configuration
page
73946 - Bug 20388 - Keep data consistency when adding/removing mapping
74261 - Bug 11674: DBRev 17.12.00.031

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20388 - Add/delete search fields from search engine configuration
page
Applying: Bug 20388 - Keep data consistency when adding/removing mapping
Applying: Bug 11674: DBRev 17.12.00.031
Using index info to reconstruct a base tree...
M       Koha.pm
A      
installer/data/mysql/atomicupdate/bug_11674-config_for_marc_field_doc_urls.sql
M       installer/data/mysql/updatedatabase.pl
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Bug 20588 - Elasticsearch - Apply dataTable on search fields and mapping tables

74241 - Bug 20588 - Apply dataTable on search fields and mapping tables

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20588 - Apply dataTable on search fields and mapping tables
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 20588 - Apply dataTable on search fields and mapping
tables

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74241|0                           |1
        is obsolete|                            |

--- Comment #5 from Alex Arnaud <[hidden email]> ---
Created attachment 74312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74312&action=edit
Bug 20588 - Apply dataTable on search fields and mapping tables

This add the following capabilities:
  - Pagination,
  - columns sorting,
  - data filtering

Test plan:
  - apply this patch,
  - update DB and schema files,
  - add/remove search fields and mappings

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

--- Comment #6 from Alex Arnaud <[hidden email]> ---
I've rebased the patch. Please try again

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #7 from Jonathan Druart <[hidden email]> ---
Looks like this patch removes the ability to sort the table (plugin tablednd),
and store this order in DB. Are you sure we do no longer need that?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Séverine Queune <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Séverine Queune <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74312|0                           |1
        is obsolete|                            |

--- Comment #8 from Séverine Queune <[hidden email]> ---
Created attachment 74315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74315&action=edit
Bug 20588 - Apply dataTable on search fields and mapping tables

This add the following capabilities:
  - Pagination,
  - columns sorting,
  - data filtering

Test plan:
  - apply this patch,
  - update DB and schema files,
  - add/remove search fields and mappings

Signed-off-by: Séverine QUEUNE <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Séverine Queune <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #9 from Séverine Queune <[hidden email]> ---
Jonathan has an other view of the patch.
As user, it looks pretty good to me !

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

--- Comment #10 from Alex Arnaud <[hidden email]> ---
(In reply to Jonathan Druart from comment #7)
> Looks like this patch removes the ability to sort the table (plugin
> tablednd), and store this order in DB. Are you sure we do no longer need
> that?

This patch exactly add the ability to sort tables columns. And, if i understand
what you are talking about, we don't lose the drag and drop feature provided by
tableDnD plugin.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

--- Comment #11 from Jonathan Druart <[hidden email]> ---
Sorting by user's preference I meant, not sorting by alpha/num

Moreover the drag and drop functionality does not longer work after one of the
column has been sorted.

I do not remember if this is used, could be useful later, or totally useless.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Signed Off                  |BLOCKED

--- Comment #12 from Julian Maurice <[hidden email]> ---
Changing status to BLOCKED, as it depends on 20388, which needs a rebase.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74315|0                           |1
        is obsolete|                            |

--- Comment #13 from Alex Arnaud <[hidden email]> ---
Created attachment 78660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78660&action=edit
Bug 20588 - Apply dataTable on search fields and mapping tables

This add the following capabilities:
  - Pagination,
  - columns sorting,
  - data filtering

Test plan:
  - apply this patch,
  - update DB and schema files,
  - add/remove search fields and mappings

Signed-off-by: Séverine QUEUNE <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/