[Bug 20393] New: Remove redundant 'koha.psgi' and 'plackup.sh' files

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] New: Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

            Bug ID: 20393
           Summary: Remove redundant 'koha.psgi' and 'plackup.sh' files
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

It seems both of these files are now superseded by the newer koha-plack and
plack.psgi files

they should probably be removed, now that they are not needed

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Mason James <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

--- Comment #1 from Mason James <[hidden email]> ---
Created attachment 72823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72823&action=edit
Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files  deleted:  
misc/plack/koha.psgi        deleted:    misc/plack/plackup.sh

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Mason James <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72823|0                           |1
        is obsolete|                            |

--- Comment #2 from Mason James <[hidden email]> ---
Created attachment 72824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72824&action=edit
Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Mason James <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Dilan Johnpullé <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #3 from Dilan Johnpullé <[hidden email]> ---
Attempted to sign off but patch fails to apply. The following is my devbox
terminal output:

vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 20393
Bug 20393 - Remove redundant 'koha.psgi' and 'plackup.sh' files

72824 - Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files
fatal: sha1 information is lacking or useless (misc/plack/koha.psgi).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh'
files
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-20393-Remove-redundant-kohapsgi-and-plackupsh--Te2c8M.patch

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

David Bourgault <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72824|0                           |1
        is obsolete|                            |

--- Comment #4 from David Bourgault <[hidden email]> ---
Created attachment 73392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73392&action=edit
Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files

Corrected modify/delete conflict.

Signed-off-by: David Bourgault <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

--- Comment #5 from Mason James <[hidden email]> ---
(In reply to Dilan Johnpullé from comment #3)
> Attempted to sign off but patch fails to apply. The following is my devbox
> terminal output:
>
> vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 20393
> Bug 20393 - Remove redundant 'koha.psgi' and 'plackup.sh' files
>

hi Dilan

the patch applies ok for me, against commit e5d5038 (bz-20531)

i'm guessing your repo wasn't set to the HEAD of the 'master' branch, before
applying

try the following...
$ git fetch origin master
$ git reset --hard  origin/master

then...
$ git bz apply -s 20393
Bug 20393 - Remove redundant 'koha.psgi' and 'plackup.sh' files
73392 - Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files

..success :0)
$ git log  --oneline | head -n 1
bb7e1b7 Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Mason James <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #6 from Mason James <[hidden email]> ---
(In reply to David Bourgault from comment #4)
> Created attachment 73392 [details] [review]
> Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files
>
> Corrected modify/delete conflict.
>
> Signed-off-by: David Bourgault <[hidden email]>

^...setting to signed-off for David :0)

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Severity|trivial                     |enhancement
                 CC|                            |[hidden email]

--- Comment #7 from Marcel de Rooy <[hidden email]> ---
Wasn't this meant as a dev script only? Not sure if anyone still uses it.
(I would prefer to get rid of them too.)
No bugfix btw, trivial enh.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18377
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73392|0                           |1
        is obsolete|                            |

--- Comment #8 from Julian Maurice <[hidden email]> ---
Created attachment 75895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75895&action=edit
Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files

Signed-off-by: David Bourgault <[hidden email]>
Signed-off-by: Julian Maurice <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

--- Comment #9 from Julian Maurice <[hidden email]> ---
Created attachment 75896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75896&action=edit
Bug 20393: (QA follow-up) Remove only occurence of misc/plack/koha.psgi

Signed-off-by: Julian Maurice <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Nick Clemens <[hidden email]> ---
Awesome work all!

Pushed to master for 18.11

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |martin.renvoize@ptfs-europe
                   |                            |.com

--- Comment #11 from Martin Renvoize <[hidden email]> ---
Enhancement, will not be backported to 18.05.x series.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/