[Bug 19974] New: Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

classic Classic list List threaded Threaded
78 messages Options
123
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] New: Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

            Bug ID: 19974
           Summary: Marking an item as 'lost' will not actually modify the
                    current item (cataloguing/additem.pl)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

When modifying an item through the intranet at the page
/cgi-bin/koha/cataloguing/additem.pl?op=edititem, instead of changing the
active item's information, the markaslost parameter will be applied to the
first Item in the database that has no itemnumber.

I'll submit a patch soon with a clear test plan. This should fortunately not
take too long to test.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Charles Farmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]-c
                   |                            |ommunity.org

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Charles Farmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #1 from Charles Farmer <[hidden email]> ---
Created attachment 70525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70525&action=edit
Bug19974 - Marking an item as 'lost' in additem.pl will not modify the current
item

    TEST PLAN:

    1) Log in with your superlibrarian account
    2) Borrow any book
    3) Visit your Checkouts page, and click 'Show Checkouts'
    4) Click on the item's barcode to visit the item's page
    5) On the item's page, click the 'Edit' button, and choose 'Edit items'
    6) In the items table, click the 'Actions->Edit' button of the item you
borrowed
    7) Mark that item as lost (it should be the first row of the form) and
click the button 'Save changes'
    8) Visit your Checkouts page. The item should still be there, despite
BZ12363 claiming it should've been automagically returned
        8.1) Your koha-log should also output a warning message:
'DBIx::Class::Storage::DBI::select_single(): Query returned more than one
row...'
        8.2) If you visit the item's page, the modification had no effect. It
should not be marked as lost.
    9) APPLY PATCH
    10) Start back from step 2), but this time, after marking the item as lost,
the item's page should
        reflect the change, and the item you borrowed should've been
automatically returned to the library

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Charles Farmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #2 from Charles Farmer <[hidden email]> ---
To my knowledge, emptying $itemnumber is only done so we don't fall back onto
the same item after saving changes. On one hand, we load back into the
$op=additem interface if changes were accepted, otherwise, we load the same
item again.

What's lost on me is the reason why we'd want to proceed with the deletion
logic at all if the newitem has a barcode already used. Is there code anywhere
edging on that voodoo logic of deleting an item from an unsaved biblionotice?

What would make sense, imo, is pushing that deletion logic upward inside the
'else' block and doing that at the same time as ModItemFromMarc. But again,
without a strong regression test suite of that particular part, I went with the
easy way out and changed as little as I could with my patch, behavior-wise.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #3 from Charles Farmer <[hidden email]> ---
I made a mistake describing what happens at point 8.2 of the test plan: the
item _will_ surely be marked as lost, make no mistake about that. If you filled
information inside additem.pl's form, it will definitely have an impact on the
item you were editing (i.e. you _should_ see the item marked as lost in your
account and on the item's page).

What's missing from BZ12363 is the _LostItem_ logic that should happen right
after an item is newly marked as lost.

My apologies for the misunderstanding.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

jmbroust <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jean-manuel.broust@univ-lyo
                   |                            |n2.fr
             Status|Needs Signoff               |Signed Off

--- Comment #4 from jmbroust <[hidden email]> ---
Signed off on sandbox 8. I had an error message from the sandbox when I signed
off :
"It seems you don't have applied a patch, so you cannot sign it off. If you
applied patches from the right report, check the commit message of the last
patch. It should start with "Bug XXXXX", if not, please inform the author of
the patch."

I tried to install again and still have a positive message result for the
install : Sandbox setup by [hidden email] with database -1
and bug 19974 on Tue Mar 13 12:06:26 2018

=== translation installation ===
No error

So I signed it off directly in bugzilla.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
         QA Contact|[hidden email]-communit |[hidden email]
                   |y.org                       |

--- Comment #5 from Marcel de Rooy <[hidden email]> ---
QA: Looking here

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #6 from Marcel de Rooy <[hidden email]> ---
Created attachment 73162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73162&action=edit
Bug 19974: Marking an item as 'lost' in additem.pl will not modify the current
item

TEST PLAN:

    1) Log in with your superlibrarian account
    2) Borrow any book
    3) Visit your Checkouts page, and click 'Show Checkouts'
    4) Click on the item's barcode to visit the item's page
    5) On the item's page, click the 'Edit' button, and choose 'Edit items'
    6) In the items table, click the 'Actions->Edit' button of the item you
borrowed
    7) Mark that item as lost (it should be the first row of the form) and
click the button 'Save changes'
    8) Visit your Checkouts page. The item should still be there, despite
BZ12363 claiming it should've been automagically returned
        8.1) Your koha-log should also output a warning message:
'DBIx::Class::Storage::DBI::select_single(): Query returned more than one
row...'
        8.2) If you visit the item's page, the modification had no effect. It
should not be marked as lost.
    9) APPLY PATCH
    10) Start back from step 2), but this time, after marking the item as lost,
the item's page should
        reflect the change, and the item you borrowed should've been
automatically returned to the library

Signed-off-by: Jean-Manuel Broust <[hidden email]>

Signed-off-by: Marcel de Rooy <[hidden email]>
Amended: Using $item->{itemnumber} instead of new variable.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #7 from Marcel de Rooy <[hidden email]> ---
Created attachment 73163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73163&action=edit
Bug 19974: (QA follow-up) Move lost logic to else branch

If an error is raised for the barcode, we should not try to perform the
lost logic succeeding it.
Futhermore there is no need to go to GetMarcFromKohaField etc. if we just
use the output of ModItemFromMarc.

Note: It seems unnecessary to clear $itemnumber, but I can understand
the anxiety about passing it to the template with op=additem. So just
leaving it here.

Signed-off-by: Marcel de Rooy <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #8 from Marcel de Rooy <[hidden email]> ---
Note: The title of this report is misleading

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70525|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #9 from Jonathan Druart <[hidden email]> ---
(In reply to Marcel de Rooy from comment #8)
> Note: The title of this report is misleading

Please adjust before push.

It seems it is a quite big change in workflow, should we highlight it in
release notes if backported?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #10 from Katrin Fischer <[hidden email]> ---
If I understand it correctly MarkLostItemsAsReturned should determine if the
item is checked in on return or not, independent now of where you set the item
lost status, correct? (bug 12363)

What's the difference this patch introduces? (sorry, ran out of time to check)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #11 from Jonathan Druart <[hidden email]> ---
(In reply to Katrin Fischer from comment #10)
> If I understand it correctly MarkLostItemsAsReturned should determine if the
> item is checked in on return or not, independent now of where you set the
> item lost status, correct? (bug 12363)
>
> What's the difference this patch introduces? (sorry, ran out of time to
> check)

When an item is marked as lost when cataloguing (additem.pl), LostItem will be
called and the item checked in if MarkLostItemsAsReturned is set.
This is the expected behavior (I think): what the code wanted to do (but
failed) and it is what is done in other areas.

My concern is that we are going to fix a long standing bug and may break
librarian's workflows (?)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]

--- Comment #12 from Katrin Fischer <[hidden email]> ---
It's a possibility that this might upset some libraries as there is a lot of
documentation stating the difference between item form and item tab... which
doesn't mean it was a good idea to have that difference to start with.

It might be good to clean up behaviour.

The only other thing I can think of is having a multi-select pref, that allows
you to pick behaviour for item edit, item tab and cron.

Adding Nick and Kyle to get some additional perspective. I know Bywater has
published things about lost behaviour on their blog in the past.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #13 from Nick Clemens <[hidden email]> ---
I am torn here, I like that we fix this code, and it does make sense, however,
we have firmly established the current behvaiour as a valid workflow and hsould
not break it.

The longoverdue cronjob allows for the options of marking items as lost and not
returning them - if we fix this here users no longer have an option for marking
an itemlost without returning it.

I would almost lean towards removing the LostItem call rather than fixing it,
otherwise I think we need some sort of preference or confirmation or option to
charge/eturn the item if they mark it lost via additem.pl

Kyle?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #14 from Katrin Fischer <[hidden email]> ---
Just another note, we already got a system preference now that says:

MarkLostItemsAsReturned        
Mark/don'mark items as returned when flagged as lost

So this is highly misleading - whatever we do, we should make this more
explicit.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #15 from Jonathan Druart <[hidden email]> ---
So let's push it to 18.05 (no backport!) and highlight the change in the
release notes?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #16 from Katrin Fischer <[hidden email]> ---
I think it would work for us.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #17 from Nick Clemens <[hidden email]> ---
I don't like it.

Currently the users have two options (if the pref is set to Mark returned) one
page returns and charges one page doesn't

After this they have only one option, and no way to mark returned sometimes and
not others, I think some libraries have different statuses that they want to
mark in different ways.

I would like another opinion here.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #18 from Katrin Fischer <[hidden email]> ---
I can see what you mean - we only have a few customers and I know they are
probably not using the difference. Harder with so many libraries.

What about changing the pref to be multi-select and choose?

I'd also like a option or checkbox one could tick on doing the action, but
that's probably hard to implement on additem.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #19 from Jonathan Druart <[hidden email]> ---
(In reply to Nick Clemens from comment #17)
> I don't like it.
>
> Currently the users have two options (if the pref is set to Mark returned)
> one page returns and charges one page doesn't

Where are these behavior documented? When you read the code it is obvious that
it is a long standing bug, i.e. the original author wanted the item to be
checked in.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #20 from Nick Clemens <[hidden email]> ---
(In reply to Jonathan Druart from comment #19)

https://bywatersolutions.com/2015/02/23/lost-koha/

I agree that was the original intention, but at a certain point I think bug
workflow became standardized i.e. we didn't know it was a bug, promoted as a
feature and we will break more workflows than we would fix

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #21 from Gaetan Boisson <[hidden email]> ---
I think the behavior should really be the one selected in the system
preference. Having two different behaviors in the two different tabs on the
interface looks like a horrible workaround to me ;)

I don't think we work with libraries who use (and expect this). In fact i'm
pretty convinced they look at the system preference setting as what should
happen.

In fact I would happily get rid of the 'items' tab which i find redundant and
confusing. But that's not the topic here.

Anyway, i am for following the system preference. So i guess Katrin's
suggestion of having one extra choice for the system preference is fine with
me. Since i really dislike this items tab though, what i would suggest is
something similar to what we have for notforloan, where negative values have a
different meaning that positive ones.

Maybe we could have positive values of lost triggering the return, and negative
ones not triggering it, so librarians would be able to choose, and we could
have consistent behavior in the different tabs.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #22 from Nick Clemens <[hidden email]> ---
(In reply to Gaetan Boisson from comment #21)
> I don't think we work with libraries who use (and expect this).
We definitely do, and have a lot of them

> Since i really dislike this items tab though, what i would suggest is
> something similar to what we have for notforloan, where negative values have
> a different meaning that positive ones.
>
> Maybe we could have positive values of lost triggering the return, and
> negative ones not triggering it, so librarians would be able to choose, and
> we could have consistent behavior in the different tabs.

Looking at the code it seems this page already does that - it will call
LostItem for positive values and not for negative.

If we document that and make a corresponding change to
moredetails.pl/updateitem.pl I think that works

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

Jessie Zairo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974

--- Comment #23 from Katrin Fischer <[hidden email]> ---
I think the positive/negative is even less documented and dangerous. I like the
idea, but how to explain that to libraries? And how to explain change in
behaviour for lost values they already use?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
123