[Bug 19938] New: Refactor C4::Overdues::checkoverdues

classic Classic list List threaded Threaded
37 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 19938] Refactor C4::Overdues::checkoverdues

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70485|0                           |1
        is obsolete|                            |
  Attachment #70486|0                           |1
        is obsolete|                            |

--- Comment #23 from M. Tompsett <[hidden email]> ---
Created attachment 70567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70567&action=edit
Bug 19938: Bad return value triggers noise

TEST PLAN
---------
0) back up plack error log if you care.

1) Run these on your kohadevbox:
    echo | sudo tee /var/log/koha/kohadev/plack-error.log
    sudo koha-shell -c bash kohadev
    prove t/db_dependent/Circulation/dateexpiry.t
    prove t/db_dependent/www/search_utf8.t
    ./misc/cronjobs/staticfines.pl
    exit

    They will all pass or run without error.
    However, the log file will have noise.

2) Run these on your kohadevbox:
    git bz apply 19938
    restart_all
    echo | sudo tee /var/log/koha/kohadev/plack-error.log
    sudo koha-shell -c bash kohadev
    prove t/db_dependent/Circulation/dateexpiry.t
    prove t/db_dependent/www/search_utf8.t
    ./misc/cronjobs/staticfines.pl
    exit

    They will all pass or run without error.
    This time the log file will have no noise.

3) run koha qa test tools

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19938] C4::Overdues::checkoverdues has inconsistent return type

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Refactor                    |C4::Overdues::checkoverdues
                   |C4::Overdues::checkoverdues |has inconsistent return
                   |                            |type

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19938] C4::Overdues::checkoverdues has inconsistent return type

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70489|0                           |1
        is obsolete|                            |

--- Comment #24 from M. Tompsett <[hidden email]> ---
Comment on attachment 70489
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70489
Bug 19938: Do not fetch dashboard's info if no logged in

Fixing the return type makes this check not necessary.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19938] C4::Overdues::checkoverdues has inconsistent return type

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70489|1                           |0
        is obsolete|                            |

--- Comment #25 from M. Tompsett <[hidden email]> ---
Comment on attachment 70489
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70489
Bug 19938: Do not fetch dashboard's info if no logged in

Sorry. Let's include this optimization which will reduce output times.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19938] C4::Overdues::checkoverdues has inconsistent return type

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #26 from M. Tompsett <[hidden email]> ---
Both can be applied together or independently. Both solve the warning issue.
However, JD's has the added advantage of also trimming unnecessary calls,
meaning fast page output time. Mine is short and pretty, bringing consistency
to the checkoverdues return value, but does nothing to trim times. Test plan is
comment #23.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19938] C4::Overdues::checkoverdues has inconsistent return type

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70489|0                           |1
        is obsolete|                            |

--- Comment #27 from Jonathan Druart <[hidden email]> ---
Comment on attachment 70489
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70489
Bug 19938: Do not fetch dashboard's info if no logged in

Finally, see bug 20068...

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19938] C4::Overdues::checkoverdues has inconsistent return type

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12