[Bug 19919] New: Writing off a Lost Item Fee marks as "Paid for by patron"

classic Classic list List threaded Threaded
53 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] New: Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

            Bug ID: 19919
           Summary: Writing off a Lost Item Fee marks as "Paid for by
                    patron"
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Created attachment 70293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70293&action=edit
An example

A replacement copy was ordered for an item that was "long lost overdue" on a
patron's account.
The librarian wanted the old copy deleted from the system to keep the record
clean.
We checked in the item, marked it as lost, and then wrote off the fee
associated with the item. Finally we reapplied the fee manually, no longer
associated with the item.
We noticed that at the point of the write off, the item gets a line that says
paid for by (Patron name and barcode) DATE TIME.


This also happens if the book is checked in and no longer marked as lost (say
it was returned by the borrower so we wrote off the lost item fee.)

The borrower has not paid for the book in either situation.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Christopher Davis <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Christopher Davis <[hidden email]> ---
Thanks Lisette,

We have seen this behavior in Koha at our institution as well. This bug is more
annoying and confusing than anything, but it would be good to have it patched.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Lisette <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Jessie Zairo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |,
                   |                            |[hidden email],
                   |                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Jessie Zairo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Barton Chittenden <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           Severity|enhancement                 |major

--- Comment #2 from Barton Chittenden <[hidden email]> ---
Marking as major, simply because this is going to cause a lot of confusion; I
foresee many support tickets.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

George Williams (NEKLS) <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <[hidden email]> ---
What could be a solution?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Katrin Fischer <[hidden email]> ---
I think that might be some underdocumented feature here that doesn't work in
all cases.

The message is set by ReturnLostItem:
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Circulation.pm;hb=95031b035b5de87211d0de2040eb685ae005606c#l3601

ReturnLostItem is only used by pay (at least in master):

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/Account.pm;hb=95031b035b5de87211d0de2040eb685ae005606c#l114

Then there is also the template:
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt;hb=95031b035b5de87211d0de2040eb685ae005606c#l237

So when a fine of type L or Rep is paid, the line will be added to
items.paidfor.

Of course this is problematic in multiple ways:
- the whole note is untranslatable
- we store firstname surname and not the borrowernumber, which can lead to
confusion with common names.
- we store a badly formatted date (note the missing leading zeros) in ISO
format.

We could fix the behaviour and only add the note for payments (not write offs).
But maybe we should rethink the whole thing? Is this information really helpful
when you can get it from the cleaned up accountlines and account_offsets table
now in a clean way?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Edie Discher <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Magnus Enger <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from Magnus Enger <[hidden email]> ---
Storing this info on the item level is also problematic in light of GDPR.

Can anyone describe a use case for storing this info in items.paidfor?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

--- Comment #6 from Katrin Fischer <[hidden email]> ---
(In reply to Magnus Enger from comment #5)
> Storing this info on the item level is also problematic in light of GDPR.
>
> Can anyone describe a use case for storing this info in items.paidfor?

Good point, totally agree. We should not store patron information like names in
item data ever, there is too much risk in exporting the data in some way or
making it accidentally visible in the OPAC.

I'd vote for removing it.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Christopher Brannon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Christopher Brannon <[hidden email]> ---
(In reply to Katrin Fischer from comment #6)

> (In reply to Magnus Enger from comment #5)
> > Storing this info on the item level is also problematic in light of GDPR.
> >
> > Can anyone describe a use case for storing this info in items.paidfor?
>
> Good point, totally agree. We should not store patron information like names
> in item data ever, there is too much risk in exporting the data in some way
> or making it accidentally visible in the OPAC.
>
> I'd vote for removing it.

+1

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

--- Comment #8 from Jonathan Druart <[hidden email]> ---
(In reply to Magnus Enger from comment #5)

> Can anyone describe a use case for storing this info in items.paidfor?

I found that:

2001-05-17 15:36  rangi

   * database.mysql: Changed the interim field in the items table, to
   be paidfor The horowhenua librarians wanted a place to store
   information when a lost item was paid for. The information is
   removed if the item is ever returned.  The interim field was a
   hangover from the previous system and wasnt be used so I stole it
   :-)

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12817

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

--- Comment #9 from George Williams (NEKLS) <[hidden email]> ---
I'm in favor of removing this altogether if it's not needed.

If it is needed, then I'd like to see the patron information stored as the
patron's borrowernumber of barcode number rather than as their name.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

--- Comment #10 from Christopher Brannon <[hidden email]> ---
(In reply to George Williams (NEKLS) from comment #9)
> I'm in favor of removing this altogether if it's not needed.
>
> If it is needed, then I'd like to see the patron information stored as the
> patron's borrowernumber of barcode number rather than as their name.

Never a barcode.  It should be the borrowernumber.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #11 from Katrin Fischer <[hidden email]> ---
*** Bug 12817 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

--- Comment #12 from Katrin Fischer <[hidden email]> ---
*** Bug 18868 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14825
                 CC|                            |martin.renvoize@ptfs-europe
                   |                            |.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

--- Comment #13 from Martin Renvoize <[hidden email]> ---
Created attachment 89320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89320&action=edit
Bug 19919: Do not record payments for a writeoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #14 from Martin Renvoize <[hidden email]> ---
I need some guidance here.

I've attached a basic patch to resolve just the problem as described in the
title of the bug..

However, it looks like people are also very keen to remove this paidfor field
entirely (which is actually pretty simple to do at this point and would not
lose any information as we already store enough data to reconstruct it via the
accountlines).

So, as far as I can see there are two use cases for it, the first is for
display in the item moredetails view (Does it matter if an item has been paid
for, then returned and written off.. right now we remove the detail in paidfor
so we don't display anything at this point, but we could show the payment and
refund if we were so inclined)

The second use case is for reports. This one is more challenging, we can't
easily know what reports are out there in the wild so the best we can really do
is advise as to how to get the same information back via a join to the
accountlines table.

Any guidance as to what we would hope to achieve in the long run would be
greatly appreciated.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

--- Comment #15 from Jonathan Druart <[hidden email]> ---
Martin, the patch does not apply:
  error: sha1 information is lacking or useless (C4/Circulation.pm).

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89320|0                           |1
        is obsolete|                            |

--- Comment #16 from Martin Renvoize <[hidden email]> ---
Created attachment 89356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89356&action=edit
Bug 19919: Do not record payments for a writeoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |martin.renvoize@ptfs-europe
                   |ity.org                     |.com

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

--- Comment #17 from Martin Renvoize <[hidden email]> ---
I've uploaded a refreshed patch freshly based against master.

I've not written a test for it yet - I wasn't sure whether this was actually
what people wanted here (and to split out the removal of paidfor as a separate
bug) or not.. so it's more of a proof of concept at this point.  A test should
however be pretty simple should we want to follow this route.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #18 from Liz Rea <[hidden email]> ---
I confirm that this works, but I'd like to hear from Chris if Horowhenua
Libraries still require this functionality before we totally get rid of it.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #19 from Katrin Fischer <[hidden email]> ---
(In reply to Liz Rea from comment #18)
> I confirm that this works, but I'd like to hear from Chris if Horowhenua
> Libraries still require this functionality before we totally get rid of it.

Adding him as CC

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Chris Cormack <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #20 from Chris Cormack <[hidden email]> ---
They still use it, so if it could be fixed rather than removed would be great.
Always a shame when we break things the Original Koha library use.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12