[Bug 19870] New: Loaned items show as available unless logged in

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] New: Loaned items show as available unless logged in

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

            Bug ID: 19870
           Summary: Loaned items show as available unless logged in
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

On the OPAC search results page issued (checked out) items still show as
"Availability: Items available: (1)," when not logged in. When logged in they
displays correctly as " Availability: No items available: Issued (1),".
The items show correctly as issued in the details page regardless of whether
the user is logged in or not and display correctly in the staff client.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] Loaned items show as available unless logged in

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

Mason James <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17556

--- Comment #1 from Mason James <[hidden email]> ---
(In reply to James from comment #0)
> On the OPAC search results page issued (checked out) items still show as
> "Availability: Items available: (1)," when not logged in. When logged in
> they displays correctly as " Availability: No items available: Issued (1),".
> The items show correctly as issued in the details page regardless of whether
> the user is logged in or not and display correctly in the staff client.

hmm.. i think this problem was caused by bug 17556 ?

there seems to be an odd logic error that says an item can only have an
'onloan' status.. if a user is logged in


2094             my $userenv = C4::Context->userenv;
2095             if ( $item->{onloan}
2096                 && $userenv
2097                 && $userenv->{number}
2098                 && !(
Koha::Patrons->find($userenv->{number})->category->hidelostitems &&
$item->{itemlost} ) )
2099             {

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] Loaned items show as available unless logged in

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

--- Comment #2 from Mason James <[hidden email]> ---
i'll upload a quick patch for this soon...

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] Loaned items show as available unless logged in

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

--- Comment #3 from Mason James <[hidden email]> ---
Created attachment 70094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70094&action=edit
pic

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] Loaned items show as available unless logged in

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

--- Comment #4 from Mason James <[hidden email]> ---
(In reply to James from comment #0)
> On the OPAC search results page issued (checked out) items still show as
> "Availability: Items available: (1)," when not logged in. When logged in
> they displays correctly as " Availability: No items available: Issued (1),".

the workaround until a patch is pushed, is to set the following sysprefs to
'default' , (ie: use XSLT)

 - OPACXSLTResultsDisplay
 - XSLTResultsDisplay


pic attached

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] Loaned items show as available unless logged in

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

--- Comment #5 from Mason James <[hidden email]> ---
Created attachment 70095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70095&action=edit
Bug 19870: Loaned items show as available unless logged in

here's a quick fix to the problem (on 17.05.00 and up)

1/ set OPACXSLTResultsDisplay = '';
2/ log out from opac

3/ search for a title in opac, see item is available in search results
4/ check out item
5/ search for a title in opac, see item is still available?1

6/ apply patch
7/ search for an title in opac, see item is now unavailable

we still need a .t/test file for resultsSearch(), but that might be a job for
another day...

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] Loaned items show as available unless logged in

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

Mason James <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] Loaned items show as available unless logged in

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

Mason James <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] Loaned items show as available unless logged in

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

Dominic Pichette <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |m

--- Comment #6 from Dominic Pichette <[hidden email]> ---
I got this after applying patch and searching for an item:
syntax error at /inlibro/git/koha-v1605-dev-inlibro/C4/Search.pm line 2128,
near "}"

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] Loaned items show as available unless logged in

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

jmbroust <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |jean-manuel.broust@univ-lyo
                   |                            |n2.fr

--- Comment #7 from jmbroust <[hidden email]> ---
The patch was still in need signoff, I turn it to failed QA.
I had same type of error :
Software error:
syntax error at /home/koha/src/C4/Search.pm line 2128, near "}"
Global symbol "$items_count" requires explicit package name (did you forget to
declare "my $items_count"?) at /home/koha/src/C4/Search.pm line 2225.
Global symbol "$hideatopac_count" requires explicit package name (did you
forget to declare "my $hideatopac_count"?) at /home/koha/src/C4/Search.pm line
2225.
2265.

blablablabla
.....
Compilation failed in require at /home/koha/src/opac/opac-search.pl line 47.
BEGIN failed--compilation aborted at /home/koha/src/opac/opac-search.pl line
47.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] Loaned items show as available unless logged in

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
           Assignee|[hidden email]         |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] Loaned items show as available unless logged in

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

Mason James <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
   Patch complexity|---                         |Trivial patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] Loaned items show as available unless logged in

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

Mason James <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70095|0                           |1
        is obsolete|                            |

--- Comment #8 from Mason James <[hidden email]> ---
Created attachment 77593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77593&action=edit
Bug 19870: Loaned items show as available unless logged in

small typo fix

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19870] Loaned items show as available unless logged in

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19870

Mason James <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70095|1                           |0
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/