[Bug 19804] New: Suspension calcultation doesn't honour ' Fine charging interval'

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] New: Suspension calcultation doesn't honour ' Fine charging interval'

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

            Bug ID: 19804
           Summary: Suspension calcultation doesn't honour 'Fine charging
                    interval'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

When a user is returning an item with overudue, the suspension is calculated in
days according 'suspensions in day' it doesn't calculate the 'Fine charging
interval' that I guess is used for € fines, but doesn't apply to suspensions in
day.

Not all libraries has a relation > 1 to days and suspensions, for example now
it is not possible to define 7 days of suspension for every 14.

It should be nice if Koha also consider the 'Fine charging interval' for
suspensions in days and library could decide to change the suspension, every 1,
2 ... days

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] Suspension calcultation doesn't honour 'Fine charging interval '

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] Suspension calcultation doesn't honour 'Fine charging interval '

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

--- Comment #1 from Jonathan Druart <[hidden email]> ---
Created attachment 69783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69783&action=edit
Bug 19804: Add new DB column issuingrules.suspension_chargeperiod

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] Suspension calcultation doesn't honour 'Fine charging interval '

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

--- Comment #2 from Jonathan Druart <[hidden email]> ---
Created attachment 69784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69784&action=edit
Bug 19804: DBIC Schema changes

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] Suspension calcultation doesn't honour 'Fine charging interval '

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

--- Comment #3 from Jonathan Druart <[hidden email]> ---
Created attachment 69785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69785&action=edit
Bug 19804: Add a 'Fine charging interval' for suspension days

We already have a chargeperiod (Fine charging interval) value which is
taken into account for fine ($) for not for the suspension period.

This patch adds a new column suspension_chargeperiod (Fine day charging
interval) to add the same behaviour when a suspension is calculated.

Test plan:
Add overdue item and play with the circulation rules (and the calendar).
The suspension period must be correctly calculated.
Please provide the different tests you made.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] Suspension calcultation doesn't honour 'Fine charging interval '

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

--- Comment #4 from Jonathan Druart <[hidden email]> ---
Created attachment 69786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69786&action=edit
Bug 19804: Add the new column to the circ rules interface

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Suspension calcultation     |Suspension calculation
                   |doesn't honour 'Fine        |doesn't honour 'Fine
                   |charging interval'          |charging interval'
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org
           Assignee|[hidden email]-commun |[hidden email]-c
                   |ity.org                     |ommunity.org

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

--- Comment #5 from Hugo Agud <[hidden email]> ---
Good morning

I have insall the patch into kohadev, I have checked out and checked in several
items with different configuration and it works..

I have created a rule of 1 suspension day for every 2 delay

Case 1
Cumulative on
Calendar without holidays--> works as espected
Calendar with holiday -->  work as expected


Cumulative off
Calendar without holidays --> works as expected
Calendar with holidays -->  works as expected

I missed something to check, if not I will sign it asap

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Hugo Agud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69783|0                           |1
        is obsolete|                            |

--- Comment #6 from Hugo Agud <[hidden email]> ---
Created attachment 70404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70404&action=edit
Bug 19804: Add new DB column issuingrules.suspension_chargeperiod

Signed-off-by: Hugo Agud <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Hugo Agud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69784|0                           |1
        is obsolete|                            |

--- Comment #7 from Hugo Agud <[hidden email]> ---
Created attachment 70405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70405&action=edit
Bug 19804: DBIC Schema changes

Signed-off-by: Hugo Agud <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Hugo Agud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69785|0                           |1
        is obsolete|                            |

--- Comment #8 from Hugo Agud <[hidden email]> ---
Created attachment 70406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70406&action=edit
Bug 19804: Add a 'Fine charging interval' for suspension days

We already have a chargeperiod (Fine charging interval) value which is
taken into account for fine ($) for not for the suspension period.

This patch adds a new column suspension_chargeperiod (Fine day charging
interval) to add the same behaviour when a suspension is calculated.

Test plan:
Add overdue item and play with the circulation rules (and the calendar).
The suspension period must be correctly calculated.
Please provide the different tests you made.

Signed-off-by: Hugo Agud <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Hugo Agud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69786|0                           |1
        is obsolete|                            |

--- Comment #9 from Hugo Agud <[hidden email]> ---
Created attachment 70407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70407&action=edit
Bug 19804: Add the new column to the circ rules interface

Signed-off-by: Hugo Agud <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19804] Suspension calculation doesn't honour 'Fine charging interval'

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804

Hugo Agud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/