[Bug 19629] New: No translatable notification in overdue notices

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 19629] New: No translatable notification in overdue notices

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19629

            Bug ID: 19629
           Summary: No translatable notification in overdue notices
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

If  PrintNoticesMaxLines is set and the number of overdue items is greater than
this limit, then the phrase "List too long for form; please check your account
online for a complete list of your overdue items." is added at the end of the
letter.

But this is not translatable, and not necessarily at the right place.

Maybe it could be possible to use a placeholder (like <<items.content>>) to
tell where to add this notification, and then make it translatable.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19629] No translatable notification in overdue notices

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19629

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <[hidden email]> ---
Will be easy to do using the TT syntax.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19629] No translatable notification in overdue notices

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19629

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |m

--- Comment #2 from Victor Grousset/tuxayo <[hidden email]> ---
(In reply to Jonathan Druart from comment #1)
> Will be easy to do using the TT syntax.

Is this solution implementable without a major rework of how the letter is
built?

Relevant parts of the code:
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/overdue_notices.pl;h=a1b477c7317c140bd361540fc65086df6c7fb420;hb=HEAD#l687

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/overdue_notices.pl;h=a1b477c7317c140bd361540fc65086df6c7fb420;hb=HEAD#l708

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19629] No translatable notification in overdue notices

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19629

--- Comment #3 from Jonathan Druart <[hidden email]> ---
Take a look at bug 17967, and then if we can access to Koha.Preference from the
notice template. I think it does not work but it can be done easily with:

@ Letters.pm:1477 @ sub _process_tt {

     my $tt_params = { %{ _get_tt_params( $tables ) }, %{ _get_tt_params(
$loops, 'is_a_loop' ) }, %$substitute };

-    $content = qq|[% USE KohaDates %]$content|;
+    $content = qq|[% USE Koha %][% USE KohaDates %]$content|;

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/