[Bug 19591] New: Saving a system preference jumps to main page

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 19591] New: Saving a system preference jumps to main page

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

            Bug ID: 19591
           Summary: Saving a system preference jumps to main page
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

I don't know if this was intended or not.

When saving a system preference, it jumps to the main page of the category,
instead of staying on the searched system preference, like in 3.22.

Test:
1. Search a system preference, i. e. Opaccredits.
2. Change something.
3. Save it.
4. It jumps to the "category subpage" on the left side.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19591] Saving a system preference jumps to main page

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

--- Comment #1 from Owen Leonard <[hidden email]> ---
When you save a system preference the page shouldn't refresh at all. The change
happens behind the scenes and a message should pop up briefly indicating
success.

If you find that clicking the save button redirects the page, you might have a
JavaScript error somewhere. Do you have something in the IntranetUserJS system
preference?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19591] Saving a system preference jumps to main page

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

--- Comment #2 from Christian Stelzenmüller <[hidden email]> ---
(In reply to Owen Leonard from comment #1)
> When you save a system preference the page shouldn't refresh at all. The
> change happens behind the scenes and a message should pop up briefly
> indicating success.
>
> If you find that clicking the save button redirects the page, you might have
> a JavaScript error somewhere. Do you have something in the IntranetUserJS
> system preference?

There is indeed a js error:
"Error: Syntax error, unrecognized expression: .transl."

Maybe it's that. I'll ask Katrin on Monday, thanks :-)

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19591] Saving a system preference jumps to main page

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Josef Moravec <[hidden email]> ---
I tried on master and it works for me. Do you use some other language then
english? Or do you have something in intranetuserjs preference?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19591] Saving a system preference jumps to main page

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

--- Comment #4 from Christian Stelzenmüller <[hidden email]> ---
Yes, it's Intranetuserjs.

It must be something in these parts:

var currlang = $('html').attr('lang');
$(".transl").hide();
$(".transl." + currlang).show();

if (currlang == 'en' || currlang == 'en-GB') {
$("span.results_summary span.de-DE").hide();
} else {
$("span.results_summary span.en").hide();
}

Thanks for the help!

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19591] Saving a system preference jumps to main page

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

--- Comment #5 from Christian Stelzenmüller <[hidden email]> ---
It's the second dot in ".transl."

In 16.11 it's causing that error

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19591] Saving a system preference jumps to main page

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #6 from Josef Moravec <[hidden email]> ---
(In reply to Christian Stelzenmüller from comment #4)

> Yes, it's Intranetuserjs.
>
> It must be something in these parts:
>
> var currlang = $('html').attr('lang');
> $(".transl").hide();
> $(".transl." + currlang).show();
>
> if (currlang == 'en' || currlang == 'en-GB') {
> $("span.results_summary span.de-DE").hide();
> } else {
> $("span.results_summary span.en").hide();
> }
>
> Thanks for the help!


So I am closing this bug.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19591] Saving a system preference jumps to main page

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

--- Comment #7 from Christian Stelzenmüller <[hidden email]> ---
Now we found the exact cause:

The language in the html from the system preference page ist missing:

<html lang="">

Therefore the js regarding the language caused this error.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/