[Bug 19560] New: Special characters & and # in branchcode - unable to delete branch

classic Classic list List threaded Threaded
27 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] New: Special characters & and # in branchcode - unable to delete branch

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

            Bug ID: 19560
           Summary: Special characters & and # in branchcode - unable to
                    delete branch
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

Special Characters in Branchcode cause the user to be unable to delete the
branch.

Replicate:
1. Administration->Libraries and Groups
2. Click on New Library button
3. Create a new branch use the & or # character in the branchcode
4. Branch is created.
5. Click on Delete (under Actions) for that branch
6. Verify you wish to delete the branch.
7. Error message appears
An error occurred when deleting this library. Check the logs.

Can this field be validated when data is entered?  We should not allow users to
create branchcodes that use special characters.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Special characters & and # in branchcode - unable to delete branch

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |
            Version|17.05                       |master
           Severity|enhancement                 |normal
             Status|NEW                         |ASSIGNED

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete branch when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Special characters & and #  |Unable to delete branch
                   |in branchcode - unable to   |when branchcode contains
                   |delete branch               |special characters

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Unable to delete branch     |Unable to delete library
                   |when branchcode contains    |when branchcode contains
                   |special characters          |special characters

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #1 from Owen Leonard <[hidden email]> ---
Created attachment 69062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69062&action=edit
Bug 19560: Unable to delete library when branchcode contains special characters

This patch modifies the library administration page so that the library
delete button submits a form using POST rather than linking to the
delete operation with GET variables.

This patch also adds validation to the library entry form so that it
will only accept letters, numbers, hyphen, and underscore.

The validation method for this already existed in categories.js, so it
has been moved to staff-global.js and the validator warning message has
been moved to validator-strings.inc so it is included globally.

To test:
  - Add a library with a branchcode containing characters like & or
    #.
  - Apply the patch and clear your browser cache if necessary.
  - Try to delete the new library. It should delete successfully.
  - Add a library again and try to include spaces and/or special
    characters in the branchcode. The form validation script should
    prevent you from submitting the form.
  - Go do Administration -> Patron categories and add a new patron
    category. The category code field should prevent you from entering a
    code with spaces or special characters.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19607


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607
[Bug 19607] Move admin templates JavaScript to the footer: Basic parameters
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

David Bourgault <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69062|0                           |1
        is obsolete|                            |

--- Comment #2 from David Bourgault <[hidden email]> ---
Created attachment 69097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69097&action=edit
Bug 19560: Unable to delete library when branchcode contains special characters

This patch modifies the library administration page so that the library
delete button submits a form using POST rather than linking to the
delete operation with GET variables.

This patch also adds validation to the library entry form so that it
will only accept letters, numbers, hyphen, and underscore.

The validation method for this already existed in categories.js, so it
has been moved to staff-global.js and the validator warning message has
been moved to validator-strings.inc so it is included globally.

To test:
  - Add a library with a branchcode containing characters like & or
    #.
  - Apply the patch and clear your browser cache if necessary.
  - Try to delete the new library. It should delete successfully.
  - Add a library again and try to include spaces and/or special
    characters in the branchcode. The form validation script should
    prevent you from submitting the form.
  - Go do Administration -> Patron categories and add a new patron
    category. The category code field should prevent you from entering a
    code with spaces or special characters.

Signed-off-by: David Bourgault <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

David Bourgault <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |[hidden email]

--- Comment #3 from David Bourgault <[hidden email]> ---
QA tool passed
Works as described, but also prevents accentuated characters like é or à. For
category codes I think this is acceptable/preferable.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69097|0                           |1
        is obsolete|                            |

--- Comment #4 from Nick Clemens <[hidden email]> ---
Created attachment 69130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69130&action=edit
Bug 19560: Unable to delete library when branchcode contains special characters

This patch modifies the library administration page so that the library
delete button submits a form using POST rather than linking to the
delete operation with GET variables.

This patch also adds validation to the library entry form so that it
will only accept letters, numbers, hyphen, and underscore.

The validation method for this already existed in categories.js, so it
has been moved to staff-global.js and the validator warning message has
been moved to validator-strings.inc so it is included globally.

To test:
  - Add a library with a branchcode containing characters like & or
    #.
  - Apply the patch and clear your browser cache if necessary.
  - Try to delete the new library. It should delete successfully.
  - Add a library again and try to include spaces and/or special
    characters in the branchcode. The form validation script should
    prevent you from submitting the form.
  - Go do Administration -> Patron categories and add a new patron
    category. The category code field should prevent you from entering a
    code with spaces or special characters.

Signed-off-by: David Bourgault <[hidden email]>

Signed-off-by: Nick Clemens <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from Nick Clemens <[hidden email]> ---
I think this is a good start. We probably want these restrictions on authorised
values too.

We will also need a warning on the about page for pre-existing values

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Katrin Fischer <[hidden email]> ---
(In reply to Nick Clemens from comment #5)
> I think this is a good start. We probably want these restrictions on
> authorised values too.
>
> We will also need a warning on the about page for pre-existing values

We didn't do this on authorised values because of things like MAN_INV - this
has the display text in the field for the code :(

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|19608                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org
             Status|Passed QA                   |In Discussion

--- Comment #7 from Jonathan Druart <[hidden email]> ---
This patch does 2 things:
1. Only accept few chars for branchcode (accentuated chars are rejected)
2. Fix the deletion problem if a branchcode contains special characters

It may be a problem for non latin alphabets to restrict as possiblities. Do we
have known problems with branchcode containing special chars?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #8 from Joy Nelson <[hidden email]> ---
Jonathon,
I encountered this because a library was adding a branch for "Art &
Architecture" as A&A
When they decided to go with a different naming convention, they were unable to
delete the branch.

joy


(In reply to Jonathan Druart from comment #7)
> This patch does 2 things:
> 1. Only accept few chars for branchcode (accentuated chars are rejected)
> 2. Fix the deletion problem if a branchcode contains special characters
>
> It may be a problem for non latin alphabets to restrict as possiblities. Do
> we have known problems with branchcode containing special chars?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #9 from Jonathan Druart <[hidden email]> ---
Created attachment 69423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69423&action=edit
Bug 19560: Correctly escape branchcode in admin/branches.pl

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #10 from Jonathan Druart <[hidden email]> ---
Joy, What I tried to say is: If we escape correctly the variable, we will not
have problem to delete a library with branchcode=A&A, see the follow-up.
I am so wondering if it is really useful to restrict the code to a-Z0-9_-

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #11 from Joy Nelson <[hidden email]> ---
Ah!  I see.  Yes, escaping or restricting would work.  I can't say I have a
preference in the matter.  

Thanks!
joy

(In reply to Jonathan Druart from comment #10)
> Joy, What I tried to say is: If we escape correctly the variable, we will
> not have problem to delete a library with branchcode=A&A, see the follow-up.
> I am so wondering if it is really useful to restrict the code to a-Z0-9_-

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #12 from Owen Leonard <[hidden email]> ---
As far as I can tell, JavaScript regular expressions will not recognize
non-ascii "word" characters as such, and thus client-side validation can't work
here unless we restrict the options quite a bit.

I appreciate that this limitation with my patch has bee pointed out because I
don't think it's okay that we make it so strict if we don't have to.

Is it a limitation of branches.pl that it fails to accept a string like this?

/cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=Ö×Ø&ÙÚ

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69423|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart <[hidden email]> ---
Created attachment 69490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69490&action=edit
Bug 19560: Correctly escape branchcode in admin/branches.pl

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #14 from Jonathan Druart <[hidden email]> ---
(In reply to Owen Leonard from comment #12)
> Is it a limitation of branches.pl that it fails to accept a string like this?
>
> /cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=Ö×Ø&ÙÚ

Fixed with the last patch.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #15 from Josef Moravec <[hidden email]> ---
IMO the escaping is better solution - we need it anyway for prevent XSS and it
is enough to solve this issue - so no reason to restrict the letters in
branchcode.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #16 from Owen Leonard <[hidden email]> ---
Should we still reject brachcodes with whitespace characters?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #17 from Jonathan Druart <[hidden email]> ---
(In reply to Owen Leonard from comment #16)
> Should we still reject brachcodes with whitespace characters?

Yes I think so (for command line scripts)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19560] Unable to delete library when branchcode contains special characters

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #18 from Josef Moravec <[hidden email]> ---
(In reply to Jonathan Druart from comment #17)
> (In reply to Owen Leonard from comment #16)
> > Should we still reject brachcodes with whitespace characters?
>
> Yes I think so (for command line scripts)

I agree

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/