[Bug 19549] New: Reserve Slip prints first found hold when patron has multiple holds on a biblio

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 19549] New: Reserve Slip prints first found hold when patron has multiple holds on a biblio

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

            Bug ID: 19549
           Summary: Reserve Slip prints first found hold when patron has
                    multiple holds on a biblio
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

In C4/Reserves.pm the ReserveSlip function uses this call to get the reserve:
1982     my $hold = Koha::Holds->search({biblionumber => $biblionumber,
borrowernumber => $borrowernumber })->next;

If a patron has multiple holds there is no way to know if we have the correct
one.

This function should be updated to take an itemnumber as well and all calls
updated.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

--- Comment #1 from Kyle M Hall <[hidden email]> ---
Created attachment 68855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68855&action=edit
Bug 19549 - Reserve Slip prints first found hold when patron has multiple holds
on a biblio

In C4/Reserves.pm the ReserveSlip function uses this call to get the reserve:
1982     my $hold = Koha::Holds->search({biblionumber => $biblionumber,
borrowernumber => $borrowernumber })->next;

If a patron has multiple holds there is no way to know if we have the correct
one.

This function should be updated to take an itemnumber as well and all calls
updated.

Test Plan:
1) Apply this patch
2) Capture some holds, ensure the correct hold was caught and printed in the
notice
3) prove t/db_dependent/Reserves.t

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Jason Palmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Caroline Cyr La Rose <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose@inlibr
                   |                            |o.com

--- Comment #2 from Caroline Cyr La Rose <[hidden email]> ---
Is this for multiple holds on the same biblio?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

--- Comment #3 from Jason Palmer <[hidden email]> ---
(In reply to Caroline Cyr La Rose from comment #2)
> Is this for multiple holds on the same biblio?

Yes.  Multiple holds for same bib.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Jason Palmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/