[Bug 19485] New: Limiting by title-series (se) broken on ES

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 19485] New: Limiting by title-series (se) broken on ES

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

            Bug ID: 19485
           Summary: Limiting by title-series (se) broken on ES
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: [hidden email]
          Reporter: [hidden email]

When filtering/limiting search results by Series title, the limit field name
passed to ES is 'title-series' but it expects 'se', causing no results to be
found.

This is particularly confusing as the page URL clearly says limit=se:XYZ.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19485] Limiting by title-series (se) broken on ES

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

David Bourgault <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19485] Limiting by title-series (se) broken on ES

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

--- Comment #1 from David Bourgault <[hidden email]> ---
Created attachment 68260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68260&action=edit
Bug 19485 - Don't transform se: limit for ES

This removes the field name conversion for the Series title. Before it would
transform 'se' into 'title-series', now in won't since ES indexes as 'se' by
default.

TEST PLAN:
0) Create a record with a "Series title" tag (440$a or 490$a in MARC21)
1) In the OPAC, do a search which would include the record from step 0)
2) In the left facet selection, click on the series title.
<==== Without patch
3) No results will be shown, the breadcrumbs show the limit as 'title-series'
====> With patch applied
3) Results will show correctly, breadcrumbs show the limit as 'se'

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19485] Limiting by title-series (se) broken on ES

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Katrin Fischer <[hidden email]> ---
I finally got Elasticsearch working but seem to be missing the mappings -
facets are not showing and the administration page is empty. Can you help me
with a hint?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19485] Limiting by title-series (se) broken on ES

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

--- Comment #3 from David Bourgault <[hidden email]> ---
The mappings are supposed to be located in
admin/searchengine/elasticsearch/mappings.yaml

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19485] Limiting by title-series (se) broken on ES

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

Séverine Queune <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19485] Limiting by title-series (se) broken on ES

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |[hidden email]

--- Comment #4 from Nick Clemens <[hidden email]> ---
This works, but I am not sure it is the best solution - bug 19575 fixes things
the other way, providing a friendlier name to the index - can you think of
benefits to ths approach over the other?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19485] Limiting by title-series (se) broken on ES

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

David Bourgault <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #5 from David Bourgault <[hidden email]> ---
>can you think of benefits to ths approach over the other?

No I can't. David Gustafsson's approach is much better. I used my solution only
because I wasn't confident enough with ES to make big changes.

I'm not sure what the correct status is, I'll set it to RESOLVED DUPLICATE.

*** This bug has been marked as a duplicate of bug 19575 ***

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/