[Bug 19469] New: Add ability to split view of holds view on record by pickup library and/ or itemtype

classic Classic list List threaded Threaded
61 messages Options
123
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] New: Add ability to split view of holds view on record by pickup library and/ or itemtype

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

            Bug ID: 19469
           Summary: Add ability to split view of holds view on record by
                    pickup library and/or itemtype
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/ or itemtype

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/ or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

--- Comment #1 from Kyle M Hall <[hidden email]> ---
It is possible to set up circulation rules to limit trapping of holds by pickup
library and itemtype. To make it easier to understand which holds will be
trapped in a given circumstance, it would be nice if we could optionally group
holds by pickup library and/or itemtype.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/ or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/ or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

--- Comment #2 from Kyle M Hall <[hidden email]> ---
Created attachment 68166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68166&action=edit
Bug 19469 - Clean up template whitespace

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/ or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

--- Comment #3 from Kyle M Hall <[hidden email]> ---
Created attachment 68167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68167&action=edit
Bug 19469 - Add ability to split view of holds view on record by pickup library
and/or itemtype

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/ or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68166|0                           |1
        is obsolete|                            |
  Attachment #68167|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <[hidden email]> ---
Created attachment 68168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68168&action=edit
Bug 19469 - Clean up template whitespace

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/ or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

--- Comment #5 from Kyle M Hall <[hidden email]> ---
Created attachment 68169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68169&action=edit
Bug 19469 - Add ability to split view of holds view on record by pickup library
and/or itemtype

It is possible to set up circulation rules to limit trapping of holds by pickup
library and itemtype.
To make it easier to understand which holds will be trapped in a given
circumstance,
it would be nice if we could optionally group holds by pickup library and/or
itemtype.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Enable AllowHoldItemTypeSelection
4) Pick a record and create holds with various pickup libraries and itemtype
combinations
5) Enable HoldsSplitQueueNumbering
6) Try the different combinations of HoldsSplitQueue
7) Ensure the hold "arrows" move the items correctly
   * Up and down arrows should move hold above or below the adjacent hold
within a hold fieldset
   * Top and borrom arrows should move hold to the top or bottom within a hold
fieldset

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/ or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68168|0                           |1
        is obsolete|                            |

--- Comment #6 from Alex Buckley <[hidden email]> ---
Created attachment 68347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68347&action=edit
Bug 19469 - Clean up template whitespace

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

Passed QA test tool
Signed-off-by: Alex Buckley <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/ or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/ or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68169|0                           |1
        is obsolete|                            |

--- Comment #7 from Alex Buckley <[hidden email]> ---
Created attachment 68348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68348&action=edit
Bug 19469 - Add ability to split view of holds view on record by pickup library
and/or itemtype

It is possible to set up circulation rules to limit trapping of holds by pickup
library and itemtype.
To make it easier to understand which holds will be trapped in a given
circumstance,
it would be nice if we could optionally group holds by pickup library and/or
itemtype.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Enable AllowHoldItemTypeSelection
4) Pick a record and create holds with various pickup libraries and itemtype
combinations
5) Enable HoldsSplitQueueNumbering
6) Try the different combinations of HoldsSplitQueue
7) Ensure the hold "arrows" move the items correctly
   * Up and down arrows should move hold above or below the adjacent hold
within a hold fieldset
   * Top and borrom arrows should move hold to the top or bottom within a hold
fieldset

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

Followed test plan, patch worked as described. Also passed QA test tool

Signed-off-by: Alex Buckley <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/ or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Andreas Hedström Mace <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68348|0                           |1
        is obsolete|                            |

--- Comment #8 from Andreas Hedström Mace <[hidden email]> ---
Created attachment 68609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68609&action=edit
Bug 19469 - Add ability to split view of holds view on record by pickup library
and/or itemtype

It is possible to set up circulation rules to limit trapping of holds by pickup
library and itemtype.
To make it easier to understand which holds will be trapped in a given
circumstance,
it would be nice if we could optionally group holds by pickup library and/or
itemtype.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Enable AllowHoldItemTypeSelection
4) Pick a record and create holds with various pickup libraries and itemtype
combinations
5) Enable HoldsSplitQueueNumbering
6) Try the different combinations of HoldsSplitQueue
7) Ensure the hold "arrows" move the items correctly
   * Up and down arrows should move hold above or below the adjacent hold
within a hold fieldset
   * Top and borrom arrows should move hold to the top or bottom within a hold
fieldset

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

Followed test plan, patch worked as described. Also passed QA test tool

Signed-off-by: Alex Buckley <[hidden email]>
Signed-off-by: Andreas Hedström Mace <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/ or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
         QA Contact|[hidden email]-communit |[hidden email]
                   |y.org                       |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68347|0                           |1
        is obsolete|                            |
  Attachment #68609|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <[hidden email]> ---
Created attachment 72304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72304&action=edit
Bug 19469 - Clean up template whitespace

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

Passed QA test tool
Signed-off-by: Alex Buckley <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

--- Comment #10 from Kyle M Hall <[hidden email]> ---
Created attachment 72305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72305&action=edit
Bug 19469 - Add ability to split view of holds view on record by pickup library
and/or itemtype

It is possible to set up circulation rules to limit trapping of holds by pickup
library and itemtype.
To make it easier to understand which holds will be trapped in a given
circumstance,
it would be nice if we could optionally group holds by pickup library and/or
itemtype.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Enable AllowHoldItemTypeSelection
4) Pick a record and create holds with various pickup libraries and itemtype
combinations
5) Enable HoldsSplitQueueNumbering
6) Try the different combinations of HoldsSplitQueue
7) Ensure the hold "arrows" move the items correctly
   * Up and down arrows should move hold above or below the adjacent hold
within a hold fieldset
   * Top and borrom arrows should move hold to the top or bottom within a hold
fieldset

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

Followed test plan, patch worked as described. Also passed QA test tool

Signed-off-by: Alex Buckley <[hidden email]>
Signed-off-by: Andreas Hedström Mace <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Andreas Hedström Mace <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |u.se

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72304|0                           |1
        is obsolete|                            |

--- Comment #11 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 72441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72441&action=edit
Bug 19469: Clean up template whitespace

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

Passed QA test tool
Signed-off-by: Alex Buckley <[hidden email]>
Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72305|0                           |1
        is obsolete|                            |

--- Comment #12 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 72442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72442&action=edit
Bug 19469: Add ability to split view of holds view on record by pickup library
and/or itemtype

It is possible to set up circulation rules to limit trapping of holds by pickup
library and itemtype.
To make it easier to understand which holds will be trapped in a given
circumstance,
it would be nice if we could optionally group holds by pickup library and/or
itemtype.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Enable AllowHoldItemTypeSelection
4) Pick a record and create holds with various pickup libraries and itemtype
combinations
5) Enable HoldsSplitQueueNumbering
6) Try the different combinations of HoldsSplitQueue
7) Ensure the hold "arrows" move the items correctly
   * Up and down arrows should move hold above or below the adjacent hold
within a hold fieldset
   * Top and borrom arrows should move hold to the top or bottom within a hold
fieldset

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

Followed test plan, patch worked as described. Also passed QA test tool

Signed-off-by: Alex Buckley <[hidden email]>
Signed-off-by: Andreas Hedström Mace <[hidden email]>
Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

--- Comment #13 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 72443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72443&action=edit
Bug 19469: (followup) Use patron-title.inc as proposed by bug 18403

This patch makes the new template include file use the patron-title.inc
include to render the patron name.

Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

--- Comment #14 from Josef Moravec <[hidden email]> ---
Comment on attachment 72442
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72442
Bug 19469: Add ability to split view of holds view on record by pickup library
and/or itemtype

Review of attachment 72442:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19469&attachment=72442)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
@@ +1,1 @@
> +[% USE Dumper %]

debug?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

--- Comment #15 from Kyle M Hall <[hidden email]> ---
(In reply to Josef Moravec from comment #14)

> Comment on attachment 72442 [details] [review]
> Bug 19469: Add ability to split view of holds view on record by pickup
> library and/or itemtype
>
> Review of attachment 72442 [details] [review]:
> -----------------------------------------------------------------
>
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
> @@ +1,1 @@
> > +[% USE Dumper %]
>
> debug?

Yep! Followup coming!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

--- Comment #16 from Kyle M Hall <[hidden email]> ---
Created attachment 72501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72501&action=edit
Bug 19469: Remove use of Dumper on request.tt

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org
             Status|Passed QA                   |Failed QA

--- Comment #17 from Jonathan Druart <[hidden email]> ---
I think I found few inconsistencies.

Try with HoldsSplitQueue = both and HoldsSplitQueueNumbering = actual.

From this starting point:
https://screenshots.firefox.com/TX15YNJl7t9SF3LD/pro.kohadev.org

1. Last lines of the 2 blocks have the "lowest priority" icon, I would expect
only the first one (with priority=9)

2. item-level_itypes=item and all of the items.itype=BK, why do I have the item
level holds in the "Any item type" block?

3. If I change one of the priority from x to 9 using the selects, nothing
happens (same issue if I change 9 to x).


I will continue to test when this will be fixed.
It is certainly better for the readability to squash the patches.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

--- Comment #18 from Jonathan Druart <[hidden email]> ---
Created attachment 74260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74260&action=edit
Bug 19469: [DO NOT PUSH] Dump of the reserves table

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

--- Comment #19 from Jonathan Druart <[hidden email]> ---
(In reply to Jonathan Druart from comment #18)
> Created attachment 74260 [details] [review]
> Bug 19469: [DO NOT PUSH] Dump of the reserves table

Here is the content of my table "reserves" (on top of sample data).

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72441|0                           |1
        is obsolete|                            |
  Attachment #72442|0                           |1
        is obsolete|                            |
  Attachment #72443|0                           |1
        is obsolete|                            |
  Attachment #72501|0                           |1
        is obsolete|                            |
  Attachment #74260|0                           |1
        is obsolete|                            |

--- Comment #20 from Kyle M Hall <[hidden email]> ---
Created attachment 74328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74328&action=edit
Bug 19469: Clean up template whitespace

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

Passed QA test tool
Signed-off-by: Alex Buckley <[hidden email]>
Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74328|0                           |1
        is obsolete|                            |

--- Comment #21 from Kyle M Hall <[hidden email]> ---
Created attachment 74329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74329&action=edit
Bug 19469: Clean up template whitespace

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

Passed QA test tool
Signed-off-by: Alex Buckley <[hidden email]>
Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469

--- Comment #22 from Kyle M Hall <[hidden email]> ---
Created attachment 74330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74330&action=edit
Bug 19469: Add ability to split view of holds view on record by pickup library
and/or itemtype

It is possible to set up circulation rules to limit trapping of holds by pickup
library and itemtype.
To make it easier to understand which holds will be trapped in a given
circumstance,
it would be nice if we could optionally group holds by pickup library and/or
itemtype.

Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Enable AllowHoldItemTypeSelection
4) Pick a record and create holds with various pickup libraries and itemtype
combinations
5) Enable HoldsSplitQueueNumbering
6) Try the different combinations of HoldsSplitQueue
7) Ensure the hold "arrows" move the items correctly
   * Up and down arrows should move hold above or below the adjacent hold
within a hold fieldset
   * Top and borrom arrows should move hold to the top or bottom within a hold
fieldset

Sponsored-by: Stockholm University Library

Signed-off-by: Kyle M Hall <[hidden email]>

Followed test plan, patch worked as described. Also passed QA test tool

Signed-off-by: Alex Buckley <[hidden email]>
Signed-off-by: Andreas Hedström Mace <[hidden email]>
Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
123