[Bug 19457] New: If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

classic Classic list List threaded Threaded
23 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] New: If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

            Bug ID: 19457
           Summary: If CheckPrevCheckout is set to "Do", then checkouts
                    are blocked at the SIPServer
 Change sponsored?: ---
           Product: Koha
           Version: 16.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

If a library uses the system preference CheckPrevCheckout (Check for a previous
issue) then, at the staff client, the issue is blocked with a dialogue asking
if the checkout should be allowed or not, this is correct.

However, for the sipserver, if CheckPrevCheckout is set to "Do" then the
checkout is blocked with a generic "1" code and the checkout is refused by the
self check.

There is an argument that this is correct but, it is more likely that libraries
would want to allow the checkout in this scenario as there is no explanation to
the block and, most likely, it would be a genuine transaction.

The sipserver needs an exception to handle this scenario.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Sally Healey <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey@cheshireshared
                   |                            |services.gov.uk

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

--- Comment #1 from Liz Rea <[hidden email]> ---
Created attachment 72187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72187&action=edit
Bug 19457: If CheckPrevCheckout is set to Do, then checkouts are blocked at the
SIPServer

To test:

Set CheckPrevCheckout to Do, or Do, with confirmation
Verify the SIP server is blocking checkouts with this setting set
Apply this patch
Note that the checkout is now allowed, with a screen message telling the
borrower they've issued the item before.y

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Colin Campbell <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72187|0                           |1
        is obsolete|                            |

--- Comment #2 from Colin Campbell <[hidden email]> ---
Created attachment 72216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72216&action=edit
Signed off amended patch

Signed off patch - works as advertised
Fixed a typo there was an extra ) after the screen message
indented the conditional to match preceding and break on the conditions

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Colin Campbell <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--- Comment #3 from Katrin Fischer <[hidden email]> ---
Is this specific to 16.11?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

--- Comment #4 from Colin Campbell <[hidden email]> ---
(In reply to Katrin Fischer from comment #3)
> Is this specific to 16.11?

No I think that is 16.11 and greater

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|16.11                       |master

--- Comment #5 from Katrin Fischer <[hidden email]> ---
Thx Colin, changing to master (bugs get backported from new to old)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Colin Campbell <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72216|0                           |1
        is obsolete|                            |

--- Comment #6 from Colin Campbell <[hidden email]> ---
Created attachment 72771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72771&action=edit
revision to signed off patch

Amended the yes value to hardyes - this reflects the values of the syspref as
in releases from 16.11 to current. 'yes' was the value in the test db I was
using (and I assume Liz's) probably from an earlier release of the patch that
added the syspref. - Tested against production as well

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72771|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <[hidden email]> ---
Created attachment 73858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73858&action=edit
Bug 19457: If CheckPrevCheckout is set to Do, then checkouts are blocked at the
SIPServer

To test:

Set CheckPrevCheckout to Do, or Do, with confirmation
Verify the SIP server is blocking checkouts with this setting set
Apply this patch
Note that the checkout is now allowed, with a screen message telling the
borrower they've issued the item before.y

Signed-off-by: Colin Campbell <[hidden email]>

Signed-off-by: Kyle M Hall <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #8 from Jonathan Druart <[hidden email]> ---
I need a confirmation here.

The test plan says "Set CheckPrevCheckout to Do, or Do, with confirmation", but
it's "unless overriden, do". That means we should check the patron category and
patron's settings as well.

Finally it sounds like this flag is set when the error/warning must be
displayed, and maybe the following code would be enough:

} elsif ($confirmation eq 'PREVISSUE') {
    $self->screen_msg("This item was previously checked out by you");
    last;
}

Could someone confirm or tell me what I am missing?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
         Depends on|                            |6906


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906
[Bug 6906] Show 'Borrower has previously issued $ITEM' alert on checkout
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA

--- Comment #9 from Katrin Fischer <[hidden email]> ---
(In reply to Jonathan Druart from comment #8)

> I need a confirmation here.
>
> The test plan says "Set CheckPrevCheckout to Do, or Do, with confirmation",
> but it's "unless overriden, do". That means we should check the patron
> category and patron's settings as well.
>
> Finally it sounds like this flag is set when the error/warning must be
> displayed, and maybe the following code would be enough:
>
> } elsif ($confirmation eq 'PREVISSUE') {
>     $self->screen_msg("This item was previously checked out by you");
>     last;
> }
>
> Could someone confirm or tell me what I am missing?

There is no setting on patron category here - so this is alright. The pref has
4 values that seem a little confusing.

https://bywatersolutions.com/2017/10/09/koha-tutorial-check-previous-checkouts/

I feel the patch is correct.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20569

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--- Comment #10 from Jonathan Druart <[hidden email]> ---
(In reply to Katrin Fischer from comment #9)

> (In reply to Jonathan Druart from comment #8)
> > I need a confirmation here.
> >
> > The test plan says "Set CheckPrevCheckout to Do, or Do, with confirmation",
> > but it's "unless overriden, do". That means we should check the patron
> > category and patron's settings as well.
> >
> > Finally it sounds like this flag is set when the error/warning must be
> > displayed, and maybe the following code would be enough:
> >
> > } elsif ($confirmation eq 'PREVISSUE') {
> >     $self->screen_msg("This item was previously checked out by you");
> >     last;
> > }
> >
> > Could someone confirm or tell me what I am missing?
>
> There is no setting on patron category here - so this is alright. The pref
> has 4 values that seem a little confusing.

No it's not confusing, it's a great way to behave (inheritance). The patron's
category can set this value is pref is set to relevant value (softyes, softno).

I still think the tests are not necessary, waiting for an answer from patch's
author or testers.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

--- Comment #11 from Katrin Fischer <[hidden email]> ---
You are right, the setting on category only appears when you set a 'do'
setting. Which is a little confusing. :(

The important bis is that it should not block the circulation when set to
softyes/hardyes. So apart from the message, we need to do something about the
flag that blocks?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

Magnus Enger <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #12 from Magnus Enger <[hidden email]> ---
(In reply to Jonathan Druart from comment #10)
> I still think the tests are not necessary, waiting for an answer from
> patch's author or testers.

Consider this a friendly "ping". :-) Would be nice to have a fix for this.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

--- Comment #13 from Liz Rea <[hidden email]> ---
The use case this patch was originally developed for was display a message if
the item was previously issued, if the setting was either hard or soft yes.

If you tell me what you're requiring, I'll be happy to fix it in whatever way
you want.

Cheers,
Liz

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

--- Comment #14 from Liz Rea <[hidden email]> ---
They didn't care about blocking from the self check, at all.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19457] If CheckPrevCheckout is set to "Do", then checkouts are blocked at the SIPServer

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457

--- Comment #15 from Katrin Fischer <[hidden email]> ---
Hi Liz, you check the preference only, but this can be overwritten for each
patron category. I missed it at first too - you need to switch the pref to do.
Also take a look at comment#8.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/