[Bug 19287] New: Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

classic Classic list List threaded Threaded
46 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] New: Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

            Bug ID: 19287
           Summary: Add ability to mark an item ‘Lost’ from ‘Holds
                    awaiting pickup’ list
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Hold requests
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

The BULAC (http://www.bulac.fr/) would like to mark items not found on shelves
after patrons’ holds as ‘Lost’ directly from the “Circulation > Holds awaiting
pickup” list.

We could have a new button on the “Action” columns of the 2 tabs,  producing 3
automatic actions :
  - cancel the hold
  - notify the patron if the hold was supposed to be available (the notice
should be set on the “Tools > Notices and Slips” menu)
  - set the field “items.notforloan” or “items.itemlost” (define in a system
preference) from “0” to a value from the same ‘authorized values list’ and set
in another system preference

As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to
quote us for the development of such a feature or just ask for more information
is welcome to write to us: <[hidden email]>.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Séverine Queune <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Seeking developer

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Séverine Queune <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|Seeking developer           |Sponsored

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]-c
                   |ity.org                     |ommunity.org
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org
             Status|NEW                         |ASSIGNED

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Séverine Queune <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #1 from Jonathan Druart <[hidden email]> ---
Created attachment 68226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68226&action=edit
Bug 19287: Just a bit of cleanup

Let's add a "op" variable to know what the script is supposed to do and
make it less obscure.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #2 from Jonathan Druart <[hidden email]> ---
Created attachment 68227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68227&action=edit
Bug 19287: Add new pref CanMarkHoldsAwaitingPickupAsLost

This patch adds a new pref to control the behaviour of this patch set.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #3 from Jonathan Druart <[hidden email]> ---
Created attachment 68228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68228&action=edit
Bug 19287: Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

This is the main patch of this new enhancement.
The goal to this enhancement is to add the ability to mark items as lost
from the ‘Holds awaiting pickup’ page.
A new pref is added to control the behaviour, default is off
To enable it, you need to set the new pref CanMarkHoldsAwaitingPickupAsLost to
one of these two values:
- "Allow to mark items as lost"
=> The item will be marked as lost and the hold will be cancelled
- "Allow to mark items as lost and notify the patron"
=> Same as previously but the patron will be notified as well.

The notification is done using a new notice template
(code=CANCEL_HOLD_ON_LOST).
Feel free to suggest another default wording.

Test plan:
You need to clearly know how this page is working currently to make sure
this patch does not break existing behaviours
1/ Check 2 items out
2/ Add a hold on one of the items
3/ Add 2 holds on the other item
4/ Return the item to mark the hold as waiting
5/ From here you will be able to see entries in the "Circulation › Holds
awaiting pickup" page
6/ I suggest to make a backup of this table, to avoid to repeat the
previous steps. You will need to test the following steps using the
different values of the pref
7/ Cancel the hold
8/ Mark the items as lost
=> You will receive feedback messages depending on different situations:
* The CANCEL_HOLD_ON_LOST does not exist
* The patron does not have an email address (but the notice has been
enqueued! It is the current behaviour with other notices)
* The notice has been enqueued
* The hold has been cancelled

QA Notes:
1/ C4::Circulation::LostItem is usually called with the second parameter
set, which will mark the issue as returned. It is weird that this
behaviour cannot be controlled by a pref.
2/ From which library do we want to pick the notice? This patch use
reserves.branchcode

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #4 from Jonathan Druart <[hidden email]> ---
Created attachment 68229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68229&action=edit
Bug 19287: Refactor the template to avoid c/p code

The two tabs were using the same code.
The only change I found is the subject of the mailto link, I am not sure
it is relevant to have two different subjects (?)
There was also a phone number info displayed on only one table.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #5 from Jonathan Druart <[hidden email]> ---
Created attachment 68230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68230&action=edit
Bug 19287: Add some feedback messages to the librarian

Be kind with librarians and give them feedback messages.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #6 from Jonathan Druart <[hidden email]> ---
(In reply to Jonathan Druart from comment #3)
> Created attachment 68228 [details] [review]
> QA Notes:
> 1/ C4::Circulation::LostItem is usually called with the second parameter
> set, which will mark the issue as returned. It is weird that this
> behaviour cannot be controlled by a pref.

This patch set may need to be rebased on top of bug 12363, to make this
behaviour  configurable.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12363

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Séverine Queune <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #7 from Séverine Queune <[hidden email]> ---
I tried several times to apply this patch but it never worked.
I first thought it could come from the sandbox but no problem to apply and test
bug 12363.
Sorry :/

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68226|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68227|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68228|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68229|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68230|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add ability to mark an item |Add ability to mark an item
                   |‘Lost’ from ‘Holds awaiting |'Lost' from 'Holds awaiting
                   |pickup’ list                |pickup' list

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #8 from Jonathan Druart <[hidden email]> ---
Created attachment 68251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68251&action=edit
Bug 19287: Just a bit of cleanup

Let's add a "op" variable to know what the script is supposed to do and
make it less obscure.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #9 from Jonathan Druart <[hidden email]> ---
Created attachment 68252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68252&action=edit
Bug 19287: Add new pref CanMarkHoldsAwaitingPickupAsLost

This patch adds a new pref to control the behaviour of this patch set.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #10 from Jonathan Druart <[hidden email]> ---
Created attachment 68253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68253&action=edit
Bug 19287: Add ability to mark an item "Lost" from "Holds awaiting pickup" list

This is the main patch of this new enhancement.
The goal to this enhancement is to add the ability to mark items as lost
from the "Holds awaiting pickup" page.
A new pref is added to control the behaviour, default is off
To enable it, you need to set the new pref CanMarkHoldsAwaitingPickupAsLost to
one of these two values:
- "Allow to mark items as lost"
=> The item will be marked as lost and the hold will be cancelled
- "Allow to mark items as lost and notify the patron"
=> Same as previously but the patron will be notified as well.

The notification is done using a new notice template
(code=CANCEL_HOLD_ON_LOST).
Feel free to suggest another default wording.

Test plan:
You need to clearly know how this page is working currently to make sure
this patch does not break existing behaviours
1/ Check 2 items out
2/ Add a hold on one of the items
3/ Add 2 holds on the other item
4/ Return the item to mark the hold as waiting
5/ From here you will be able to see entries in the "Circulation > Holds
awaiting pickup" page
6/ I suggest to make a backup of this table, to avoid to repeat the
previous steps. You will need to test the following steps using the
different values of the pref
7/ Cancel the hold
8/ Mark the items as lost
=> You will receive feedback messages depending on different situations:
* The CANCEL_HOLD_ON_LOST does not exist
* The patron does not have an email address (but the notice has been
enqueued! It is the current behaviour with other notices)
* The notice has been enqueued
* The hold has been cancelled

QA Notes:
1/ C4::Circulation::LostItem is usually called with the second parameter
set, which will mark the issue as returned. It is weird that this
behaviour cannot be controlled by a pref.
2/ From which library do we want to pick the notice? This patch use
reserves.branchcode

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #11 from Jonathan Druart <[hidden email]> ---
Created attachment 68254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68254&action=edit
Bug 19287: Refactor the template to avoid c/p code

The two tabs were using the same code.
The only change I found is the subject of the mailto link, I am not sure
it is relevant to have two different subjects (?)
There was also a phone number info displayed on only one table.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #12 from Jonathan Druart <[hidden email]> ---
Created attachment 68255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68255&action=edit
Bug 19287: Add some feedback messages to the librarian

Be kind with librarians and give them feedback messages.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #13 from Jonathan Druart <[hidden email]> ---
(In reply to Séverine Queune from comment #7)
> I tried several times to apply this patch but it never worked.
> I first thought it could come from the sandbox but no problem to apply and
> test bug 12363.
> Sorry :/

For the record: "git bz" complained with
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position
56: ordinal not in range(128)

Because of the report title, it contained "U+2018: LEFT SINGLE QUOTATION MARK"

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #14 from Séverine Queune <[hidden email]> ---
Thanks Jonathan for the very quick rebase !

About the tests (only on the 'Holds waiting' tab) :

There is no button displayed on the (circ/waitingreserves.pl) page when the
syspref is set to "Allow to mark item as lost".

Using "Allow to mark item as lost and notify patron", behaviours depending on
the different parameters (notice existing or not, email stored or not) are as
detailed on point 8 of the plan test.
Items are still available after cancelling order.
Is there a syspref you are working on to define which authorized value we want
to set to items.itemlost or items.notforloan ?

I set the syspref "ReservesMaxPickUpDelay" to "1 day" and keep several items
available on the hold list.
I hope I could test tomorrow the behaviour on the "Holds waiting over x days"
tab and change the status of the ticket.

Just a question : is it normal that when I created the notice
CANCEL_HOLD_ON_LOST (this code is ok for me), I choose the 'Holds' Koha module,
and after saving it, the display is 'Reserves' module ?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #15 from Jonathan Druart <[hidden email]> ---
Created attachment 68284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68284&action=edit
Bug 19287: Do not use 'yes' and 'no' for choices

If the pref value is 'yes' or 'no', it will actually be '1' or '0' in
DB, and the comparaison will then fail.
To avoid that I think it is better to rename the value.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #16 from Jonathan Druart <[hidden email]> ---
(In reply to Séverine Queune from comment #14)
> Thanks Jonathan for the very quick rebase !
>
> About the tests (only on the 'Holds waiting' tab) :
>
> There is no button displayed on the (circ/waitingreserves.pl) page when the
> syspref is set to "Allow to mark item as lost".

Indeed, I picked 'yes' and 'no' as syspref value, it was not a good idea.
That should be fixed with the last patch.

> Using "Allow to mark item as lost and notify patron", behaviours depending
> on the different parameters (notice existing or not, email stored or not)
> are as detailed on point 8 of the plan test.
> Items are still available after cancelling order.

Which means it is working as expected so far, right? :)

> Is there a syspref you are working on to define which authorized value we
> want to set to items.itemlost or items.notforloan ?

I think there is a patch somewhere, maybe lost in the bug tracker to allow
that, but I am not sure.
I'd say it should be discussed and fixed on a separate bug report as it will
impact other areas.

> I set the syspref "ReservesMaxPickUpDelay" to "1 day" and keep several items
> available on the hold list.
> I hope I could test tomorrow the behaviour on the "Holds waiting over x
> days" tab and change the status of the ticket.
>
> Just a question : is it normal that when I created the notice
> CANCEL_HOLD_ON_LOST (this code is ok for me), I choose the 'Holds' Koha
> module, and after saving it, the display is 'Reserves' module ?

You are right, there is a small ergonomic issue. Actually "reserve" is the code
for notices of the hold module. You can open a new bug report for that :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12