[Bug 19166] New: Add the ability to add adjustments to an invoice

classic Classic list List threaded Threaded
156 messages Options
123456
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Caroline Cyr La Rose <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |caroline.cyr-la-rose@inlibr
                   |                            |o.com

--- Comment #16 from Caroline Cyr La Rose <[hidden email]> ---
I want this so much to work! I've been asked for this many many times!

But I got a software error.

BIx::Class::Storage::DBI::_dbh_execute(): Table
'koha_master_dev_inlibro.invoice_adjustments' doesn't exist at
/inlibro/git/koha-master-dev-inlibro/Koha/Object.pm line 121

Plus the prove -v ... returned red.

DBD::mysql::st execute failed: Table
'koha_master_dev_inlibro.invoice_adjustments' doesn't exist [for Statement
"SELECT `me`.`adjustment_id`, `me`.`invoiceid`, `me`.`adjustment`,
`me`.`reason`, `me`.`note`, `me`.`budget_id`, `me`.`encumber_open`,
`me`.`timestamp` FROM `invoice_adjustments` `me`  JOIN `aqinvoices` `invoiceid`
ON `invoiceid`.`invoiceid` = `me`.`invoiceid` WHERE ( ( `budget_id` = ? AND
`closedate` IS NOT NULL ) )" with ParamValues: 0='6'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1765.
DBIx::Class::Storage::DBI::_dbh_execute(): Table
'koha_master_dev_inlibro.invoice_adjustments' doesn't exist at
/inlibro/git/koha-master-dev-inlibro/Koha/Objects.pm line 209
# Looks like your test exited with 255 just after 60.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 85/145 subtests

Test Summary Report
-------------------
t/db_dependent/Budgets.t (Wstat: 65280 Tests: 60 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 145 tests but ran 60.
Files=1, Tests=60,  1 wallclock secs ( 0.02 usr  0.00 sys +  1.49 cusr  0.08
csys =  1.59 CPU)
Result: FAIL

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #17 from Nick Clemens <[hidden email]> ---
(In reply to Caroline Cyr La Rose from comment #16)
> I want this so much to work! I've been asked for this many many times!
>
> But I got a software error.
>
> BIx::Class::Storage::DBI::_dbh_execute(): Table
> 'koha_master_dev_inlibro.invoice_adjustments' doesn't exist at
> /inlibro/git/koha-master-dev-inlibro/Koha/Object.pm line 121
>
> Plus the prove -v ... returned red.

HI Caroline, Did you run the database updates? It looks like the tables
introduced in this patchset have not been created.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Koha Team Lyon 3 <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Jon Knight <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #18 from Jon Knight <[hidden email]> ---
I have applied the database changes on my kohadevbox and I get this from `prove
-v t/db_dependent/Budgets.t` (first 128 tests of the 145 are OK, so looks like
test 129 is blowing up, so I won't include all the output for brevity here):

ok 127 - MoveOrders updated the budget amount with the previous unspent budget
(for budget budget_2)
ok 128 - MoveOrders updated the budget amount with the previous unspent budget
(for budget budget_21)
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT
`account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types`
(`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO
`account_offsets` ( `amount`, `debit_id`, `type`) VALUES ( ?, ?, ? )" with
ParamValues: 0=173079442325239000000.000000, 1='1', 2='Manual Debit'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832.
DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a
foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT
`account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types`
(`type`) ON DELETE CASCADE ON UPDATE CASCADE) at
/home/vagrant/kohaclone/Koha/Object.pm line 122
# Looks like your test exited with 255 just after 128.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 17/145 subtests

Test Summary Report
-------------------
t/db_dependent/Budgets.t (Wstat: 65280 Tests: 128 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 145 tests but ran 128.
Files=1, Tests=128,  5 wallclock secs ( 0.04 usr  0.02 sys +  3.98 cusr  0.44
csys =  4.48 CPU)
Result: FAIL

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67599|0                           |1
        is obsolete|                            |
  Attachment #67600|0                           |1
        is obsolete|                            |
  Attachment #67602|0                           |1
        is obsolete|                            |
  Attachment #67890|0                           |1
        is obsolete|                            |

--- Comment #19 from Nick Clemens <[hidden email]> ---
Created attachment 70413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70413&action=edit
Bug 19166 - Database changes

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #20 from Nick Clemens <[hidden email]> ---
Created attachment 70414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70414&action=edit
Bug 19166 - Add the ability to add adjustments to an invoice

This patchset adds the ability to add adjustments to an invoice, one can
provide a reason, an adjustment amount, select a budget, and choose
whether to encumber the funds before the invoice is closed or not

To test:

1 - Create a new invoice with or without a shipping cost
2 - Note there are no existing adjustments
3 - Add an adjustment
4 - Submit the form withno changes, nothing happens
5 - Update the adjustment you created, ensure changes are saved but no
extra adjustment created
6 - Add another invoice prodiving only reason or amount (you can have 0
        value adjustments)
7 - Verify the adjustment total at bottom is correct
8 - Recieve some orders
9 - Verify totals are correct

Conflicts:
        C4/Budgets.pm

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #21 from Nick Clemens <[hidden email]> ---
Created attachment 70415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70415&action=edit
Bug 19166: DO NOT PUSH - Schema updates

Included to ease testing :-)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #22 from Nick Clemens <[hidden email]> ---
Created attachment 70416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70416&action=edit
Bug 19166 - Unit tests for GetBudgetSpent and GetBudget ordered

To test:
1. prove -v t/db_dependent/Budgets.t
2. Should return green

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |[hidden email]
                   |                            |m

--- Comment #23 from Victor Grousset/tuxayo <[hidden email]> ---
conflicts


~/d/koha ❯❯❯ git bz apply 19166
Bug 19166 - Add the ability to add adjustments to an invoice

70413 - Bug 19166 - Database changes
70414 - Bug 19166 - Add the ability to add adjustments to an invoice
70415 - Bug 19166: DO NOT PUSH - Schema updates
70416 - Bug 19166 - Unit tests for GetBudgetSpent and GetBudget ordered

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19166 - Database changes
Using index info to reconstruct a base tree...
M       installer/data/mysql/kohastructure.sql
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/kohastructure.sql
Applying: Bug 19166 - Add the ability to add adjustments to an invoice
Using index info to reconstruct a base tree...
M       acqui/invoice.pl
M       acqui/ordered.pl
M       acqui/spent.pl
M       koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
M       koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt
M       koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
Auto-merging acqui/spent.pl
Auto-merging acqui/ordered.pl
Auto-merging acqui/invoice.pl
Applying: Bug 19166: DO NOT PUSH - Schema updates
Using index info to reconstruct a base tree...
M       Koha/Schema/Result/Aqbudget.pm
M       Koha/Schema/Result/Aqinvoice.pm
Falling back to patching base and 3-way merge...
Auto-merging Koha/Schema/Result/Aqinvoice.pm
CONFLICT (content): Merge conflict in Koha/Schema/Result/Aqinvoice.pm
Auto-merging Koha/Schema/Result/Aqbudget.pm
CONFLICT (content): Merge conflict in Koha/Schema/Result/Aqbudget.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 19166: DO NOT PUSH - Schema updates
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-19166-DO-NOT-PUSH---Schema-updates-Wq9yGZ.patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70413|0                           |1
        is obsolete|                            |

--- Comment #24 from Nick Clemens <[hidden email]> ---
Created attachment 72702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72702&action=edit
Bug 19166 - Database changes

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70414|0                           |1
        is obsolete|                            |

--- Comment #25 from Nick Clemens <[hidden email]> ---
Created attachment 72703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72703&action=edit
Bug 19166 - Add the ability to add adjustments to an invoice

This patchset adds the ability to add adjustments to an invoice, one can
provide a reason, an adjustment amount, select a budget, and choose
whether to encumber the funds before the invoice is closed or not

To test:

1 - Create a new invoice with or without a shipping cost
2 - Note there are no existing adjustments
3 - Add an adjustment
4 - Submit the form withno changes, nothing happens
5 - Update the adjustment you created, ensure changes are saved but no
extra adjustment created
6 - Add another invoice prodiving only reason or amount (you can have 0
        value adjustments)
7 - Verify the adjustment total at bottom is correct
8 - Recieve some orders
9 - Verify totals are correct

Conflicts:
        C4/Budgets.pm

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70415|0                           |1
        is obsolete|                            |

--- Comment #26 from Nick Clemens <[hidden email]> ---
Created attachment 72704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72704&action=edit
Bug 19166: DO NOT PUSH - Schema updates

Included to ease testing :-)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70416|0                           |1
        is obsolete|                            |

--- Comment #27 from Nick Clemens <[hidden email]> ---
Created attachment 72705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72705&action=edit
Bug 19166 - Unit tests for GetBudgetSpent and GetBudget ordered

To test:
1. prove -v t/db_dependent/Budgets.t
2. Should return green

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Koha Team Lyon 3 <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #28 from Koha Team Lyon 3 <[hidden email]> ---
I have very strange results on the acqui-home table.

I put a order with 2 titles of each 20€ tax excluded with 1.10 GST

I received my first title with a shipment cost of 15€ and add a negative
adjustement (-10) on this one.
When I added the adjustment, I didn't check "Encumber while invoice open" but
it was checked when I save it.
Adjustements are added to ordered orders but the sums in acqui-home page are
wrong.

Ordered : 26,10
Title 2 = 21,10 €
Adjustement = -10

-> should be 11,10 €

Spent : 36,10
Title 1 = 21,10
Shipment cost = 15

->ok

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #29 from Nick Clemens <[hidden email]> ---
Created attachment 72744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72744&action=edit
Bug 19116: Get correct value for encumbering when open for new lines

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #30 from Nick Clemens <[hidden email]> ---
Created attachment 72978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72978&action=edit
Bug 19166: (follow-up) Shipment cost is always added to 'spent'

Two koha professionals agreed, also it is current behvaiour so this
patch removes a change

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Victor Grousset/tuxayo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[hidden email] |
                   |m                           |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #31 from Caroline Cyr La Rose <[hidden email]> ---
What is the authorized value category for the "reason" column?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72702|0                           |1
        is obsolete|                            |
  Attachment #72703|0                           |1
        is obsolete|                            |
  Attachment #72704|0                           |1
        is obsolete|                            |
  Attachment #72705|0                           |1
        is obsolete|                            |
  Attachment #72744|0                           |1
        is obsolete|                            |
  Attachment #72978|0                           |1
        is obsolete|                            |

--- Comment #32 from Nick Clemens <[hidden email]> ---
Created attachment 73481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73481&action=edit
Bug 19166: Database changes

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #33 from Nick Clemens <[hidden email]> ---
Created attachment 73482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73482&action=edit
Bug 19166: Add the ability to add adjustments to an invoice

This patchset adds the ability to add adjustments to an invoice, one can
provide a reason, an adjustment amount, select a budget, and choose
whether to encumber the funds before the invoice is closed or not

To test:

1 - Create a new invoice with or without a shipping cost
2 - Note there are no existing adjustments
3 - Add an adjustment
4 - Submit the form withno changes, nothing happens
5 - Update the adjustment you created, ensure changes are saved but no
extra adjustment created
6 - Add another invoice prodiving only reason or amount (you can have 0
        value adjustments)
7 - Verify the adjustment total at bottom is correct
8 - Recieve some orders
9 - Verify totals are correct

Conflicts:
        C4/Budgets.pm

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #34 from Nick Clemens <[hidden email]> ---
Created attachment 73483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73483&action=edit
Bug 19166: DO NOT PUSH - Schema updates

Included to ease testing :-)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #35 from Nick Clemens <[hidden email]> ---
Created attachment 73484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73484&action=edit
Bug 19166: Unit tests for GetBudgetSpent and GetBudget ordered

To test:
1. prove -v t/db_dependent/Budgets.t
2. Should return green

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #36 from Nick Clemens <[hidden email]> ---
Created attachment 73485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73485&action=edit
Bug 19166: Get correct value for encumbering when open for new lines

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #37 from Nick Clemens <[hidden email]> ---
Created attachment 73486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73486&action=edit
Bug 19166: (follow-up) Shipment cost is always added to 'spent'

Two koha professionals agreed, also it is current behvaiour so this
patch removes a change

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #38 from Nick Clemens <[hidden email]> ---
Created attachment 73487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73487&action=edit
Bug 19166: (follow-up) Add ADJ_REASON auhtorised value category and minor fixes

This patch adds the ADJ_REASON authorised value category tot he atomic
update, and fixes code to display a hint of no reasons are defined

other minor updates to remove warns in logs

To test:
Apply patches
Run updates
Check authorised value categories to see ADJ_REASON exists
Add an adjustment, not you have no reaosn drop down
Note there is a hint if you hover
Add a value to ADJ_REASON
add another adjustment, note you can now add reasons (or not)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

--- Comment #39 from Nick Clemens <[hidden email]> ---
(In reply to Caroline Cyr La Rose from comment #31)
> What is the authorized value category for the "reason" column?

It is ADJ_REASON - I now add this in the updates and fixed the hint that
displays so the user knows where to add reasons

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

[hidden email] <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Signed Off

--- Comment #40 from [hidden email] <[hidden email]> ---
Patch tested with a sandbox, by Séverine QUEUNE <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19166] Add the ability to add adjustments to an invoice

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

[hidden email] <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73481|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
123456