[Bug 19017] New: Script that checks and transforms SMS alert numbers

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] New: Script that checks and transforms SMS alert numbers

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

            Bug ID: 19017
           Summary: Script that checks and transforms SMS alert numbers
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Here is a proposal for a script that would check SMS alert number field. Our
need is to have number that are correctly formatted as expetced by the SMS
provider
(ie: 0033678240967 or +33678240967 and not 0678240967).

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

--- Comment #1 from Alex Arnaud <[hidden email]> ---
Created attachment 65396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65396&action=edit
Checks and transform SMS alert number

This patch adds a new package C4::SMSNumber::Fr (new ones could be added
for other countries)
and a scrip (misc/check_smsalertnumber.pl):
  check_smsalertnumber.pl -a|--area fr [-h|--help] [-c|--confirm]
[-o|--country-option] [-l|--liste-mode]

Test plan #1:
  - Create or modify patrons and add some SMS alert numbers like:
     06 98 35 72 28, 0656871221, +336-01-55-83-11, 0033 6.23.54.54.00,
0126698376
  - launch perl misc/check_smsalertnumber.pl -a Fr
  - Transformation proposal should be like:
    - 06 98 35 72 28 => 0698357228,
    - 0656871221 => no proposal (number Ok),
    - +336-01-55-83-11 => 0601558311,
    - 0033 6.23.54.54.00 => 0623545400,
    - 0126698376 => Can't find a replacement

Test plan #2:
  - with the same numbers launch perl misc/check_smsalertnumber.pl -a Fr
    -o +33
  - Transformation proposal should be like:
    - 06 98 35 72 28 => +33698357228,
    - 0656871221 => +33656871221,
    - +336-01-55-83-11 => +33601558311,
    - 0033 6.23.54.54.00 => +33623545400,
    - 0126698376 => Can't find a replacement

Test plan #3:
  - with the same numbers launch perl misc/check_smsalertnumber.pl -a Fr
    -o 0033
  - Transformation proposal should be like:
    - 06 98 35 72 28 => 0033698357228,
    - 0656871221 => 0033656871221,
    - +336-01-55-83-11 => 0033601558311,
    - 0033 6.23.54.54.00 => 0033623545400,
    - 0126698376 => Can't find a replacement

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard <[hidden email]> ---
This works as it should, but I get a couple of errors from the qa script.

 OK     C4/SMSNumber/Fr.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     spelling
   OK     valid

 FAIL   misc/check_smsalertnumber.pl
   FAIL   critic
                Stricture disabled at line 60, column 5. See page 429 of PBP.
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   spelling
                 tranform  ==> transform
   OK     valid

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65396|0                           |1
        is obsolete|                            |

--- Comment #3 from Alex Arnaud <[hidden email]> ---
Created attachment 65498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65498&action=edit
Checks and transform SMS alert number

This patch adds a new package C4::SMSNumber::Fr (new ones could be added
for other countries)
and a scrip (misc/check_smsalertnumber.pl):
  check_smsalertnumber.pl -a|--area fr [-h|--help] [-c|--confirm]
[-o|--country-option] [-l|--liste-mode]

Test plan #1:
  - Create or modify patrons and add some SMS alert numbers like:
     06 98 35 72 28, 0656871221, +336-01-55-83-11, 0033 6.23.54.54.00,
0126698376
  - launch perl misc/check_smsalertnumber.pl -a Fr
  - Transformation proposal should be like:
    - 06 98 35 72 28 => 0698357228,
    - 0656871221 => no proposal (number Ok),
    - +336-01-55-83-11 => 0601558311,
    - 0033 6.23.54.54.00 => 0623545400,
    - 0126698376 => Can't find a replacement

Test plan #2:
  - with the same numbers launch perl misc/check_smsalertnumber.pl -a Fr
    -o +33
  - Transformation proposal should be like:
    - 06 98 35 72 28 => +33698357228,
    - 0656871221 => +33656871221,
    - +336-01-55-83-11 => +33601558311,
    - 0033 6.23.54.54.00 => +33623545400,
    - 0126698376 => Can't find a replacement

Test plan #3:
  - with the same numbers launch perl misc/check_smsalertnumber.pl -a Fr
    -o 0033
  - Transformation proposal should be like:
    - 06 98 35 72 28 => 0033698357228,
    - 0656871221 => 0033656871221,
    - +336-01-55-83-11 => 0033601558311,
    - 0033 6.23.54.54.00 => 0033623545400,
    - 0126698376 => Can't find a replacement

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

--- Comment #4 from Owen Leonard <[hidden email]> ---
This isn't correct is it?

------------

perl check_smsalertnumber.pl -a Fr

Number:  0033 6.23.54.54.00 at /home/vagrant/kohaclone/C4/SMSNumber/Fr.pm line
24.
Patron n° 58808 has an invalid phone number for area Fr ( 0033 6.23.54.54.00).
Can't find a replacement

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Simon Pouchol <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65498|0                           |1
        is obsolete|                            |

--- Comment #5 from Simon Pouchol <[hidden email]> ---
Created attachment 68319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68319&action=edit
Checks and transform SMS alert number

This patch adds a new package C4::SMSNumber::Fr (new ones could be added
for other countries)
and a scrip (misc/check_smsalertnumber.pl):
  check_smsalertnumber.pl -a|--area fr [-h|--help] [-c|--confirm]
[-o|--country-option] [-l|--liste-mode]

Test plan #1:
  - Create or modify patrons and add some SMS alert numbers like:
     06 98 35 72 28, 0656871221, +336-01-55-83-11, 0033 6.23.54.54.00,
0126698376
  - launch perl misc/check_smsalertnumber.pl -a Fr
  - Transformation proposal should be like:
    - 06 98 35 72 28 => 0698357228,
    - 0656871221 => no proposal (number Ok),
    - +336-01-55-83-11 => 0601558311,
    - 0033 6.23.54.54.00 => 0623545400,
    - 0126698376 => Can't find a replacement

Test plan #2:
  - with the same numbers launch perl misc/check_smsalertnumber.pl -a Fr
    -o +33
  - Transformation proposal should be like:
    - 06 98 35 72 28 => +33698357228,
    - 0656871221 => +33656871221,
    - +336-01-55-83-11 => +33601558311,
    - 0033 6.23.54.54.00 => +33623545400,
    - 0126698376 => Can't find a replacement

Test plan #3:
  - with the same numbers launch perl misc/check_smsalertnumber.pl -a Fr
    -o 0033
  - Transformation proposal should be like:
    - 06 98 35 72 28 => 0033698357228,
    - 0656871221 => 0033656871221,
    - +336-01-55-83-11 => 0033601558311,
    - 0033 6.23.54.54.00 => 0033623545400,
    - 0126698376 => Can't find a replacement

https://bugs.koha-community.org/show_bug.cgi?id=19017
Signed-off-by: Simon Pouchol <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Simon Pouchol <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <[hidden email]> ---
This is too specific, we should provide a generic way to do that.
The prefix code should be a parameter of the script.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           Keywords|                            |dependency

--- Comment #7 from Katrin Fischer <[hidden email]> ---
Should we set this to In discussion or failed?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

--- Comment #8 from Jonathan Druart <[hidden email]> ---
I did not switch the status to get another QA point of view.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19017] Script that checks and transforms SMS alert numbers

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

--- Comment #9 from Alex Arnaud <[hidden email]> ---
(In reply to Jonathan Druart from comment #6)
> This is too specific, we should provide a generic way to do that.
> The prefix code should be a parameter of the script.

Prefix code is passed to the script with -o|--options. It is intentionally
generic in the case an other country package needs a different parameter.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/