[Bug 19014] New: Limit auto-renewal notice to item due immediately. Template Toolkit change ?

classic Classic list List threaded Threaded
36 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] New: Limit auto-renewal notice to item due immediately. Template Toolkit change ?

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

            Bug ID: 19014
           Summary: Limit auto-renewal notice to item due immediately.
                    Template Toolkit change?
 Change sponsored?: ---
           Product: Koha
           Version: 17.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Current functionality in 17.05:
All copies of an item with auto-renewal enabled, reserved at the title level.
Due dates of copies on loan include today, and various dates into the future,
some many weeks ahead.
When the auto-renewal job runs,  Koha is sending an AUTO_RENEWAL email to ALL
the users warning them ALL of renewal failure, using the [% ELSIF
checkout.auto_renew_error == 'on_reserve' %]

Desired functionality in 17.05:
When the auto-renewal job runs,  Koha should only send an AUTO_RENEWAL email to
the user (or possibly users) whose copy is due back today, on the day the
auto-renewal job runs. Other people who have copies on loan but which are not
yet due back yet should not be contacted by the AUTO_RENEWAL email. Users
contacted in this way are being very puzzled and confused.

Could this be achieved by an edit to the condition in the template toolkit? So
rather this:
[% ELSIF checkout.auto_renew_error == 'on_reserve' %]
This item has been reserved by another reader.
… we have something like this:
[% ELSIF checkout.auto_renew_error == 'on_reserve'  && checkout.date_due
%==today %]
This item has been reserved by another reader.

Would that work? Is a second condition permissible? How should it be worded?

Ray Delahunty
University of the Arts London

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Limit auto-renewal notice   |Patrons should not get a
                   |to item due immediately.    |on_reserve notification if
                   |Template Toolkit change?    |the checkout is due in the
                   |                            |future
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #1 from Jonathan Druart <[hidden email]> ---
Created attachment 65590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65590&action=edit
Bug 19014: Do not sent on_reserve notification if the checkout is due in the
future

If holds exist on an item that have been checked out and marked as auto
renewal, we do not want to notify patrons with a on_reserve notification
if the checkout is due in the future.
These on_reserve notifications must only be sent if the checkout is due
today or in the past.

Test plan:
- Check an item in and mark it as auto renewal, use a due date in the
past to ease the testing
- Place a hold in this item
- Execute the cronjob
=> Without this patch, the patron will get notified even if the checkout
is due in the future
=> With this patch applied the patron will only get notified the day the
checkout is due or if the due date is passed

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
           Assignee|[hidden email]-commun |[hidden email]-c
                   |ity.org                     |ommunity.org
            Version|17.05                       |master

--- Comment #2 from Jonathan Druart <[hidden email]> ---
Hi Ray,
What you describe sounds like a bug. Could you take a look at this patch and
tell me if it could meet your needs?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19053

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #3 from Ray Delahunty <[hidden email]> ---
Yes, I think that is a perfect plan. My suggestion about the edit to the
template toolkit was just a suggestion. We have a workaround in place in 16.05
(which has the same problem) and will have to retain it when we upgrade to
17.05 in a week or so. We have repurposed ODUE to be the renewal failed
advisory, and use RENEWAL as the renewal success advisory, and have turned off
the AUTO_RENEWAL notice. That works OK, but we do hope to see the functionality
working as you describe so we can restart using AUTO_RENEWAL. We are also
funding the change of that email into a digest one, to further improve the
auto-renewal functionality.

Ray Delahunty
University of the Arts London

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15705


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705
[Bug 15705] Notify the user on auto renewing
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Field <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.field@ptfs-europe.
                   |                            |com

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Katrin Fischer <[hidden email]> ---
It seems a bit harsh to send the notice the day the item is due, as this means
the patron will only have 'that day' to return the book safely.

But as the automatic renewal will be tried daily depending on 'No renewal
before' and (I tihnk) 'No automatic renewal after' I am not sure how to avoid
spamming the patrons with lots of emails. I guess ideally one email would be
sent the first time the renewal fails?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Janet McGowan <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |om

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Caroline Cyr La Rose <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose@inlibr
                   |                            |o.com
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Caroline Cyr La Rose <[hidden email]> ---
Hi Jonathan,

I'm having trouble testing this. Which cron job are we supposed to run? Is it
automatic_renewals.pl --send-notices?

Furthermore, I had an item due in the future (in december) and I still received
a notice saying the auto renewal failed because I had fines (which was true).
But why would it try to renew something due in december?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #6 from Jonathan Druart <[hidden email]> ---
(In reply to Caroline Cyr La Rose from comment #5)
> Hi Jonathan,
>
> I'm having trouble testing this. Which cron job are we supposed to run? Is
> it automatic_renewals.pl --send-notices?

Yes

> Furthermore, I had an item due in the future (in december) and I still
> received a notice saying the auto renewal failed because I had fines (which
> was true). But why would it try to renew something due in december?

You need to tune that using the 'No automatic renewal before/after' settings.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20360

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Nick Clemens <[hidden email]> ---
We have several libraries with different opinions on this:
Some want the emails to be sent the day the item becomes non-renewable
Some want the notices sent on the day the item would be renewed

This patch seems to send the notice on the due date of the item

Could this be done as a switch in the cronjob? (or a syspref?)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #8 from Jonathan Druart <[hidden email]> ---
(In reply to Nick Clemens from comment #7)
> We have several libraries with different opinions on this:
> Some want the emails to be sent the day the item becomes non-renewable
> Some want the notices sent on the day the item would be renewed
>
> This patch seems to send the notice on the due date of the item
>
> Could this be done as a switch in the cronjob? (or a syspref?)

I think what you describe can be considered as a new enh, whereas this patch
fixes a much bigger issue.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #9 from Katrin Fischer <[hidden email]> ---
I am not sure all libraries can generally agree to send the notice on date due,
because then the user has no way to return the item on time usually.

I think there are separate issues thinking about the notice:

- Don't send a notice every day the item is not returned, sent a notice once or
at least not too often
- Be able to inform the patrons on time before the due date so they are able to
return the item on time
- Don't inform the user weeks ahead

Could it help to set the "No renewal before" to a lower number of days? This
would prevent auto renewals from happening and together with "No automatic
renewal after" could limit the timeframe for sending the notice to a few days.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_18_05_candidate

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Niamh <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |niamh.walker-headon@it-tall
                   |                            |aght.ie

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Ray Delahunty <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Patrons should not get a    |Patrons should not get a
                   |on_reserve notification if  |on_reserve notification if
                   |the checkout is due in the  |the due date is far into
                   |future                      |the future

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #10 from Ray Delahunty <[hidden email]> ---
We have a test system at 17.11.04 and are investigating whether this problem /
dilemma can be solved with the code, which I understand will solve the problem
in this bug and the one in 20360 (and which is a candidate for 18.05) can
possibly be added to our 17.11 version.
We have a workaround where we disabled AUTO_RENEWALS notices and use ODUE to
notify of auto-renewal failure, and RENEWALS to notify of auto-renewal success.
We are today undoing this workaround and if the code can work in 17.11 we plan
to address Katrin’s concerns expressed above by a mix of changes to ‘No renewal
after’, ‘No renewal before’, choice of time for the auto-renewal job to run,
and generous use of a grace period. These Circulation & Fine Rules changes do
not solve every problem, but if they work, they will offer some improvement. If
the code does not work, I think we may have to reinstate the workaround, and
wait for Koha 18.05.

Test plan.
We set ‘No automatic renewal before’ to 2 days. We set ‘No automatic renewal
after’ to 1 day. We set the time of the auto-renewal job to 7am. We set the
RenewalBasePeriod to “old due date”. We set the Grace Period to 3 days.
Assuming the new code solves both this bug and the one in 20360, this is what
we would expect:

Situation 1.
Item is reserved / on hold and due date on Thursday. Auto-renewal job runs at
7am Wednesday, and AUTO_RENEWAL notice is sent advising of renewal failure.
User has two remaining loan days and the three grace period days before fines
start. If the reservation / hold is cancelled after the job has run or is
fulfilled by another copy after 7am on Wednesday but before 7am Thursday, the
second run of the auto-renewal job will result in the item being renewed, with
the new date based on the old date (so the early renewal does not affect the
loan period).

Situation 2.
Item is not reserved / on hold or otherwise blocked from renewal (say, due to
max renewals count being reached) and it is due on Thursday. Auto-renewal job
runs at 7am Wednesday, and AUTO_RENEWAL notice is sent advising of renewal
success, with the new due date based on the old date. The early renewal does
not badly affect the current holder- other than appearing to be an ‘early
renewal’. But it does mean that if someone else places a reservation / hold on
the title on the Wednesday or Thursday they will have a long wait than if the
renewal were close to the original due date.

We can play about with the settings in Circulation & Fine Rules to get the
“best possible outcome” of minimal affect for maximum users (maybe set the ‘No
Auto renewal before’ back to 3 days?) but whatever we do, it won’t be perfect
as there are potentially problems with whatever settings we choose.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_18_05_candidate         |

--- Comment #11 from Jonathan Druart <[hidden email]> ---
I will not have time to get back to this before the release.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Michal Denar <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #12 from Michal Denar <[hidden email]> ---
Hi,
any progress with this issue?

Thank you.


Mike

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #13 from Jonathan Druart <[hidden email]> ---
(In reply to Michal Denar from comment #12)
> any progress with this issue?

Could you test the patch and give us your feedback?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

David Cook <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #14 from David Cook <[hidden email]> ---
I've run into this same problem, but my thinking was that
C4::Circulation::CanBookBeRenewed() should check for "too_soon" before
"on_reserve".

In fact, shouldn't reserves be the last thing checked when determining whether
or not a book can be renewed?

Here's the scenario I see:

1. Patron A autorenews Book A on Wednesday morning
2. Patron B reserves Book A on Wednesday afternoon
3. Patron A receives autorenewal failure for Book A on Thursday morning

Here's some SQL I've used to find instances of that scenario happening (the
search strings will depend on the content of your notices):

select
m.borrowernumber,
m.message_id, mq.message_id, m.time_queued, mq.time_queued,m.content,
mq.content
from message_queue m
join message_queue mq ON
m.borrowernumber = mq.borrowernumber
AND substring(m.content,locate('The following item',m.content),30) =
substring(mq.content,locate('The following item',mq.content),30)
AND date(date_add(m.time_queued, INTERVAL 1 DAY)) = date(mq.time_queued)
where m.letter_code = 'AUTO_RENEWALS'
and mq.content like '%item is on hold%'
ORDER BY m.borrowernumber

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #15 from David Cook <[hidden email]> ---
I think the proper solution might be to refactor
C4::Circulation::CanBookBeRenewed and then maybe make a separate function
C4::Circulation::CanBookBeAutoRenewed and make that configurable, since it
seems that different libraries have different needs/wants for autorenewal.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #16 from David Cook <[hidden email]> ---
(In reply to David Cook from comment #15)
> I think the proper solution might be to refactor
> C4::Circulation::CanBookBeRenewed and then maybe make a separate function
> C4::Circulation::CanBookBeAutoRenewed and make that configurable, since it
> seems that different libraries have different needs/wants for autorenewal.

That said, I don't have the resources to do this at present.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Holger Meißner <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #17 from Holger Meißner <[hidden email]> ---
(In reply to David Cook from comment #15)
> I think the proper solution might be to refactor
> C4::Circulation::CanBookBeRenewed and then maybe make a separate function
> C4::Circulation::CanBookBeAutoRenewed and make that configurable, since it
> seems that different libraries have different needs/wants for autorenewal.

That's also the first idea I had. Yet, there would be duplicate code and we
shouldn't do that unless we have to.

Second idea: Don't prioritize errors in CanBookBeRenewed.
We already combine different errors in $error, e.g. if both "too_soon" and
"auto_renew" apply, then it's "auto_too_soon". Take this one step further and
return a complete list of basic errors instead. That list could be evaluated as
needed, e.g. the cronjob could decide not to send a notice, because it's too
soon and at the same time opac could decide to display a hold.
I don't know whether the loss in performance would be noticable.

Third idea: Tell CanBookBeRenewed the context we're in.
Give CanBookBeRenewed an additional parameter, so it can return different
errors depending on that parameter, e.g. CanBookBeRenewed(123,123,0,X) where X
might be something like "auto", "staff" or "opac".
Similar to the first idea, but the code stays in one function.

Any other ideas?

Maybe I'll find time to code in 2019, but I can't promise yet.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Daniel Gaghan <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.gaghan@pueblolibrary
                   |                            |.org

--- Comment #18 from Daniel Gaghan <[hidden email]> ---
Having read over the comments here, there's nothing I can add besides saying
that Pueblo City County Library District is hoping for a fix for this in 2019.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12