[Bug 18958] New: If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

classic Classic list List threaded Threaded
37 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] New: If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

            Bug ID: 18958
           Summary: If patron has multiple record level holds on one
                    record transferring first hold causes next hold to
                    become item level
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB
and LibraryC respectively. Now, a patron places to record level holds for
pickup at LibraryD. When any of the items are checked in, that item is trapped
to fill the first hold, but a side affect is that the next open hold because
item level for the item that was just checked in!

This is clearly incorrect and prevents the patron from placing more record
level holds on the record.

To reproduce:
1. Create and use a patron that can place multiple record level holds per
record
2. Create a record with X items, each at a different library
3. Place X 'Next available' holds on the record for the patron using the 'Holds
to place' box
4. Check in LibraryA's copy as LibraryA and confirm the hold
5. Revisit request.pl for the record, notice the next hold in line is now
item-specific
6. Attempt to place another hold for your patron, notice that it requires an
item-specific hold

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

--- Comment #1 from Kyle M Hall <[hidden email]> ---
Created attachment 65104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65104&action=edit
Bug 18958 - If patron has multiple record level holds on one record
transferring first hold causes next hold to become item level

Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB
and LibraryC respectively. Now, a patron places to record level holds for
pickup at LibraryD. When any of the items are checked in, that item is trapped
to fill the first hold, but a side affect is that the next open hold because
item level for the item that was just checked in!

This is clearly incorrect and prevents the patron from placing more record
level holds on the record.

Test Plan:
1. Create and use a patron that can place multiple record level holds per
record
2. Create a record with X items, each at a different library
3. Place X 'Next available' holds on the record for the patron using the 'Holds
to place' box
4. Check in LibraryA's copy as LibraryA and confirm the hold
5. Revisit request.pl for the record, notice the next hold in line is now
item-specific
6. Attempt to place another hold for your patron, notice that it requires an
item-specific hold
7. Apply this patch
8. Repeat steps 1-4
9. Revisit request.pl for the record, notice the next hold in line has *not*
become item-specific

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65104|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

--- Comment #2 from Kyle M Hall <[hidden email]> ---
Created attachment 65150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65150&action=edit
Bug 18958 - If patron has multiple record level holds on one record
transferring first hold causes next hold to become item level

Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB
and LibraryC respectively. Now, a patron places to record level holds for
pickup at LibraryD. When any of the items are checked in, that item is trapped
to fill the first hold, but a side affect is that the next open hold because
item level for the item that was just checked in!

This is clearly incorrect and prevents the patron from placing more record
level holds on the record.

Test Plan:
1. Create and use a patron that can place multiple record level holds per
record
2. Create a record with X items, each at a different library
3. Place X 'Next available' holds on the record for the patron using the 'Holds
to place' box
4. Rebuild the holds queue
5. Check in LibraryA's copy as LibraryA and confirm the hold
6. Revisit request.pl for the record, notice the next hold in line is now
item-specific
7. Attempt to place another hold for your patron, notice that it requires an
item-specific hold
8. Apply this patch
9. Repeat steps 1-4
10. Revisit request.pl for the record, notice the next hold in line has *not*
become item-specific

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65150|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <[hidden email]> ---
Created attachment 65184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65184&action=edit
Bug 18958 - If patron has multiple record level holds on one record
transferring first hold causes next hold to become item level

Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB
and LibraryC respectively. Now, a patron places to record level holds for
pickup at LibraryD. When any of the items are checked in, that item is trapped
to fill the first hold, but a side affect is that the next open hold because
item level for the item that was just checked in!

This is clearly incorrect and prevents the patron from placing more record
level holds on the record.

Test Plan:
1. Create and use a patron that can place multiple record level holds per
record
2. Create a record with X items, each at a different library
3. Place X 'Next available' holds on the record for the patron using the 'Holds
to place' box
4. Rebuild the holds queue
5. Check in LibraryA's copy as LibraryA and confirm the hold
6. Revisit request.pl for the record, notice the next hold in line is now
item-specific
7. Attempt to place another hold for your patron, notice that it requires an
item-specific hold
8. Apply this patch
9. Repeat steps 1-4
10. Revisit request.pl for the record, notice the next hold in line has *not*
become item-specific

Signed-off-by: Kyle M Hall <[hidden email]>

Signed-off-by: Jason Robb <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Signed Off                  |Patch doesn't apply

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65184|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <[hidden email]> ---
Created attachment 71164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71164&action=edit
Bug 18958 - If patron has multiple record level holds on one record
transferring first hold causes next hold to become item level

Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB
and LibraryC respectively. Now, a patron places to record level holds for
pickup at LibraryD. When any of the items are checked in, that item is trapped
to fill the first hold, but a side affect is that the next open hold because
item level for the item that was just checked in!

This is clearly incorrect and prevents the patron from placing more record
level holds on the record.

Test Plan:
1. Create and use a patron that can place multiple record level holds per
record
2. Create a record with X items, each at a different library
3. Place X 'Next available' holds on the record for the patron using the 'Holds
to place' box
4. Rebuild the holds queue
5. Check in LibraryA's copy as LibraryA and confirm the hold
6. Revisit request.pl for the record, notice the next hold in line is now
item-specific
7. Attempt to place another hold for your patron, notice that it requires an
item-specific hold
8. Apply this patch
9. Repeat steps 1-4
10. Revisit request.pl for the record, notice the next hold in line has *not*
become item-specific

Signed-off-by: Kyle M Hall <[hidden email]>

Signed-off-by: Jason Robb <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71164|0                           |1
        is obsolete|                            |

--- Comment #5 from Josef Moravec <[hidden email]> ---
Created attachment 71232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71232&action=edit
Bug 18958 - If patron has multiple record level holds on one record
transferring first hold causes next hold to become item level

Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB
and LibraryC respectively. Now, a patron places to record level holds for
pickup at LibraryD. When any of the items are checked in, that item is trapped
to fill the first hold, but a side affect is that the next open hold because
item level for the item that was just checked in!

This is clearly incorrect and prevents the patron from placing more record
level holds on the record.

Test Plan:
1. Create and use a patron that can place multiple record level holds per
record
2. Create a record with X items, each at a different library
3. Place X 'Next available' holds on the record for the patron using the 'Holds
to place' box
4. Rebuild the holds queue
5. Check in LibraryA's copy as LibraryA and confirm the hold
6. Revisit request.pl for the record, notice the next hold in line is now
item-specific
7. Attempt to place another hold for your patron, notice that it requires an
item-specific hold
8. Apply this patch
9. Repeat steps 1-4
10. Revisit request.pl for the record, notice the next hold in line has *not*
become item-specific

Signed-off-by: Kyle M Hall <[hidden email]>

Signed-off-by: Jason Robb <[hidden email]>

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
         QA Contact|[hidden email]-communit |[hidden email]
                   |y.org                       |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #6 from Jonathan Druart <[hidden email]> ---
Hum, I am going to postpone this change for my mental health (holds...)

But at first glance there is something wrong: the diffbranch flag will never be
set and we will have a lot of useless code in the template.

Are you sure this change is correct?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

George Williams (NEKLS) <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Sally Healey <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey@cheshireshared
                   |                            |services.gov.uk

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

--- Comment #7 from Kyle M Hall <[hidden email]> ---
(In reply to Jonathan Druart from comment #6)
> Hum, I am going to postpone this change for my mental health (holds...)
>
> But at first glance there is something wrong: the diffbranch flag will never
> be set and we will have a lot of useless code in the template.
>
> Are you sure this change is correct?

I'm not sure what you mean. This doesn't change ModItemTransfer at all. It only
replaces a bunch of code with a call to ModItemTransfer *if* the item needs
transferred. This reduces code and complexity, and does not affect any other
use of ModItemTransfer.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

--- Comment #8 from Jonathan Druart <[hidden email]> ---
(In reply to Kyle M Hall from comment #7)

> (In reply to Jonathan Druart from comment #6)
> > Hum, I am going to postpone this change for my mental health (holds...)
> >
> > But at first glance there is something wrong: the diffbranch flag will never
> > be set and we will have a lot of useless code in the template.
> >
> > Are you sure this change is correct?
>
> I'm not sure what you mean. This doesn't change ModItemTransfer at all. It
> only replaces a bunch of code with a call to ModItemTransfer *if* the item
> needs transferred. This reduces code and complexity, and does not affect any
> other use of ModItemTransfer.

I was not talking about ModItemTransfer.

You removed this line:
-            diffbranch     => 1,

diffbranch is only sent to the template once, after your patch it will never be
set.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71232|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <[hidden email]> ---
Created attachment 72210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72210&action=edit
Bug 18958 - If patron has multiple record level holds on one record
transferring first hold causes next hold to become item level

Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB
and LibraryC respectively. Now, a patron places to record level holds for
pickup at LibraryD. When any of the items are checked in, that item is trapped
to fill the first hold, but a side affect is that the next open hold because
item level for the item that was just checked in!

This is clearly incorrect and prevents the patron from placing more record
level holds on the record.

Test Plan:
1. Create and use a patron that can place multiple record level holds per
record
2. Create a record with X items, each at a different library
3. Place X 'Next available' holds on the record for the patron using the 'Holds
to place' box
4. Rebuild the holds queue
5. Check in LibraryA's copy as LibraryA and confirm the hold
6. Revisit request.pl for the record, notice the next hold in line is now
item-specific
7. Attempt to place another hold for your patron, notice that it requires an
item-specific hold
8. Apply this patch
9. Repeat steps 1-4
10. Revisit request.pl for the record, notice the next hold in line has *not*
become item-specific

Signed-off-by: Kyle M Hall <[hidden email]>

Signed-off-by: Jason Robb <[hidden email]>

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

--- Comment #10 from Kyle M Hall <[hidden email]> ---
Created attachment 72211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72211&action=edit
Bug 18958 [QA Followup] - Bring back data needed for the diffbranch block of
the template

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

--- Comment #11 from Marcel de Rooy <[hidden email]> ---
QA: Looking here

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #12 from Marcel de Rooy <[hidden email]> ---
Still working on it. Suspect that we are not ready yet.. Moving to BLOCKED
temporarily

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72210|0                           |1
        is obsolete|                            |
  Attachment #72211|0                           |1
        is obsolete|                            |

--- Comment #13 from Marcel de Rooy <[hidden email]> ---
Created attachment 72348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72348&action=edit
Bug 18958 - If patron has multiple record level holds on one record
transferring first hold causes next hold to become item level

Imagine you have a record with 3 items, each item is held by LibraryA, LibraryB
and LibraryC respectively. Now, a patron places to record level holds for
pickup at LibraryD. When any of the items are checked in, that item is trapped
to fill the first hold, but a side affect is that the next open hold because
item level for the item that was just checked in!

This is clearly incorrect and prevents the patron from placing more record
level holds on the record.

Test Plan:
1. Create and use a patron that can place multiple record level holds per
record
2. Create a record with X items, each at a different library
3. Place X 'Next available' holds on the record for the patron using the 'Holds
to place' box
4. Rebuild the holds queue
5. Check in LibraryA's copy as LibraryA and confirm the hold
6. Revisit request.pl for the record, notice the next hold in line is now
item-specific
7. Attempt to place another hold for your patron, notice that it requires an
item-specific hold
8. Apply this patch
9. Repeat steps 1-4
10. Revisit request.pl for the record, notice the next hold in line has *not*
become item-specific

Signed-off-by: Kyle M Hall <[hidden email]>

Signed-off-by: Jason Robb <[hidden email]>

Signed-off-by: Josef Moravec <[hidden email]>

Bug 18958 [QA Followup] - Bring back data needed for the diffbranch block of
the template

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

--- Comment #14 from Marcel de Rooy <[hidden email]> ---
Created attachment 72349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72349&action=edit
Bug 18958: (Follow-up) Pass patron to template for confirm hold

Removing the FIXME. Trivial fix.
Not sure where to put it; can be moved on its own.

Test plan:
Confirm a hold and verify that patron details are shown in popup.

Signed-off-by: Marcel de Rooy <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12