[Bug 18915] New: Creating a checkout note (patron note) sends an incomplete email message

classic Classic list List threaded Threaded
42 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] New: Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

            Bug ID: 18915
           Summary: Creating a checkout note (patron note) sends an
                    incomplete email message
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Taken from bug 14224:

(Marcel de Rooy from comment #122 )
> <<borrowers.firstname>> <<borrowers.surname>> has added a note to the item
> <<biblio.item>> - <<biblio.author>> (<<biblio.biblionumber>>).
>
> What is biblio.item supposed to print here?
> I got this mail:
> M De Rooy has added a note to the item  - Schwartz, Randal L (23).
>
> And must say that it might not be that clear..
> Do we need biblio.title and an item number ?

Have tested and can confirm that this bug exists.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #1 from Aleisha Amohia <[hidden email]> ---
Created attachment 64937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64937&action=edit
Bug 18915: Fix checkout note email message

This patch changes patron_note to checkout_note in the appropriate
places, and ensures the email gets the title of the item.

To test:
1) Apply patch and update database
2) View the message_queue table in mysql
3) Check out an item if haven't already
4) Go to OPAC and set a checkout note for an item
5) View message_queue table and confirm it the title is included in the
email and all instances of 'patron note' have been replaced with
'checkout note'
6) Disable javascript in browser
7) repeat steps 4 and 5 and confirm all works as expected

Sponsored-by: Catalyst IT

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|[hidden email]         |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14224
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224
[Bug 14224] patron notes about item shown at check in
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Amit Gupta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Marc Véron <[hidden email]> ---
What happens if a library has modified the note? - Modifications for title and
content would get lost with the following statement in
bug_18915_-_modifying_patron_note_notice.sql

UPDATE letter SET code = 'CHECKOUT_NOTE', name = 'Checkout note on item set by
patron', title = 'Checkout note', content = '<<borrowers.firstname>>
<<borrowers.surname>> has added a note to the item <<biblio.title>> -
<<biblio.author>> (<<biblio.biblionumber>>).' WHERE code = 'PATRON_NOTE';

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #3 from Aleisha Amohia <[hidden email]> ---
(In reply to Marc Véron from comment #2)
> What happens if a library has modified the note? - Modifications for title
> and content would get lost with the following statement in
> bug_18915_-_modifying_patron_note_notice.sql
>
> UPDATE letter SET code = 'CHECKOUT_NOTE', name = 'Checkout note on item set
> by patron', title = 'Checkout note', content = '<<borrowers.firstname>>
> <<borrowers.surname>> has added a note to the item <<biblio.title>> -
> <<biblio.author>> (<<biblio.biblionumber>>).' WHERE code = 'PATRON_NOTE';

I see what you mean, but this patch is fixing the content of the note, so it
does need to be changed. Unless you can think of another way to fix the note?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Marc Véron <[hidden email]> ---
cc Marcel because of the initial comment

Maybe a warning in update notes that contents of note have been reset?
However, IMO librarians would not be happy about.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from Katrin Fischer <[hidden email]> ---
I think in another case, when <<items.fine>> was introduced, Dobrica managed to
just replace the broken bit. Could this be an option here? Just replacing
biblio.item with biblio.title? The old database update could give an example.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #6 from Marcel de Rooy <[hidden email]> ---
(In reply to Aleisha Amohia from comment #3)

> (In reply to Marc Véron from comment #2)
> > What happens if a library has modified the note? - Modifications for title
> > and content would get lost with the following statement in
> > bug_18915_-_modifying_patron_note_notice.sql
> >
> > UPDATE letter SET code = 'CHECKOUT_NOTE', name = 'Checkout note on item set
> > by patron', title = 'Checkout note', content = '<<borrowers.firstname>>
> > <<borrowers.surname>> has added a note to the item <<biblio.title>> -
> > <<biblio.author>> (<<biblio.biblionumber>>).' WHERE code = 'PATRON_NOTE';
>
> I see what you mean, but this patch is fixing the content of the note, so it
> does need to be changed. Unless you can think of another way to fix the note?

Aleisha,
Could you fix the note by just a SQL replace for the wrong field?
UPDATE table SET field = REPLACE(field ,from_str, to_str) etc etc
So look for biblio.item only and replace that by biblio.title.
If the library changed the note and fixed it already, there will be no problem.

Please adjust this entry too:
installer/data/mysql/updatedatabase.pl:        VALUES ('circulation',
'PATRON_NOTE', '', 'Patron note on item', '0', 'Patron issue note',
'<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item
<<biblio.item>> - <<biblio.author>> (<<biblio.biblionumber>>).','email');

And do not forget to add PATRON_NOTE (or CHECKOUT_NOTE) to
installer/data/mysql/en/mandatory/sample_notices.sql
It does not occur yet..

Thanks !

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64937|0                           |1
        is obsolete|                            |

--- Comment #7 from Aleisha Amohia <[hidden email]> ---
Created attachment 66518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66518&action=edit
Bug 18915: Fix checkout note email message

This patch replaces the <<biblio.item>> in the email with
<<biblio.title>> and uses CHECKOUT_NOTE instead of PATRON_NOTE.
This patch also adds the notice to
installer/data/mysql/en/mandatory/sample_notices.sql, and updates the
PATRON_NOTE entry in installer/data/mysql/updatedatabase.pl

To test:
1) Apply patch and update database
2) View the message_queue table in mysql
3) Check out an item if haven't already
4) Go to OPAC and set a checkout note for an item
5) View message_queue table and confirm it the title is included in the
email and all instances of 'patron note' have been replaced with
'checkout note'
6) Disable javascript in browser
7) repeat steps 4 and 5 and confirm all works as expected

Sponsored-by: Catalyst IT

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_17_11_candidate
           Severity|enhancement                 |normal

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #8 from M. Tompsett <[hidden email]> ---
Comment on attachment 66518
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66518
Bug 18915: Fix checkout note email message

Review of attachment 66518:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18915&attachment=66518)
-----------------------------------------------------------------

::: installer/data/mysql/updatedatabase.pl
@@ +14308,4 @@
>  
>      $dbh->do(q|
>          INSERT IGNORE INTO letter (`module`, `code`, `branchcode`, `name`, `is_html`, `title`, `content`, `message_transport_type`)
> +        VALUES ('circulation', 'CHECKOUT_NOTE', '', 'Checkout note on item set by patron', '0', 'Checkout note', '<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item <<biblio.title>> - <<biblio.author>> (<<biblio.biblionumber>>).','email');

I don't think updatedatabase should be modified like this. This is already
done. You add a new DB update which tweaks PATRON_NOTE into CHECKOUT_NOTE, if
this is correct logic.

::: opac/svc/patron_notes
@@ +82,4 @@
>                  my $biblionumber = $issue->item->biblionumber;
>                  my $letter = C4::Letters::GetPreparedLetter (
>                      module => 'circulation',
> +                    letter_code => 'CHECKOUT_NOTE',

Why even change the letter code, given that you aren't changing the svc name?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Caroline Cyr La Rose <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caroline.cyr-la-rose@inlibr
                   |                            |o.com

--- Comment #9 from Caroline Cyr La Rose <[hidden email]> ---
The test plan works.

However, is it normal that if I add <<issues.note>> in the notice it comes back
as blank in the message_queue table?

I checked and my notes are in the issues table.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_17_11_candidate         |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Patrick Robitaille <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille@collecto
                   |                            |.ca

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Marjorie Barry-Vila <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila@collect
                   |                            |o.ca

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #10 from Aleisha Amohia <[hidden email]> ---
*** Bug 19772 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #11 from Aleisha Amohia <[hidden email]> ---
Created attachment 69839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69839&action=edit
Bug 18915: Giving CHECKOUT_NOTE access to issues table

This patch allows the notice to reference the issues table so that the
checkout note itself can be added to the note if wanted, such as in
Comment 9.

Sponsored-by: Catalyst IT

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #12 from Aleisha Amohia <[hidden email]> ---
(In reply to M. Tompsett from comment #8)

> ::: installer/data/mysql/updatedatabase.pl
> @@ +14308,4 @@
> >  
> >      $dbh->do(q|
> >          INSERT IGNORE INTO letter (`module`, `code`, `branchcode`, `name`, `is_html`, `title`, `content`, `message_transport_type`)
> > +        VALUES ('circulation', 'CHECKOUT_NOTE', '', 'Checkout note on item set by patron', '0', 'Checkout note', '<<borrowers.firstname>> <<borrowers.surname>> has added a note to the item <<biblio.title>> - <<biblio.author>> (<<biblio.biblionumber>>).','email');
>
> I don't think updatedatabase should be modified like this. This is already
> done. You add a new DB update which tweaks PATRON_NOTE into CHECKOUT_NOTE,
> if this is correct logic.

I thought this change was necessary for fresh installs. If the atomic update is
enough then I'm happy to take this out.

>
> ::: opac/svc/patron_notes
> @@ +82,4 @@
> >                  my $biblionumber = $issue->item->biblionumber;
> >                  my $letter = C4::Letters::GetPreparedLetter (
> >                      module => 'circulation',
> > +                    letter_code => 'CHECKOUT_NOTE',
>
> Why even change the letter code, given that you aren't changing the svc name?

Mostly so that the name of the note is consistent with the name of the syspref
(AllowCheckoutNotes), therefore, the name of the feature. The filename should
also be changed as checkout note is more appropriate than patron note anyway -
I think this was just a missed case from the original bug.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #13 from Aleisha Amohia <[hidden email]> ---
Created attachment 69840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69840&action=edit
Bug 18915: Renaming svc/patron_notes to svc/checkout_notes

For consistency.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #14 from Jonathan Druart <[hidden email]> ---
QA: Please make sure bug 19772 is fixed.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #15 from Aleisha Amohia <[hidden email]> ---
(In reply to Jonathan Druart from comment #14)
> QA: Please make sure bug 19772 is fixed.

Yes this has been fixed. The problem was I'd missed a case when changing
PATRON_NOTE to CHECKOUT_NOTE in svc/checkout_notes.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

[hidden email] <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |[hidden email]

--- Comment #16 from [hidden email] <[hidden email]> ---
Patch tested with a sandbox, by Marjorie Vila <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

[hidden email] <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66518|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

[hidden email] <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69839|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

[hidden email] <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69840|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12