[Bug 18887] New: Introduce new table 'circulation_rules', use for ' max_holds' rules

classic Classic list List threaded Threaded
123 messages Options
12345
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] New: Introduce new table 'circulation_rules', use for ' max_holds' rules

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

            Bug ID: 18887
           Summary: Introduce new table 'circulation_rules', use for
                    'max_holds' rules
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
            Blocks: 18886


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18886
[Bug 18886] Restructure storage of circulation rules to reduce complexity and
enable increased flexiblity
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Marc VĂ©ron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15524


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524
[Bug 15524] Set limit on maximum possible holds per patron by category
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18925


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925
[Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #1 from Kyle M Hall <[hidden email]> ---
Created attachment 65233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65233&action=edit
Bug 18887 - Update database

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #2 from Kyle M Hall <[hidden email]> ---
Created attachment 65234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65234&action=edit
Bug 18887 - Add new schema file

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #3 from Kyle M Hall <[hidden email]> ---
Created attachment 65235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65235&action=edit
Bug 18887 - Update existing schema files

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #4 from Kyle M Hall <[hidden email]> ---
Created attachment 65236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65236&action=edit
Bug 18887 - Add Koha::CirculationRule(s)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #5 from Kyle M Hall <[hidden email]> ---
Created attachment 65237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65237&action=edit
Bug 18887 - Port max_holds rules to new CirculationRules system

This is the first step in the circulation rules revamp as detailed
in the RFF
https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend_Revamp_RFC

This patch moves the recent max_holds rule to the new circulation_rules table.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Go to the circ rules editor, note the new max holds rules
   by patron category in the "Checkout limit by patron category".
   ( Should we rename this section? )
4) Create find a patron that is allowed to place a hold, count the
   number of holds that patron has. Lets make that number 'X'.
5) Set the new max holds rule to X for "All libraries"
6) Note the patron can no longer place another hold
7) Set the new max holds rule to X + 1 for the patron's home library
8) Note the patron can again place another hold
9) Set the new max holds rule to X for the patron's home library
10) Note the patron can no longer place another hold

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #6 from Jesse Weaver <[hidden email]> ---
Comment on attachment 65233
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65233
Bug 18887 - Update database

Review of attachment 65233:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18887&attachment=65233)
-----------------------------------------------------------------

::: installer/data/mysql/atomicupdate/bug_18887.perl
@@ +24,5 @@
> +    });
> +
> +    $dbh->do(q{
> +        INSERT INTO circulation_rules ( branchcode, categorycode, itemtype, rule_name, rule_value )
> +        SELECT NULL, categorycode, NULL, 'max_holds', max_holds FROM branch_borrower_circ_rules

Shouldn't this SELECT be pulling from `default_borrower_circ_rules`?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Jesse Weaver <[hidden email]> ---
Comment on attachment 65236
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65236
Bug 18887 - Add Koha::CirculationRule(s)

I'm a bit confused as to the intended API; the new code in Reserves.pm uses
CirculationRules->find, the template plugin uses CirculationRules->search, and
there's an unused(?) method called get_effective_rule that seems like it
implements the inheritance logic correctly.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |[hidden email]

--- Comment #8 from Josef Moravec <[hidden email]> ---
 FAIL   Koha/CirculationRules.pm
   FAIL   forbidden patterns
                forbidden pattern: Data::Dumper::Dumper (line 139)
   FAIL   pod coverage
                POD is missing for 'object_class'


Setting the max_holds rule for some library is ok and getting used when placing
hold.

But when I try to set default rule for all libraries, the rule is saved to the
database (with branchcode = NULL), but is not shown on the circulation rules
page.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #9 from Jesse Weaver <[hidden email]> ---
Created attachment 67620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67620&action=edit
Bug 18887: (follow-up) Fix behavior for default branch/category

Also, fix a couple small QA issues.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |[hidden email]

--- Comment #10 from Alex Buckley <[hidden email]> ---
Hi Kyle

Can you please rebase against master because when trying to apply the patches
up to and including the 'port max_holds_rules to new CirculationRules systems'
(after applying the dependency: patch 15524) I got the below merge error.

The issue is in Koha/Schema/Result/Branch.pm file.

Apply? [(y)es, (n)o, (i)nteractive] i
Applying: Bug 18887 - Update database
Applying: Bug 18887 - Add new schema file
Applying: Bug 18887 - Update existing schema files
Using index info to reconstruct a base tree...
M       Koha/Schema/Result/Branch.pm
Falling back to patching base and 3-way merge...
Auto-merging Koha/Schema/Result/Branch.pm
CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 18887 - Update existing schema files
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-18887---Update-existing-schema-files-74PCpN.patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65233|0                           |1
        is obsolete|                            |

--- Comment #11 from Jesse Weaver <[hidden email]> ---
Created attachment 70986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70986&action=edit
Bug 18887 - Update database

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65234|0                           |1
        is obsolete|                            |

--- Comment #12 from Jesse Weaver <[hidden email]> ---
Created attachment 70987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70987&action=edit
Bug 18887 - Add new schema file

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65235|0                           |1
        is obsolete|                            |

--- Comment #13 from Jesse Weaver <[hidden email]> ---
Created attachment 70988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70988&action=edit
Bug 18887 - Update existing schema files

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65236|0                           |1
        is obsolete|                            |

--- Comment #14 from Jesse Weaver <[hidden email]> ---
Created attachment 70989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70989&action=edit
Bug 18887 - Add Koha::CirculationRule(s)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65237|0                           |1
        is obsolete|                            |

--- Comment #15 from Jesse Weaver <[hidden email]> ---
Created attachment 70990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70990&action=edit
Bug 18887 - Port max_holds rules to new CirculationRules system

This is the first step in the circulation rules revamp as detailed
in the RFF
https://wiki.koha-community.org/wiki/Circulation_Rules_Interface_and_Backend_Revamp_RFC

This patch moves the recent max_holds rule to the new circulation_rules table.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Go to the circ rules editor, note the new max holds rules
   by patron category in the "Checkout limit by patron category".
   ( Should we rename this section? )
4) Create find a patron that is allowed to place a hold, count the
   number of holds that patron has. Lets make that number 'X'.
5) Set the new max holds rule to X for "All libraries"
6) Note the patron can no longer place another hold
7) Set the new max holds rule to X + 1 for the patron's home library
8) Note the patron can again place another hold
9) Set the new max holds rule to X for the patron's home library
10) Note the patron can no longer place another hold

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67620|0                           |1
        is obsolete|                            |

--- Comment #16 from Jesse Weaver <[hidden email]> ---
Created attachment 70991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70991&action=edit
Bug 18887: (follow-up) Fix behavior for default branch/category

Also, fix a couple small QA issues.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

--- Comment #17 from Jesse Weaver <[hidden email]> ---
Created attachment 71031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71031&action=edit
Bug 18887: (follow-up) Fix null/empty behavior

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71031|0                           |1
        is obsolete|                            |

--- Comment #18 from Jesse Weaver <[hidden email]> ---
Created attachment 71042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71042&action=edit
Bug 18887: (follow-up) Fix null/empty behavior

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70986|0                           |1
        is obsolete|                            |

--- Comment #19 from Jesse Weaver <[hidden email]> ---
Created attachment 72218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72218&action=edit
Bug 18887 - Update database

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70987|0                           |1
        is obsolete|                            |

--- Comment #20 from Jesse Weaver <[hidden email]> ---
Created attachment 72219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72219&action=edit
Bug 18887 - Add new schema file

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70988|0                           |1
        is obsolete|                            |

--- Comment #21 from Jesse Weaver <[hidden email]> ---
Created attachment 72220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72220&action=edit
Bug 18887 - Update existing schema files

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887

Jesse Weaver <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70989|0                           |1
        is obsolete|                            |

--- Comment #22 from Jesse Weaver <[hidden email]> ---
Created attachment 72221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72221&action=edit
Bug 18887 - Add Koha::CirculationRule(s)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12345