https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Bug ID: 18856 Summary: Cancel Waiting Hold in OPAC does not give useful message Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: [hidden email] Reporter: [hidden email] QA Contact: [hidden email] If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Barton Chittenden <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email] --- Comment #1 from Barton Chittenden <[hidden email]> --- I think that this is an actual bug -- it's confusing to patrons who think that their hold was actually cancelled, and it doesn't give them any indication that they need to talk to the library who would actually have to cancel the hold. --Barton -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Katrin Fischer <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email] See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2812 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Katrin Fischer <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12876 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
--- Comment #2 from Katrin Fischer <[hidden email]> --- I did some digging and it looks like there should be no button when the hold is waiting or in transfer already. (see bug 12876) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Kyle M Hall <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
--- Comment #3 from Kyle M Hall <[hidden email]> --- Created attachment 67480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67480&action=edit Bug 18856 - Cancel Waiting Hold in OPAC does not give useful message If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Kyle M Hall <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email] Severity|enhancement |normal Assignee|[hidden email] |[hidden email] -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Caroline Cyr La Rose <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose <[hidden email]> --- Works as described! :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Kyle M Hall <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67480|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <[hidden email]> --- Created attachment 67520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67520&action=edit Bug 18856 - Cancel Waiting Hold in OPAC does not give useful message If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds Signed-off-by: Kyle M Hall <[hidden email]> Signed-off-by: Caroline Cyr La Rose <[hidden email]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Marcel de Rooy <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email] --- Comment #6 from Marcel de Rooy <[hidden email]> --- Just confirming the above by doublechecking the code: Cancel button calls opac-modrequest.pl (once called only in opac-user) opac-modrequest.pl checks with CanReserveBeCanceledFromOpac. This sub returns false for waiting or transit. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Marcel de Rooy <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Marcel de Rooy <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67520|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <[hidden email]> --- Created attachment 69077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69077&action=edit Bug 18856 - Cancel Waiting Hold in OPAC does not give useful message If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds Signed-off-by: Kyle M Hall <[hidden email]> Signed-off-by: Caroline Cyr La Rose <[hidden email]> Signed-off-by: Marcel de Rooy <[hidden email]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Marcel de Rooy <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|[hidden email]-communit |[hidden email] |y.org | -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Marcel de Rooy <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Jonathan Druart <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |[hidden email]-c | |ommunity.org --- Comment #8 from Jonathan Druart <[hidden email]> --- What about the other occurrence of is_cancelable in the same template file? 695 [% IF ( RESERVE.is_cancelable ) %] -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Jessie Zairo <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email] -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Kyle M Hall <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
--- Comment #9 from Kyle M Hall <[hidden email]> --- Created attachment 70294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70294&action=edit Bug 18856 [QA Followup] - Catch missed instance of is_cancelable -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Katrin Fischer <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Katrin Fischer <[hidden email]> --- Fixed the patch subjects according to guidelines (XXXX: (follow-up) state what was fixed) Should is_cancelable be removed after this change? It seems the only remaining occurrences are in tests: Koha/Hold.pm:=head3 is_cancelable Koha/Hold.pm:sub is_cancelable { t/db_dependent/Hold.t:# Test method is_cancelable t/db_dependent/Hold.t:ok( $hold->is_cancelable(), "Unfound hold is cancelable" ); t/db_dependent/Hold.t:ok( $hold->is_cancelable, "Waiting hold is cancelable" ); t/db_dependent/Hold.t:ok( !$hold->is_cancelable, "In transit hold is not cancelable" ); Sorry Marcel, forgot to check the QA contact first! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
--- Comment #11 from Katrin Fischer <[hidden email]> --- Created attachment 70398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70398&action=edit Bug 18856: Don't show cancel option for waiting holds in OPAC If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds Signed-off-by: Kyle M Hall <[hidden email]> Signed-off-by: Caroline Cyr La Rose <[hidden email]> Signed-off-by: Marcel de Rooy <[hidden email]> Signed-off-by: Katrin Fischer <[hidden email]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
--- Comment #12 from Katrin Fischer <[hidden email]> --- Created attachment 70399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70399&action=edit Bug 18856: (follow-up) Catch missed instance of is_cancelable Signed-off-by: Katrin Fischer <[hidden email]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Katrin Fischer <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69077|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Katrin Fischer <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70294|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Jonathan Druart <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70398|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <[hidden email]> --- Created attachment 70419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70419&action=edit [ALTERNATIVE-PATCH] Bug 18856: Don't show cancel option for waiting holds in OPAC This is the alternative patch of Kyle's """ If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds """ It sounds better to keep the ->is_cancelable method, for readability -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Jonathan Druart <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #14 from Jonathan Druart <[hidden email]> --- Kyle, Katrin and Marcel, could you take a look at this l ast patch? It sounds better to me to keep the method and fix its behaviour instead of testing is_found that can be confusing. Feel free to obsolete it if you disagree and I will pushed Kyle's patches with a follow-up to remove the method and the tests. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
--- Comment #15 from Barton Chittenden <[hidden email]> --- (In reply to Jonathan Druart from comment #14) > Kyle, Katrin and Marcel, could you take a look at this l > ast patch? > It sounds better to me to keep the method and fix its behaviour instead of > testing is_found that can be confusing. Feel free to obsolete it if you > disagree and I will pushed Kyle's patches with a follow-up to remove the > method and the tests. The problem with 'is_cancelable' is that staff and opac have different views of whether the item is cancelable or not, whereas is_found is un-ambiguous. is_cancelable *sounds* like it's clearer because it signals its intent, but under the circumstances, I think 'is_found' is better. Just my humble opinion; I'm also probably missing context because I haven't taken the time to read the code, so take my words with a large grain of salt. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
Jonathan Druart <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70398|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
--- Comment #16 from Jonathan Druart <[hidden email]> --- Yes Barton you are right, that's why I added a comment to the POD of the method to tell it only applies for the OPAC. Maybe rename the method to something more verbose (is_cancelable_from_opac) to remove the ambiguity? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856
--- Comment #17 from Katrin Fischer <[hidden email]> --- is_found is also a bit confusing, because this also includes transit items. found = F in the reserves table is for waiting. So you might not think about the transit items as well immediately. It confused me on testing this. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [hidden email] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ |
Free forum by Nabble | Edit this page |