[Bug 18818] New: Manage categories displayed in Quick_add patron list

classic Classic list List threaded Threaded
52 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] New: Manage categories displayed in Quick_add patron list

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

            Bug ID: 18818
           Summary: Manage categories displayed in Quick_add patron list
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

Some librarian would like to be able to manage the list displayed by clicking
on members/members-home.pl => Quick add new patron

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Patch complexity|---                         |Small patch
           Assignee|[hidden email]-commun |baptiste.wojtkowski@biblibr
                   |ity.org                     |e.com

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

--- Comment #1 from Baptiste <[hidden email]> ---
Created attachment 64422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64422&action=edit
Bug 18818: Display in quick add list now depends on a field in database

test plan:
1 - Apply patch
2 - Run update misc/devel/update_dbix_class_files.pl
3 - Run installer/data/mysql/updatedatabase.pl
4 - Check in Administation>patron categories there is a field named "Display in
Quick add patron" (and check everything is set to "Display")
5 - Try to edit and check that the field exists and edits well the field
6 - Go to Patrons => quick add patron and check that the list displayed only
consists in wished categories

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |m

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |,
                   |                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Marc Véron <[hidden email]> ---
Works fine.

There is a small capitalization issue (List view and edit)

Display
Don't Display  (should be: Don't display)

For readability, what about a change to the following in both list end edit
form?
Show
Hide

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Caroline Cyr La Rose <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |caroline.cyr-la-rose@inlibr
                   |                            |o.com

--- Comment #3 from Caroline Cyr La Rose <[hidden email]> ---
I'm stuck at step 4.

I applied the patch and ran the two scripts update_dbix_class_files.pl and
updatedatabase.pl. I then went into admin>patron categories and got a software
error :

Template process failed: undef error - The method quick_add_display is not
covered by tests! at C4/Templates.pm line 121.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|baptiste.wojtkowski@biblibr |[hidden email]
                   |e.com                       |m

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #4 from Fridolin SOMERS <[hidden email]> ---
(In reply to Caroline Cyr La Rose from comment #3)
> I'm stuck at step 4.
>
> I applied the patch and ran the two scripts update_dbix_class_files.pl and
> updatedatabase.pl. I then went into admin>patron categories and got a
> software error :
>
> Template process failed: undef error - The method quick_add_display is not
> covered by tests! at C4/Templates.pm line 121.

I add this message when dbix class files are not updated.
Be sure to have quick_add_display in Koha/Schema/Result/Category.pm.
If using Plack/Memcached, restart them.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64422|0                           |1
        is obsolete|                            |

--- Comment #5 from Fridolin SOMERS <[hidden email]> ---
Created attachment 70801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70801&action=edit
Bug 18818: Display in quick add list now depends on a field in database

test plan:
1 - Apply patch
2 - Run update misc/devel/update_dbix_class_files.pl
3 - Run installer/data/mysql/updatedatabase.pl
4 - Check in Administation>patron categories there is a field named "Display in
Quick add patron" (and check everything is set to "Display")
5 - Try to edit and check that the field exists and edits well the field
6 - Go to Patrons => quick add patron and check that the list displayed only
consists in wished categories

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

--- Comment #6 from Fridolin SOMERS <[hidden email]> ---
Created attachment 70802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70802&action=edit
Bug 18818: (followup) correct template

Main change is the use of Yes/No instead if Display/Don't display.
It is more compact and more explicit.

And fixes in categories.tt :
- Template Toolkit markup inside HTML in <select id="quick_add_display">
- Missing double-quotes in HTML attributes
- Missing value display in delete confirmation table
- Correct capitalization

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

--- Comment #7 from Fridolin SOMERS <[hidden email]> ---
(In reply to Marc Véron from comment #2)

> Works fine.
>
> There is a small capitalization issue (List view and edit)
>
> Display
> Don't Display  (should be: Don't display)
>
> For readability, what about a change to the following in both list end edit
> form?
> Show
> Hide

I've chosen to be more simple with Display in quick add : Yes/No.

Some template fixes where needed.

See follow-up.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70801|0                           |1
        is obsolete|                            |

--- Comment #8 from Fridolin SOMERS <[hidden email]> ---
Created attachment 70955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70955&action=edit
Bug 18818: Display in quick add list now depends on a field in database

This patch allows to manage the patron categories contained in 'Quick add new
patron'.

Test plan:
1) Apply patch
2) Update database structure : installer/data/mysql/updatedatabase.pl
3) Update DBIx shema : misc/devel/update_dbix_class_files.pl
4) Check in 'Administation > Patron categories' there is a field named "Display
in Quick add patron" (and check everything is set to "Display")
5) Try to edit and check that the field exists and edits well the field
6) Go to 'Patrons > quick add patron' and check that the list contains only
wished categories

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70802|0                           |1
        is obsolete|                            |

--- Comment #9 from Fridolin SOMERS <[hidden email]> ---
Created attachment 70956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70956&action=edit
Bug 18818: (followup) correct template

Main change is the use of Yes/No instead if Display/Don't display.
It is more compact and more explicit.

And fixes in categories.tt :
- Template Toolkit markup inside HTML in <select id="quick_add_display">
- Missing double-quotes in HTML attributes
- Missing value display in delete confirmation table
- Correct capitalization

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70955|0                           |1
        is obsolete|                            |

--- Comment #10 from Fridolin SOMERS <[hidden email]> ---
Created attachment 70959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70959&action=edit
Bug 18818: Display in quick add list now depends on a field in database

This patch allows to manage the patron categories contained in 'Quick add new
patron'.

Test plan:
1) Apply patch
2) Update database structure : installer/data/mysql/updatedatabase.pl
3) Update DBIx shema : misc/devel/update_dbix_class_files.pl
4) Check in 'Administation > Patron categories' there is a field named "Display
in Quick add patron" (and check everything is set to "Display")
5) Try to edit and check that the field exists and edits well the field
6) Go to 'Patrons > quick add patron' and check that the list contains only
wished categories

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70956|0                           |1
        is obsolete|                            |

--- Comment #11 from Fridolin SOMERS <[hidden email]> ---
Created attachment 70960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70960&action=edit
Bug 18818: (followup) correct template

Main change is the use of Yes/No instead if Display/Don't display.
It is more compact and more explicit.

And fixes in categories.tt :
- Template Toolkit markup inside HTML in <select id="quick_add_display">
- Missing double-quotes in HTML attributes
- Missing value display in delete confirmation table
- Correct capitalization

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

--- Comment #12 from M. Tompsett <[hidden email]> ---
Comment on attachment 70959
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70959
Bug 18818: Display in quick add list now depends on a field in database

Review of attachment 70959:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18818&attachment=70959)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
@@ +212,5 @@
>                  <li>
> +                    <label for="quick_add_display">Display in quick add patron list:</label>
> +                    <select id=quick_add_display name=quick_add_display>
> +                        <option value=1 [% UNLESS category.quick_add_display %]selected=selected [% END %]>Display</option>
> +                        <option value=0 [% UNLESS category.quick_add_display %]selected=selected [% END %]>Don't Display</option>

https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML
Violation.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70959|0                           |1
        is obsolete|                            |

--- Comment #13 from Fridolin SOMERS <[hidden email]> ---
Created attachment 70962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70962&action=edit
Bug 18818: Display in quick add list now depends on a field in database

This patch allows to manage the patron categories contained in 'Quick add new
patron'.

Test plan:
1) Apply patch
2) Update database structure : installer/data/mysql/updatedatabase.pl
3) Update DBIx shema : misc/devel/update_dbix_class_files.pl
4) Check in 'Administation > Patron categories' there is a field named "Display
in Quick add patron" (and check everything is set to "Display")
5) Try to edit and check that the field exists and edits well the field
6) Go to 'Patrons > quick add patron' and check that the list contains only
wished categories

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70960|0                           |1
        is obsolete|                            |

--- Comment #14 from Fridolin SOMERS <[hidden email]> ---
Created attachment 70963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70963&action=edit
Bug 18818: (followup) correct template

Main change is the use of Yes/No instead if Display/Don't display.
It is more compact and more explicit.

And fixes in categories.tt :
- Template Toolkit markup inside HTML in <select id="quick_add_display">
- Missing double-quotes in HTML attributes
- Missing value display in delete confirmation table
- Correct capitalization

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

--- Comment #15 from Fridolin SOMERS <[hidden email]> ---
Created attachment 70964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70964&action=edit
Bug 18818: define new column as boolean in DBIC Schema

See https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #16 from Owen Leonard <[hidden email]> ---
I'm getting this error when I run updatedatabase.pl:


{UNKNOWN}: DBIx::Class::ResultSource::column_info(): No such column
quick_add_display at /home/vagrant/kohaclone/Koha/Schema/Result/Category.pm
line 273
Compilation failed in require at /usr/share/perl5/Class/C3/Componentised.pm
line 150. at /usr/share/perl5/Class/C3/Componentised.pm line 155
Compilation failed in require at /home/vagrant/kohaclone/Koha/Database.pm line
50.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70962|0                           |1
        is obsolete|                            |

--- Comment #17 from Fridolin SOMERS <[hidden email]> ---
Created attachment 71227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71227&action=edit
Bug 18818: Display in quick add list now depends on a field in database

This patch allows to manage the patron categories contained in 'Quick add new
patron'.

Test plan:
1) Apply patches but not "define new column as boolean in DBIC Schema"
2) Update database structure : installer/data/mysql/updatedatabase.pl
3) Apply patch "define new column as boolean in DBIC Schema"
4) Update DBIx shema : misc/devel/update_dbix_class_files.pl
5) Go to Administation > Patron categories
6) Check there is a field named "Display in quick add" with "Yes"
7) Edit a category to set "No" and save
8) Check change is well saved
9) Go to "Patrons" and click on "Quick add patron"
10) Check the list contains only wanted categories

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70963|0                           |1
        is obsolete|                            |

--- Comment #18 from Fridolin SOMERS <[hidden email]> ---
Created attachment 71228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71228&action=edit
Bug 18818: (followup) correct template

Main change is the use of Yes/No instead if Display/Don't display.
It is more compact and more explicit.

And fixes in categories.tt :
- Template Toolkit markup inside HTML in <select id="quick_add_display">
- Missing double-quotes in HTML attributes
- Missing value display in delete confirmation table
- Correct capitalization

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70964|0                           |1
        is obsolete|                            |

--- Comment #19 from Fridolin SOMERS <[hidden email]> ---
Created attachment 71229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71229&action=edit
Bug 18818: define new column as boolean in DBIC Schema

See https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #20 from Fridolin SOMERS <[hidden email]> ---
(In reply to Owen Leonard from comment #16)

> I'm getting this error when I run updatedatabase.pl:
>
>
> {UNKNOWN}: DBIx::Class::ResultSource::column_info(): No such column
> quick_add_display at /home/vagrant/kohaclone/Koha/Schema/Result/Category.pm
> line 273
> Compilation failed in require at /usr/share/perl5/Class/C3/Componentised.pm
> line 150. at /usr/share/perl5/Class/C3/Componentised.pm line 155
> Compilation failed in require at /home/vagrant/kohaclone/Koha/Database.pm
> line 50.

Indeed, I have changed test plan to apply last patch only after updatedatabase.
I could not find another bug dealing with this DBIx change.

This bug can then not be tested with a sandbox.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

delaye <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |m
             Status|Needs Signoff               |Patch doesn't apply

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #21 from Fridolin SOMERS <[hidden email]> ---
Because of test plan I think this can not be tested on a sandbox.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18818] Manage categories displayed in Quick_add patron list

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818

[hidden email] <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71227|0                           |1
        is obsolete|                            |

--- Comment #22 from [hidden email] <[hidden email]> ---
Created attachment 72867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72867&action=edit
Bug 18818: Display in quick add list now depends on a field in database

This patch allows to manage the patron categories contained in 'Quick add new
patron'.

Test plan:
1) Apply patches but not "define new column as boolean in DBIC Schema"
2) Update database structure : installer/data/mysql/updatedatabase.pl
3) Apply patch "define new column as boolean in DBIC Schema"
4) Update DBIx shema : misc/devel/update_dbix_class_files.pl
5) Go to Administation > Patron categories
6) Check there is a field named "Display in quick add" with "Yes"
7) Edit a category to set "No" and save
8) Check change is well saved
9) Go to "Patrons" and click on "Quick add patron"
10) Check the list contains only wanted categories

Signed-off-by: JM Broust <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12