[Bug 18713] New: Add support for named graphs and rfds:seeAlso to Koha:: RDF

classic Classic list List threaded Threaded
42 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] New: Add support for named graphs and rfds:seeAlso to Koha:: RDF

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

            Bug ID: 18713
           Summary: Add support for named graphs and rfds:seeAlso to
                    Koha::RDF
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

When I download RDFXML via OAI-PMH, I delete existing named graphs and create
new named graphs. This functionality isn't specific to OAI-PMH, so I'm putting
it in Koha::RDF.

There is also a method for adding rdfs:seeAlso to a $subject and an $object. In
my case, I'm linking a Koha record to an imported record. It's a generic
relationship though, which will be useful in many other scenarios, so it's
going in Koha::RDF too.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

David Cook <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10787,
                   |                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18586

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

David Cook <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18586


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586
[Bug 18586] Create module to mint RDF subject URIs
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

David Cook <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #1 from David Cook <[hidden email]> ---
Created attachment 63894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63894&action=edit
Bug 18713 - Add support for named graphs and rfds:seeAlso to Koha::RDF

This patch adds methods to Koha::RDF that creates or deletes a named
graph by removing/adding RDF quads from/to a triplestore.

This patch also can create a rdfs:seeAlso relationship between
two RDF entities.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Magnus Enger <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #2 from David Cook <[hidden email]> ---
Working on unit tests now but have found a bug in RDF::Trine::Store::SPARQL so
will have to do a workaround tomorrow for that.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #3 from David Cook <[hidden email]> ---
Actually the workaround might be more inefficient so I'd rather just patch
RDF::Trine::Store::SPARQL...

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #4 from David Cook <[hidden email]> ---
(In reply to David Cook from comment #3)
> Actually the workaround might be more inefficient so I'd rather just patch
> RDF::Trine::Store::SPARQL...

Well actually... I thought of a different workaround which will be fine for
now, and I've sent a pull request with a patch for RDF::Trine::Store::SPARQL
(https://github.com/kasei/perlrdf/pull/150). The author of RDF::Trine has
already said that he'd welcome a patch for the bug, so that's good.

For the previous bug I found in RDF::Trine::Store::SPARQL, I sent a pull
request 23 days ago, it was merged into master 14 days ago, and a new version
of RDF::Trine was posted on CPAN 1 day ago (a dev release was on CPAN on May
19th so 14 days ago). So I imagine that by the time we're at Koha 17.11, the
updated version will be on CPAN and be easy to package.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

David Cook <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63894|0                           |1
        is obsolete|                            |

--- Comment #5 from David Cook <[hidden email]> ---
Created attachment 63908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63908&action=edit
Bug 18713 - Add support for named graphs and rfds:seeAlso to Koha::RDF

This patch adds methods to Koha::RDF that creates or deletes a named
graph by removing/adding RDF quads from/to a triplestore.

This patch also can create a rdfs:seeAlso relationship between
two RDF entities.

This patch includes unit tests for both of these changes.

_TEST PLAN_
1) Run "prove t/Koha/RDF.t"
2) Note that all tests have run successfully.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

David Cook <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63908|0                           |1
        is obsolete|                            |

--- Comment #6 from David Cook <[hidden email]> ---
Created attachment 63909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63909&action=edit
Bug 18713 - Add support for named graphs and rfds:seeAlso to Koha::RDF

This patch adds methods to Koha::RDF that creates or deletes a named
graph by removing/adding RDF quads from/to a triplestore.

This patch also can create a rdfs:seeAlso relationship between
two RDF entities.

This patch includes unit tests for both of these changes.

_TEST PLAN_
1) Run "prove t/Koha/RDF.t"
2) Note that all tests have run successfully.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63909|0                           |1
        is obsolete|                            |

--- Comment #7 from Josef Moravec <[hidden email]> ---
Created attachment 64020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64020&action=edit
[SIGNED-OFF] Bug 18713 - Add support for named graphs and rfds:seeAlso to
Koha::RDF

This patch adds methods to Koha::RDF that creates or deletes a named
graph by removing/adding RDF quads from/to a triplestore.

This patch also can create a rdfs:seeAlso relationship between
two RDF entities.

This patch includes unit tests for both of these changes.

_TEST PLAN_
1) Run "prove t/Koha/RDF.t"
2) Note that all tests have run successfully.

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Brendan Gallagher <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |m
             Status|Signed Off                  |Failed QA

--- Comment #8 from Brendan Gallagher <[hidden email]> ---
Hmm..  I am getting failed tests on this.  

 #   Failed test '2 statements in model (in default graph and a named graph)'
    #   at t/Koha/RDF.t line 65.
    #          got: '1'
    #     expected: '2'

    #   Failed test '3 statements in model (1 in default graph and 2 in
separate named graphs'
    #   at t/Koha/RDF.t line 71.
    #          got: '1'
    #     expected: '3'

    #   Failed test '2 statements in model (1 in default graph and 1 in a named
graph) after 1 of the named graphs was deleted'
    #   at t/Koha/RDF.t line 77.
    #          got: '1'
    #     expected: '2'
    # Looks like you failed 3 tests of 3.

Is it me and I missed something?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #9 from David Cook <[hidden email]> ---
(In reply to Brendan Gallagher from comment #8)
> Is it me and I missed something?

While working with RDF::Trine, I've noticed that there are a few bugs. I've
been sending patches to the maintainer to fix them as I find them, but it seems
that you've encountered a bug in an older version of RDF::Trine which has
already been fixed long ago.

I'm operating off of the most recent versions of RDF::Trine. I'm guessing that
you're on Debian Jessie which is on version 1.011
(https://packages.debian.org/jessie/librdf-trine-perl). It looks like there was
a bug that was fixed in 1.013. After that, the tests pass.

The current version of RDF::Trine is 1.017 and there is a dev version 1.017_1
which is in testing on http://cpantesters.org/ and will yield a 1.018 in the
next few weeks I imagine.

I've already talked to Mirko and he's happy to package the latest RDF::Trine in
the Koha Debian repository. Perhaps I should get him to do that before QA
continues on this patch?

If you want to double-check what I'm saying now, you can clone the git repo
from https://github.com/kasei/perlrdf, then run something like 'perl -I
~/perlrdf/RDF-Trine/lib t/Koha/RDF.t' and then the tests should pass.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

David Cook <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10662


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
[Bug 10662] Build OAI-PMH Harvesting Client
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #10 from David Cook <[hidden email]> ---
Hey Brendan, I just noticed that Debian Stretch is the new Debian stable. It
looks like it has RDF::Trine 1.015, which should pass these tests.

Alternatively, Mirko has uploaded RDF::Trine 1.018 to Koha unstable (and Jonas
Smedegaard has uploaded RDF::Trine 1.018 to Debian unstable):

"I have backported librdf-trine-perl 1.018-1 to the Koha unstable repository.
Please use option 1: install the package from our repository and report
problems if you encounter any."
(https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

David Cook <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #11 from David Cook <[hidden email]> ---
Mirko backported the latest version of RDF::Trine to Koha unstable I believe,
so it can be installed from there. That should allow this patch to work
correctly.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]          |[hidden email]
                 CC|                            |[hidden email]

--- Comment #12 from Katrin Fischer <[hidden email]> ---
Assigning to David as he is the author of the patch.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #13 from Josef Moravec <[hidden email]> ---
Created attachment 69633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69633&action=edit
Bug 18713 - Add support for named graphs and rfds:seeAlso to Koha::RDF

This patch adds methods to Koha::RDF that creates or deletes a named
graph by removing/adding RDF quads from/to a triplestore.

This patch also can create a rdfs:seeAlso relationship between
two RDF entities.

This patch includes unit tests for both of these changes.

_TEST PLAN_
1) Run "prove t/Koha/RDF.t"
2) Note that all tests have run successfully.

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64020|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #14 from Marcel de Rooy <[hidden email]> ---
Test fails. Seems to be reported before. Versioning/packaging ? Needs further
attention..

# Subtest: Create and delete named graphs
    1..3
    not ok 1 - 2 statements in model (in default graph and a named graph)
    #   Failed test '2 statements in model (in default graph and a named
graph)'
    #   at t/Koha/RDF.t line 65.
    #          got: '1'
    #     expected: '2'
    not ok 2 - 3 statements in model (1 in default graph and 2 in separate
named graphs
    #   Failed test '3 statements in model (1 in default graph and 2 in
separate named graphs'
    #   at t/Koha/RDF.t line 71.
    #          got: '1'
    #     expected: '3'
    not ok 3 - 2 statements in model (1 in default graph and 1 in a named
graph) after 1 of the named graphs was deleted
    #   Failed test '2 statements in model (1 in default graph and 1 in a named
graph) after 1 of the named graphs was deleted'
    #   at t/Koha/RDF.t line 77.
    #          got: '1'
    #     expected: '2'
    # Looks like you failed 3 tests of 3.
not ok 4 - Create and delete named graphs
#   Failed test 'Create and delete named graphs'
#   at t/Koha/RDF.t line 78.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #15 from David Cook <[hidden email]> ---
(In reply to Marcel de Rooy from comment #14)
> Test fails. Seems to be reported before. Versioning/packaging ? Needs
> further attention..
>

What operating system are you using, Marcel, and what version of RDF::Trine?

Mirko has the required version in the Koha unstable package repo and the
particular bug in question making the test fail should be resolved in Debian
stable (Stretch) now.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #16 from Marcel de Rooy <[hidden email]> ---
(In reply to David Cook from comment #15)

> (In reply to Marcel de Rooy from comment #14)
> > Test fails. Seems to be reported before. Versioning/packaging ? Needs
> > further attention..
> >
>
> What operating system are you using, Marcel, and what version of RDF::Trine?
>
> Mirko has the required version in the Koha unstable package repo and the
> particular bug in question making the test fail should be resolved in Debian
> stable (Stretch) now.

Debian Jessie. Do we support Koha on Stretch? No problems when switching to
MariaDB?
I have not tested the unstable repo very recently, but last time I tried it did
not work (yes unstable).

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #17 from David Cook <[hidden email]> ---
(In reply to Marcel de Rooy from comment #16)
>
> Debian Jessie. Do we support Koha on Stretch? No problems when switching to
> MariaDB?
> I have not tested the unstable repo very recently, but last time I tried it
> did not work (yes unstable).

No idea about Koha on Stretch. I heard something about it a while ago but I
don't know.

I'm not touching the database, so MariaDB shouldn't matter.

I suppose it's a bit of a catch-22... you need the dependency for it to pass QA
but the dependency won't be added until the patch passes QA?

You could probably just download the package from
http://debian.koha-community.org/koha/pool/main/libr/librdf-trine-perl/librdf-trine-perl_1.018-1~koha1_all.deb
and try it just for the sake of QA.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off
                 CC|                            |[hidden email]

--- Comment #18 from Marcel de Rooy <[hidden email]> ---
(In reply to David Cook from comment #17)
> I suppose it's a bit of a catch-22... you need the dependency for it to pass
> QA but the dependency won't be added until the patch passes QA?

No, that cant be true. I will reset the status.
If another QAer can test on Stretch, he may recommend to add the higher version
to the Koha repo.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |dependency

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713

--- Comment #19 from Mirko Tietgen <[hidden email]> ---
Not sure if I get it right. Is the test failing because the dependency is not
declared in the patch set? I think it should be, which should lead to the
dependency being pulled from the unstable repo (in a dev environment).

Also, what version do we actually need?

Stretch has 1.015. Our repo has 1.018, AFAIR because that was the latest
unstable available at the time of packaging and stretch was not yet released.
Which version do we actually require for it to work for us? Is 1.015 enough?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12