[Bug 18636] New: Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] New: Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

            Bug ID: 18636
           Summary: Can not save new patron on fresh install (Conflict
                    between autoMemberNum and BorrowerMandatoryField)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

Tested on a fresh install on current master

To reproduce:
- Go to Koha > Patrons > Add patron (full form)
- Verify that label for card number reads: "Card number(leave blank for auto
calc during registration):"
- Do not enter anything in field card number
- Enter surname, try to save
- Form does not save because field card number is required

Reason:
- autoMemberNum is on by default
 (sysprefs.sql line 65)
- BorrowerMandatoryField contains surname|cardnumber by default
 (sysprefs.sql line 86)
- Full form does not save because card number is mandatory and empty

Note: With quick add form and settings above, cardnumber is not displayed, form
saves properly.

What to do?
- Better explanation for autoMemberNum and BorrowerMandatoryField
- Set defaults for autoMemberNum and BorrowerMandatoryField in a way that they
do not conflict?
- Ignore cardnumber being a mandatory field if autoMemberNum is on?
- Ask for settings in onboarding tool?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Krishna K <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Michael Kuhn <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

--- Comment #1 from Krishna K <[hidden email]> ---
Hi,

We are using Koha 17.05.01 with MySQL. When we try to add a patron, the card
number field is not getting autogenerated and save is failing.

Automembernum is enabled and BorrowerMandatoryField contains cardnumber. I see
no contradiction in these parameters.

This was working perfectly fine in 16.05. What could be going wrong ?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Katrin Fischer <[hidden email]> ---
Hi Krishna, this is more of a support question I think and would be better on
the mailing list or in IRC. Please state which version of MySQL you are using.
If it's 5.7 or later it's strongly recommended you switch to MariaDB as there
are a lot of known problems with 5.7 being more strict.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

--- Comment #3 from Marc Véron <[hidden email]> ---
Created attachment 65699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65699&action=edit
Bug 18636: Sysprefs: Add explanation for conflict autonumbernum /
BorrowerMandatoryFields

This patch adds a note to the system preferences autonembernum and
BorrowerMandatoryFields regarding a conflict if automembernum is on
and BorrowerMandatoryFields contains cardnumber.

To reproduce issue: See initial comment.

To test:
- Apply patch
- Verify that in system preferences note appears with both prefs
  automembernum and BorrowerMandatoryFields

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |String patch

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

--- Comment #4 from Krishna K <[hidden email]> ---
Hi,

The documentation as part of the patch says if AutoMemberNum is ON, then
BorrowerMandatoryField should not contain cardnumber. If I remove cardnumber
from the BorrowerMandatoryField, then on adding a patron a long number gets
generated as the card number.This is happening after upgrading to 17.05.
Earlier, we were using 16.05 and there the card number was getting auto
generated by adding one to the last added patron's card number. So we had
numbers like say 125, 126 etc(we are a small library) whereas the settings
suggested in 17.05 leaves us with an unwieldy 14 digit card number.

Katrin, I will reconfirm on the MySQL version. Am not sure about that. Do you
think this is related to the autoincrement issue at the database level ?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

--- Comment #5 from Katrin Fischer <[hidden email]> ---
Hm, this might not be an update issue. The cardnumber is generated by looking
for the biggest used number in your database and adding 1. If you do something
like: select max(cardnumber) from borrowers; what does it give you? If you want
to get back to low numbers, you might just have to clean up a few records.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65699|0                           |1
        is obsolete|                            |

--- Comment #6 from Alex Buckley <[hidden email]> ---
Created attachment 66516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66516&action=edit
Bug 18636: Sysprefs: Add explanation for conflict autonumbernum /
BorrowerMandatoryFields

This patch adds a note to the system preferences autonembernum and
BorrowerMandatoryFields regarding a conflict if automembernum is on
and BorrowerMandatoryFields contains cardnumber.

To reproduce issue: See initial comment.

To test:
- Apply patch
- Verify that in system preferences note appears with both prefs
  automembernum and BorrowerMandatoryFields

Followed test plan, works as described
Signed-off-by: Alex Buckley <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Jonathan Druart <[hidden email]> ---
*** Bug 19224 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

--- Comment #8 from Jonathan Druart <[hidden email]> ---
What about a warning on the about page?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |19225


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19225
[Bug 19225] Warn on About page regarding sysprefs autoMemberNum and
BorrowerMandatoryField
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

--- Comment #9 from Marc Véron <[hidden email]> ---
(In reply to Jonathan Druart from comment #8)
> What about a warning on the about page?

See Bug 19225

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66516|0                           |1
        is obsolete|                            |

--- Comment #10 from Kyle M Hall <[hidden email]> ---
Created attachment 66730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66730&action=edit
Bug 18636: Sysprefs: Add explanation for conflict autonumbernum /
BorrowerMandatoryFields

This patch adds a note to the system preferences autonembernum and
BorrowerMandatoryFields regarding a conflict if automembernum is on
and BorrowerMandatoryFields contains cardnumber.

To reproduce issue: See initial comment.

To test:
- Apply patch
- Verify that in system preferences note appears with both prefs
  automembernum and BorrowerMandatoryFields

Followed test plan, works as described
Signed-off-by: Alex Buckley <[hidden email]>

Signed-off-by: Kyle M Hall <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18636] Can not save new patron on fresh install ( Conflict between autoMemberNum and BorrowerMandatoryField)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18636

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Jonathan Druart <[hidden email]> ---
Pushed to master for 17.11, thanks to everybody involved!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/