Quantcast

[Bug 18634] New: Missing empty line at end of opac.pref

classic Classic list List threaded Threaded
21 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] New: Missing empty line at end of opac.pref

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

            Bug ID: 18634
           Summary: Missing empty line at end of opac.pref
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

The subject line says it all.

When this line is missing, all Payment(PayPal) sysprefs don't show up in
translated pages.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #1 from Blou <[hidden email]> ---
Created attachment 63550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63550&action=edit
Bug 18634 - Missing empty line at end of opac.pref

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

Blou <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
                 CC|                            |[hidden email]
   Patch complexity|---                         |String patch
             Status|NEW                         |Needs Signoff
           Assignee|[hidden email]         |[hidden email]

--- Comment #2 from Blou <[hidden email]> ---
It's a shame to have a commit line just for that, but really, that's the reason
this is not translatable.  Or rather, it translates but don't show up.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #3 from Blou <[hidden email]> ---
Sponsored by : CCSR

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Marc Véron <[hidden email]> ---
I could not reproduce on current master with de-DE and it-IT

However an empty line 826 seems to be superfluous. Other *.pref-files do not
have an empty line at the end. So I think it is better to just remove line 826.

What do you think about?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #5 from Blou <[hidden email]> ---
For me, I enter "paypal" in the system preferences search and get 6 entries
under Payment in English.  I get nothing in French.
Adding the empty line fixes it.

Now, is it useless and senseless?  I agree.  I looked at circulation.pref for
comfort before commiting, and saw the "semi-emtpy" line.

I looked at fr-CA-pref.po for weirdness, could not find any.  The # OPAC >
Payments where right in the middle, all happy and comfy.

If ONE wouldn't show up, I'd get it.  But all six?  It really points to
opac.prefs, but I have no idea why (beside this dummy end line).

:(

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #6 from Marc Véron <[hidden email]> ---
Hi Blou
I just did a git pull and then wanted to apply and sign off your patch.
But now it seems that already without your patch the last line 826 has
vanished.
Maybe it was fixed by another patch?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Josef Moravec <[hidden email]> ---
(In reply to Marc Véron from comment #6)
> Hi Blou
> I just did a git pull and then wanted to apply and sign off your patch.
> But now it seems that already without your patch the last line 826 has
> vanished.
> Maybe it was fixed by another patch?

The same for me, but opac.pref was touch last time about 3 month ago

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #8 from Marcel de Rooy <[hidden email]> ---
(In reply to Marc Véron from comment #6)
> Hi Blou
> I just did a git pull and then wanted to apply and sign off your patch.
> But now it seems that already without your patch the last line 826 has
> vanished.
> Maybe it was fixed by another patch?

No this is about git and whitespace settings..

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #9 from Marcel de Rooy <[hidden email]> ---
(In reply to Blou from comment #5)

> For me, I enter "paypal" in the system preferences search and get 6 entries
> under Payment in English.  I get nothing in French.
> Adding the empty line fixes it.
>
> Now, is it useless and senseless?  I agree.  I looked at circulation.pref
> for comfort before commiting, and saw the "semi-emtpy" line.
>
> I looked at fr-CA-pref.po for weirdness, could not find any.  The # OPAC >
> Payments where right in the middle, all happy and comfy.
>
> If ONE wouldn't show up, I'd get it.  But all six?  It really points to
> opac.prefs, but I have no idea why (beside this dummy end line).
>
> :(

Several other .pref files do not have this empty line at the end.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #10 from Marcel de Rooy <[hidden email]> ---
Just looked a bit deeper in the code:

misc/translator uses YAML::Syck::LoadFile on a pref file

admin/preferences first uses gettemplate on a pref file, runs template->output
and feeds that into YAML::Syck::Load

Seems your problem is related to the second route.
In order to know what happens with your french prefs, please examine the output
of $data=gettemplate(...) and then $data->output in a test script, making sure
that gettemplate reads your french file.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #11 from Marcel de Rooy <[hidden email]> ---
Could you add your french pref file as an attachment here too?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #12 from Marcel de Rooy <[hidden email]> ---
Created attachment 63655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63655&action=edit
Sample test code

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #13 from Blou <[hidden email]> ---
Created attachment 63656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63656&action=edit
File causing the problem

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #14 from Blou <[hidden email]> ---
Thanks Marcel,
I joined the file I have on my laptop.  I had moved from the problem to other
issues, but I'll be happy to do your test as soon as I find 10 minutes, sooner
rather than later.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #15 from Marcel de Rooy <[hidden email]> ---
(In reply to Blou from comment #14)
> Thanks Marcel,
> I joined the file I have on my laptop.  I had moved from the problem to
> other issues, but I'll be happy to do your test as soon as I find 10
> minutes, sooner rather than later.

Hi. Could you also attach the actual opac.pref ?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #16 from Blou <[hidden email]> ---
Created attachment 63660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63660&action=edit
Translated fr-CA opac.pref

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #17 from Marcel de Rooy <[hidden email]> ---
(In reply to Blou from comment #16)
> Created attachment 63660 [details] [review]
> Translated fr-CA opac.pref

Blou,
When I am copying your opac.pref over my english opac.pref, and I am searching
for paypal, I do find all paypal preferences, regardless of adding or removing
an empty line to this file?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #18 from Blou <[hidden email]> ---
:(  of course, I sent you the one "fixed" with the extra line before
translation, so I guess the resulting one doesn't cause trouble.

gimme a sec

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

--- Comment #19 from Marcel de Rooy <[hidden email]> ---
(In reply to Blou from comment #18)
> :(  of course, I sent you the one "fixed" with the extra line before
> translation, so I guess the resulting one doesn't cause trouble.

I always want the files with the problems :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18634] Missing empty line at end of opac.pref

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634

Blou <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63660|0                           |1
        is obsolete|                            |

--- Comment #20 from Blou <[hidden email]> ---
Created attachment 63690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63690&action=edit
Translated fr-CA opac.pref

Version that hide 'paypal' results.  (I just tested again before submitting)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Loading...