[Bug 18629] New: Web installer 17.05 not properly translatable

classic Classic list List threaded Threaded
40 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] New: Web installer 17.05 not properly translatable

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

            Bug ID: 18629
           Summary: Web installer 17.05 not properly translatable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

Web installer displays a mix between translated languages and English.
That is ugly, because installing is the first contact with Koha.

Tested with 17.05 de-DE and it-IT (both 100% translated)
(Note: Results below are the similar for both it-IT and de-DE, same parts not
translated)

To test:
Download po files from http://translate.koha-community.org/de/17.05/ or
http://translate.koha-community.org/it/17.05/

Install the languages
cd misc/translator
perl translate -v install it-IT
or
perl translate -v install de-DE

Drop database
Create database

Restart memcached and plack

Go to staff client (calls web installer), enter database user and pw

Select one of the languages de-DE or it-IT, Continue to the next step

Result:
------------
Web installer › Check Perl dependencies

Alle erforderlichen Perl-Module sind installiert.

Alle erforderlichen Abhängigkeiten sind installiert.

Continue to the next step
------------

Continue...

Result:
------------
Web installer › Database settings
Datenbankeinstellungen:

    Database type : mysql
    Database name : koha_kohadev
    Database host : localhost
    Database port : 3306 (probably okay if blank)
    Database user : koha_kohadev

Continue to the next step
-------------

Continue...

Result: Similar as above

Continue:

Result:
-------------
Web installer › Set up database

Jetzt sind wir soweit, dass die Datenbanktabellen angelegt und mit
Beispieldaten gefüllt werden können.
Continue to the next step
-------------

Continue... (Result similar)
Continue... (Result similar)
Continue...

Result (this time title translated, but not the text):
-----------
MARC-Format auswählen

MARC stands for Machine Readable Cataloging. A MARC record contains
bibliographic information about an item. MARC21 is used globally, whereas
UNIMARC tends to be used in Europe.

Marc21

Continue to the next step
------------

Continue...
Result:
-----------
Web installer › Selecting default settings
MARC-Frameworks: MARC21
Mandatory

Select none (but toggles to 'Alle auswählen'
(...)
Text at the end in English: 'When you've made aour selections....
Import

Result:
------------
(...)
Optional Daten hinzugefügt (first word English)
Mandatory Daten hinzugefügt (same)
At the end:

Basic installation complete.

In the next steps you will be guided through some basic requirements like
defining Koha user with all administrative privileges (superlibrarian).
Sie können die Koha Community unterstützen, indem Sie Ihre Nutzungsdaten
teilen.

If you wish to share some of your data, please enable the functionality in the
"Share your usage statistics" section of the Administration module.

Set up some of Koha's basic requirements

------------
Then:
------------
Web installer › Installation complete
Gratulation, die Installation ist abgeschlossen

If this page does not redirect in 10 seconds, start onboarding process.
------------

Then in forms:
Only field labels are translated, but not h3 tiltes and text

For the first time, button is translated ('Bestätigen')

Then:
Web installer › Create a new circulation rule
Administrator account created!
Form fields translated

Then finally:
-----------
Web installer › Complete
Ausleihregel erstellt!
Congratulations you have finished and are ready to use Koha
Koha nun benutzen
-----------

More findings:
- Some of the strings are not picked for translation (are not in the po files)
- Some of the strings are in the po files, but seem not to be applied while
installing

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Web installer 17.05 not properly translatable

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Web installer 17.05 not properly translatable

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

--- Comment #1 from Marc Véron <[hidden email]> ---
For the titles, we have (e.g step1.tt):

<title>Koha &rsaquo; Web installer &rsaquo;
    [% UNLESS ( language ) %] Choose your language [% END %]
    [% IF ( language ) %]
        [% UNLESS ( checkmodule ) %]
            [% IF ( missing_modules ) %]
                Perl modules missing
            [% END %]
            [% IF ( problems ) %]
                Perl version obsolete
            [% END %]
        [% END %]
        Check Perl dependencies
    [% END %]
</title>

We are inside HTMLtags, that's wrong:
https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Web installer 17.05 not properly translatable

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

--- Comment #2 from Marc Véron <[hidden email]> ---
Created attachment 63573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63573&action=edit
Bug 18629 - Web installer 17.05 not properly translatable

Fix for step1.tt

Work in progress. Comments welcome.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Web installer 17.05 not properly translatable

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #3 from Marc Véron <[hidden email]> ---
Setting to 'Needs Signoff' for the changes in step1.tt

To test:
- Create po files
- Verify that title and button text are picked by translator and appear in po
file

For other issues: Could it be that there were string changes since latest
translations were uploaded to translate.koha-community.com ?

BTW: Will bi back in about 8 hours

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Web installer 17.05 not properly translatable

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #4 from Marc Véron <[hidden email]> ---
Found some more issues...

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Web installer 17.05 not properly translatable

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63573|0                           |1
        is obsolete|                            |

--- Comment #5 from Marc Véron <[hidden email]> ---
Created attachment 63679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63679&action=edit
Bug 18629 - Web installer 17.05 not properly translatable

Fix for step1.tt

To test:
- Create po files
- Verify that title and button text are picked by translator and appear in po
file
- Verify that text in po files is not fragmented

Work in progress. Comments welcome.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Web installer 17.05 not properly translatable

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63679|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Web installer 17.05 not     |Translatability: Fix
                   |properly translatable       |problems with web installer
                   |                            |17.05
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18665


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665
[Bug 18665] Translatability: Add tt filter to allow html tags inside tt
directives
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal

--- Comment #6 from Marc Véron <[hidden email]> ---
The new web installer for 17.05 has a great new design - but it has a lot of
translatability issues. Some strings are not picked for translations, some
expose the content of tt directives, and others are splitted by html tags,
resulting in small text fragments that are not easy to translate. The result in
translations is much less than ideal, and it makes a bad impression not only
for new Koha users or for libraries interested in Koha.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

--- Comment #7 from Marc Véron <[hidden email]> ---
Created attachment 63741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63741&action=edit
Bug 18629 - Translatability: Fix problems with web installer 17.05

The new web installer for 17.05 has a great new design - but it has a lot of
translatability issues. Some strings are not picked for translations,
some expose the content of tt directives, and others are splitted by
html tags, resulting in small text fragments that are not easy to translate.

This patch weeds out such translation problems for step1.tt, step2.tt and
step3.tt

To test:
- Apply patch (on top of Bug 18665 because of html tags inside of
  tt directives in step2.tt)
- Prepare a fresh install (drop database, create database)
- Walk through the installation process and verify that it works as before
- Verify that string changes (in English) make sense
- Create a translation( cd misc/translator, then perl translate create aa-AA)
  then: vim po/aa-AA-staff-prog.po and search for: /installer\/step
  Verify that strings for step1.tt, step2.tt, step3.tt are not fragmented,
  do not contain [%%, and are easily translatable (make sense without having
  to search in source files for context).

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63741|0                           |1
        is obsolete|                            |

--- Comment #8 from Marc Véron <[hidden email]> ---
Created attachment 63742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63742&action=edit
Bug 18629 - Translatability: Fix problems with web installer 17.05

The new web installer for 17.05 has a great new design - but it has a lot of
translatability issues. Some strings are not picked for translations,
some expose the content of tt directives, and others are splitted by
html tags, resulting in small text fragments that are not easy to translate.

This patch weeds out such translation problems for step1.tt, step2.tt and
step3.tt

To test:
- Apply patch (on top of Bug 18665 because of html tags inside of
  tt directives in step2.tt)
- Prepare a fresh install (drop database, create database)
- Walk through the installation process and verify that it works as before
- Verify that string changes (in English) make sense
- Create a translation( cd misc/translator, then perl translate create aa-AA)
  then: vim po/aa-AA-staff-prog.po and search for: /installer\/step
  Verify that strings for step1.tt, step2.tt, step3.tt are not fragmented,
  do not contain [%%, and are easily translatable (make sense without having
  to search in source files for context).

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Fix translatability issues
      release notes|                            |with web installer.
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17942

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63742|0                           |1
        is obsolete|                            |

--- Comment #9 from Marc Véron <[hidden email]> ---
Created attachment 63759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63759&action=edit
Bug 18629 - Translatability: Fix problems with web installer 17.05

The new web installer for 17.05 has a great new design - but it has a lot of
translatability issues. Some strings are not picked for translations,
some expose the content of tt directives, and others are splitted by
html tags, resulting in small text fragments that are not easy to translate.

This patch weeds out such translation problems for step1.tt, step2.tt and
step3.tt

To test:
- Apply patch (on top of Bug 18665 because of html tags inside of
  tt directives in step2.tt)
- Prepare a fresh install (drop database, create database)
- Walk through the installation process and verify that it works as before
- Verify that string changes (in English) make sense
- Create a translation( cd misc/translator, then perl translate create aa-AA)
  then: vim po/aa-AA-staff-prog.po and search for: /installer\/step
  Verify that strings for step1.tt, step2.tt, step3.tt are not fragmented,
  do not contain [%%, and are easily translatable (make sense without having
  to search in source files for context).

(Amended to remove some superfluous chomps 2017-06-27 mv)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #10 from Alex Buckley <[hidden email]> ---
Hi Marc

When running
perl translate create aa-AA I keep getting:

>Warning: Can't determine original templates' charset, defaulting to UTF-8
>Warning: Charset Out defaulting to UTF-8
>Removing empty file /home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po
>I UTF-8 O UTF-8 at /home/vagrant/kohaclone/misc/translator/tmpl_process3.pl line 345.
>msgmerge: error while opening "/home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po" for reading: No such file or directory

The equivalent output happens for all of the other aa-AA files.

Do you have any ideas as to why this may be happening? as I cannot find any
useful answers online

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

--- Comment #11 from Marc Véron <[hidden email]> ---
(In reply to Alex Buckley from comment #10)

> Hi Marc
>
> When running
> perl translate create aa-AA I keep getting:
>
> >Warning: Can't determine original templates' charset, defaulting to UTF-8
> >Warning: Charset Out defaulting to UTF-8
> >Removing empty file /home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po
> >I UTF-8 O UTF-8 at /home/vagrant/kohaclone/misc/translator/tmpl_process3.pl line 345.
> >msgmerge: error while opening "/home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po" for reading: No such file or directory
>
> The equivalent output happens for all of the other aa-AA files.
>
> Do you have any ideas as to why this may be happening? as I cannot find any
> useful answers online

On my vm, I do:
marc@debian8vm:~/koha/misc/translator$ perl translate create aa-AA
I get the same warnings about the charset and the message about revoming an
emty file
However I do not get the error about opening a file.
Does the folder /home/vagrant/kohaclone/misc/translator/po exist?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

--- Comment #12 from Alex Buckley <[hidden email]> ---
yes the folder /home/vagrant/kohaclone/misc/translator/po does exist

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

--- Comment #13 from Marc Véron <[hidden email]> ---
(In reply to Alex Buckley from comment #12)
> yes the folder /home/vagrant/kohaclone/misc/translator/po does exist

Maybe an issue with permissions?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

--- Comment #15 from Alex Buckley <[hidden email]> ---
Hi Marc

Thanks for the suggestions. So the permissions are fine with the po directory
having the following correct permissions:
drwxr-xr-x

Whilst I can install existing languages using the command:

sudo env KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml
PERL5LIB=/home/vagrant/kohaclone perl translate install fr-FR

To install French for example, which worked successfully

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

--- Comment #16 from Marc Véron <[hidden email]> ---
What happens if you do the following?

sudo env KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml
PERL5LIB=/home/vagrant/kohaclone perl translate create aa-AA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

--- Comment #17 from Alex Buckley <[hidden email]> ---
Ah brilliant thanks Marc

Although it is displaying the same output as before (see below) the files have
actually been created this time. Thanks very much I will test your patches now

>Warning: Can't determine original templates' charset, defaulting to UTF-8
>Warning: Charset Out defaulting to UTF-8
>Removing empty file /home/vagrant/kohaclone/misc/translator/po/aa-AA-staff-prog.po
>I UTF-8 O UTF-8 at /home/vagrant/kohaclone/misc/translator/tmpl_process3.pl line 345.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63759|0                           |1
        is obsolete|                            |

--- Comment #18 from Alex Buckley <[hidden email]> ---
Created attachment 63768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63768&action=edit
Bug 18629 - Translatability: Fix problems with web installer 17.05

The new web installer for 17.05 has a great new design - but it has a lot of
translatability issues. Some strings are not picked for translations,
some expose the content of tt directives, and others are splitted by
html tags, resulting in small text fragments that are not easy to translate.

This patch weeds out such translation problems for step1.tt, step2.tt and
step3.tt

To test:
- Apply patch (on top of Bug 18665 because of html tags inside of
  tt directives in step2.tt)
- Prepare a fresh install (drop database, create database)
- Walk through the installation process and verify that it works as before
- Verify that string changes (in English) make sense
- Create a translation( cd misc/translator, then perl translate create aa-AA)
  then: vim po/aa-AA-staff-prog.po and search for: /installer\/step
  Verify that strings for step1.tt, step2.tt, step3.tt are not fragmented,
  do not contain [%%, and are easily translatable (make sense without having
  to search in source files for context).

(Amended to remove some superfluous chomps 2017-06-27 mv)

Followed test plan worked as intended
Signed-off-by: Alex Buckley <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18688


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688
[Bug 18688] Warnings about UTF-8 charset when creating a new language
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|18688                       |
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18688


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688
[Bug 18688] Warnings about UTF-8 charset when creating a new language
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #19 from Jonathan Druart <[hidden email]> ---
I do not understand how using txt_continue is helping translators:

Before the patch:
 msgid "Continue to the next step"

After the patch:
 msgid "%s %sContinue to the next step%s %s"

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18629] Translatability: Fix problems with web installer 17.05

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629

--- Comment #20 from Marc Véron <[hidden email]> ---
(In reply to Jonathan Druart from comment #19)
> I do not understand how using txt_continue is helping translators:
>
> Before the patch:
>  msgid "Continue to the next step"
>
> After the patch:
>  msgid "%s %sContinue to the next step%s %s"

My intention was to have repeating test at one place, but you are right, the
result in the po file is not what we want, and isolating with div tags does not
work here.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12