[Bug 18610] New: ElasticSearch indexing of facets needs to be updated for newer Catmandu versions

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18610] New: ElasticSearch indexing of facets needs to be updated for newer Catmandu versions

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610

            Bug ID: 18610
           Summary: ElasticSearch indexing of facets needs to be updated
                    for newer Catmandu versions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Searching
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

This is analogous to the problem on bug 18434 - in newer versions multiple
mappings overwrite each other if not set to append. Bug 18434 takes care of
main headings, facets need the same treatment and testing

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18434


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434
[Bug 18434] Elasticsearch indexing broken with newer catmandu version
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610

--- Comment #1 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 63480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63480&action=edit
Bug 18610: regression tests

This patch introduces tests fr K::SE::ES::Indexer::_convert_marc_to_json
to test the facets that get extracted from the sample record.

To test:
- Run
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t \
          t/db_dependent/Koha_Elasticsearch.t
=> FAIL: Test fails because only last field mapped for facetting is considered
(overwrite behaviour).

Sponsored-by: ByWater Solutions

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610

--- Comment #2 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 63481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63481&action=edit
Bug 18610: Make facet indexing append instead of overwrite so it works on newer
Catmandu

This patch makes get_fixer_rules add the $append string to the facets mapping
as we did for
bug 18434.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
t/db_dependent/Koha_Elasticsearch.t
=> FAIL: Tests fail!
- Apply this patch
- Run:
 k$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
t/db_dependent/Koha_Elasticsearch.t
=> SUCCESS: Tests are all green!
- Sign off :-D

Sponsored-by: ByWater Solutions

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]          |[hidden email]
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Tomás Cohen Arazi <[hidden email]> ---


*** This bug has been marked as a duplicate of bug 18434 ***

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18610] ElasticSearch indexing of facets needs to be updated for newer Catmandu versions

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18610
Bug 18610 depends on bug 18434, which changed state.

Bug 18434 Summary: Elasticsearch indexing broken with newer catmandu version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18434

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Loading...