[Bug 18527] New: Add a system preference to exclude renewals from the quick slip

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] New: Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

            Bug ID: 18527
           Summary: Add a system preference to exclude renewals from the
                    quick slip
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

Some libraries prefer to not show renewals on the day's circulations, printed
on the quick slip.

Propose to add a system preference to allow exclusion of these circulations
from the quick slip.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

--- Comment #1 from Liz Rea <[hidden email]> ---
Created attachment 64714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64714&action=edit
Bug 18527 - Add a system preference to exclude renewals from the quick slip

To test:

Set up your test case:

Issue 4 books to a borrower.
1 we leave alone, that's today's issue.
2 Renew one of them - that's today's renewal.
3 Back date the issue date on the third one, in the database. Do not renew it.
This is an issue not from today that has not been renewed.
4 Back date the issue date on the fourth, and set a renew date in the past in
the database. This is an issue not from today that has been renewed in the
past.

With the syspref ShowRenewalsQuickSlip set to "Show"
Print a quick slip for this borrower, you should see only issues 1 and 2.
3 and 4 should never appear on this slip.
This is the current behaviour of the quick slip, nothing should change.
This is also the default of the syspref.

With the syspref ShowRenewalsQuickSlip set to "Don't show"
Print a quick slip for this borrower, you should see only issue 1 (today's
issue)
Issues 2, 3, and 4 should not appear on this slip.
This is the new behaviour, and must be activated by changing the syspref.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |baptiste.wojtkowski@biblibr
                   |                            |e.com

--- Comment #2 from Baptiste <[hidden email]> ---
This works as expected, but:
1 - Shouldn't be the syspref setted by default to 0 (old behaviour)
2 - I think the file installer/data/mysql/atomicupdate/ is missing

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

Marc VĂ©ron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12355
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

--- Comment #3 from Liz Rea <[hidden email]> ---
Created attachment 64986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64986&action=edit
Bug 18527 - atomicupdate

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64714|0                           |1
        is obsolete|                            |

--- Comment #4 from Baptiste <[hidden email]> ---
Created attachment 64988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64988&action=edit
Bug 18527 - Add a system preference to exclude renewals from the quick slip

To test:

Set up your test case:

Issue 4 books to a borrower.
1 we leave alone, that's today's issue.
2 Renew one of them - that's today's renewal.
3 Back date the issue date on the third one, in the database. Do not renew it.
This is an issue not from today that has not been renewed.
4 Back date the issue date on the fourth, and set a renew date in the past in
the database. This is an issue not from today that has been renewed in the
past.

With the syspref ShowRenewalsQuickSlip set to "Show"
Print a quick slip for this borrower, you should see only issues 1 and 2.
3 and 4 should never appear on this slip.
This is the current behaviour of the quick slip, nothing should change.
This is also the default of the syspref.

With the syspref ShowRenewalsQuickSlip set to "Don't show"
Print a quick slip for this borrower, you should see only issue 1 (today's
issue)
Issues 2, 3, and 4 should not appear on this slip.
This is the new behaviour, and must be activated by changing the syspref.

Signed-off-by: Baptiste Wojtkowski <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64986|0                           |1
        is obsolete|                            |

--- Comment #5 from Baptiste <[hidden email]> ---
Created attachment 64989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64989&action=edit
Bug 18527: atomicupdate

Signed-off-by: Baptiste Wojtkowski <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Baptiste <[hidden email]> ---
Hi,
I re committed your patch atomic update, I don't know why it was inversed (the
patch wanted to delete from the code what you actually wrote).

However all work well, but I think the QA won't accept the default setting of
the syspref to 1.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

--- Comment #7 from Liz Rea <[hidden email]> ---
Showing renewals is the current behaviour, and is what the default is set to.

Thank you for fixing up the atomic update!

Cheers,
Liz

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17966

--- Comment #8 from Jonathan Druart <[hidden email]> ---
This is typically the kind of thing that will be easy to do using the TT syntax
(see bug 17966).
I am not in favour of adding a new pref for that.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |RESOLVED
         Resolution|---                         |WONTFIX

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #9 from Katrin Fischer <[hidden email]> ---
Can we document how this would work with TT?

Excluding the renewed ones = removing checkouts with last renewal today?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18527] Add a system preference to exclude renewals from the quick slip

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

--- Comment #10 from Jonathan Druart <[hidden email]> ---
(In reply to Katrin Fischer from comment #9)
> Can we document how this would work with TT?
>
> Excluding the renewed ones = removing checkouts with last renewal today?

Since you have Koha::Objects based objects and the power of TT, you can do
whatever you like.

Something like the following should achieve the same goal.

[% SET today_date = today | $KohaDates %
[% FOREACH checkout IN checkouts %]
    [% IF checkout.renewals %]
        This checkout has been renewed [% checkout.renewals %] times.
        [% SET last_renewal_date = checkout.lastreneweddate | $KohaDates %]
        [% IF today_date == last_renewal_date%]
            It has been renewed today!
        [% END %]
    [% ELSE %]
        This checkout has never been renewed.
    [% END %]
[% END %]

You can use today.substr instead of the the KohaDates filter if you prefer.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Loading...