[Bug 18421] New: Make Coce cover images available for staff search

classic Classic list List threaded Threaded
23 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] New: Make Coce cover images available for staff search

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

            Bug ID: 18421
           Summary: Make Coce cover images available for staff search
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

When turned on, Coce cover images appear in the OPAC only, not staff interface.
(Coce Cover images - settings in enhanced content.)

Desired setting would be like Amazon cover settings - the ability to turn on
Coce images for the OPAC and/or the staff interface separately.
Coce server needs Koha searches to populate it with cover image links. While it
is collecting them, images do not display on the first time search results. To
make them display would need a refresh or a programmed time delay and re-query
to the Coce server. This is not useful for public OPAC.
While the Coce server is being populated with links it is desirable to have
only the staff interface using Coce.
After a time, when the Coce server has accumulated a large collection of links,
it would then be turned on for public OPAC and used by both.

I have Koha 3.22.07, and am testing with the Bywater Coce server.
If this is under way or in more recent versions already, please comment.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Charles Farmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--- Comment #1 from Charles Farmer <[hidden email]> ---
> When turned on, Coce cover images appear in the OPAC only, not staff interface.
(Coce Cover images - settings in enhanced content.)
Desired setting would be like Amazon cover settings - the ability to turn on
Coce images for the OPAC and/or the staff interface separately.

There's a patch developed on our end that would offer just that: giving the
option to control Coce's behavior separately between OPAC and the staff
intranet.

I'll join it to this bug instead of creating a new one.

> Coce server needs Koha searches to populate it with cover image links. While it is collecting them, images do not display on the first time search results. To make them display would need a refresh or a programmed time delay and re-query to the Coce server. This is not useful for public OPAC.

This is false, from what I understand.

Coce is queried after the page is loaded, yes, but the results should be
dynamically appended to the page if images were found. What might've happened
on your end is multiple image providers returning empty results, which were in
turn cached by redis and given back every time you made a subsequent request.

In that case, it's more related to Coce's backend than Coce itself.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Charles Farmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
   Patch complexity|---                         |Small patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

--- Comment #2 from Charles Farmer <[hidden email]> ---
Created attachment 71322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71322&action=edit
Bug18421 - Add Coce to the staff intranet

TEST PLAN:
    1) Apply the patch with git-bz
    2) Run updatedatabase.pl
        2.1) Console output should confirm database modification
    3) Visit the 'Enhanced Content' tab of admin/syspref
        3.1) ressource is
/cgi-bin/koha/admin/preferences.pl?tab=enhanced_content
        3.2) You should see that the previous preference, Coce, is now
CoceOPAC,
             and that a new preference was added, CoceIntranet
    4) Activate CoceIntranet
    5) Do a search for a book for which you have a Coce cover
        5.1) The cover image url should now point to a provider you defined in
Coce
        5.2) Your Coce log should show a query
    6) Click on the book's name to visit the detail.pl page
        6.1) The book's cover should also be provided by Coce on that page

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Charles Farmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Charles Farmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

--- Comment #3 from Agnes Rivers-Moore <[hidden email]> ---
(In reply to Charles Farmer from comment #1)

> > When turned on, Coce cover images appear in the OPAC only, not staff interface.
> (Coce Cover images - settings in enhanced content.)
> Desired setting would be like Amazon cover settings - the ability to turn on
> Coce images for the OPAC and/or the staff interface separately.
>
> There's a patch developed on our end that would offer just that: giving the
> option to control Coce's behavior separately between OPAC and the staff
> intranet.
>
> I'll join it to this bug instead of creating a new one.
>
> > Coce server needs Koha searches to populate it with cover image links. While it is collecting them, images do not display on the first time search results. To make them display would need a refresh or a programmed time delay and re-query to the Coce server. This is not useful for public OPAC.
>
> This is false, from what I understand.
>
> Coce is queried after the page is loaded, yes, but the results should be
> dynamically appended to the page if images were found. What might've
> happened on your end is multiple image providers returning empty results,
> which were in turn cached by redis and given back every time you made a
> subsequent request.
>
> In that case, it's more related to Coce's backend than Coce itself.

I am very glad this is being addressed, thank you!

Re the behaviour - I found that none of the images would load when the search
was initially done. However, paging forward and then returning, or repeating
the search would load all the images (or almost all).
If the search had been done before, and was done again, then images loaded
right away in the search results, without needing a refresh.
This behaviour is not consistent with your description of how Coce & Koha is
expected to work - the images were not dynamically appended unless the page was
refreshed in some way.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

--- Comment #4 from Agnes Rivers-Moore <[hidden email]> ---
(In reply to Charles Farmer from comment #1)

> > When turned on, Coce cover images appear in the OPAC only, not staff interface.
> (Coce Cover images - settings in enhanced content.)
> Desired setting would be like Amazon cover settings - the ability to turn on
> Coce images for the OPAC and/or the staff interface separately.
>
> There's a patch developed on our end that would offer just that: giving the
> option to control Coce's behavior separately between OPAC and the staff
> intranet.
>
> I'll join it to this bug instead of creating a new one.
>
> > Coce server needs Koha searches to populate it with cover image links. While it is collecting them, images do not display on the first time search results. To make them display would need a refresh or a programmed time delay and re-query to the Coce server. This is not useful for public OPAC.
>
> This is false, from what I understand.
>
> Coce is queried after the page is loaded, yes, but the results should be
> dynamically appended to the page if images were found. What might've
> happened on your end is multiple image providers returning empty results,
> which were in turn cached by redis and given back every time you made a
> subsequent request.
>
> In that case, it's more related to Coce's backend than Coce itself.

I am very glad this is being addressed, thank you!

Re the behaviour - I found that none of the images would load when the search
was initially done. However, paging forward and then returning, or repeating
the search would load all the images (or almost all).
If the search had been done before, and was done again, then images loaded
right away in the search results, without needing a refresh.
This behaviour is not consistent with your description of how Coce & Koha is
expected to work - the images were not dynamically appended unless the page was
refreshed in some way.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

--- Comment #5 from Charles Farmer <[hidden email]> ---
Because of the variables involved in the deployment of Coce -- the koha
version, the nodejs version, whether passenger is used or not for clustering,
the communication with the in-memory cache behind, the webserver that might be
used to proxy to the app, etc. -- it can get finicky real quick.

Without detailed information about your particular setup, I would recommend
opening a new bug ticket, since you feel confident about the reproducibility of
this issue on your end. I'd be more than happy to look over your setup :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

--- Comment #6 from Agnes Rivers-Moore <[hidden email]> ---
I appreciate the response, many thanks. We are planning an upgrade in the next
few months - perhaps the behaviour will change after that.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Charles Farmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71322|0                           |1
        is obsolete|                            |

--- Comment #7 from Charles Farmer <[hidden email]> ---
Created attachment 71977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71977&action=edit
Bug18421 - Add Coce to the staff intranet

TEST PLAN:
    1) Apply the patch with git-bz
    2) Run updatedatabase.pl
        2.1) Console output should confirm database modification
    3) Visit the 'Enhanced Content' tab of admin/syspref
        3.1) ressource is
/cgi-bin/koha/admin/preferences.pl?tab=enhanced_content
        3.2) You should see that the previous preference, Coce, is now
CoceOPAC,
             and that a new preference was added, CoceIntranet
    4) Activate CoceIntranet
    5) Do a search for a book for which you have a Coce cover
        5.1) The cover image url should now point to a provider you defined in
Coce
        5.2) Your Coce log should show a query
    6) Click on the book's name to visit the detail.pl page
        6.1) The book's cover should also be provided by Coce on that page

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Brendan Gallagher <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Brendan Gallagher <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71977|0                           |1
        is obsolete|                            |

--- Comment #8 from Brendan Gallagher <[hidden email]> ---
Created attachment 72772
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72772&action=edit
Bug18421 - Add Coce to the staff intranet

TEST PLAN:
    1) Apply the patch with git-bz
    2) Run updatedatabase.pl
        2.1) Console output should confirm database modification
    3) Visit the 'Enhanced Content' tab of admin/syspref
        3.1) ressource is
/cgi-bin/koha/admin/preferences.pl?tab=enhanced_content
        3.2) You should see that the previous preference, Coce, is now
CoceOPAC,
             and that a new preference was added, CoceIntranet
    4) Activate CoceIntranet
    5) Do a search for a book for which you have a Coce cover
        5.1) The cover image url should now point to a provider you defined in
Coce
        5.2) Your Coce log should show a query
    6) Click on the book's name to visit the detail.pl page
        6.1) The book's cover should also be provided by Coce on that page

Signed-off-by: Brendan Gallagher <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Charles Farmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72772|0                           |1
        is obsolete|                            |

--- Comment #9 from Charles Farmer <[hidden email]> ---
Created attachment 73401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73401&action=edit
Bug18421 - Add Coce to the staff intranet

TEST PLAN:
    1) Apply the patch with git-bz
    2) Run updatedatabase.pl
        2.1) Console output should confirm database modification
    3) Visit the 'Enhanced Content' tab of admin/syspref
        3.1) ressource is
/cgi-bin/koha/admin/preferences.pl?tab=enhanced_content
        3.2) You should see that the previous preference, Coce, is now
CoceOPAC,
             and that a new preference was added, CoceIntranet
    4) Activate CoceIntranet
    5) Do a search for a book for which you have a Coce cover
        5.1) The cover image url should now point to a provider you defined in
Coce
        5.2) Your Coce log should show a query
    6) Click on the book's name to visit the detail.pl page
        6.1) The book's cover should also be provided by Coce on that page

Signed-off-by: Brendan Gallagher <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

--- Comment #10 from Charles Farmer <[hidden email]> ---
Rebased C4/Auth.pm over the latest master: conflict over an end-of-line comma.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

--- Comment #11 from Katrin Fischer <[hidden email]> ---
Comment on attachment 73401
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73401
Bug18421 - Add Coce to the staff intranet

Review of attachment 73401:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18421&attachment=73401)
-----------------------------------------------------------------

Hi,

I've added comments to the splinter review.

The database update doesn't look clean to me, please revise and take a look
here:
https://wiki.koha-community.org/wiki/Database_updates

::: C4/Auth.pm
@@ +504,5 @@
> +            useDischarge                                                               => C4::Context->preference('useDischarge'),
> +            KOHA_VERSION                                                               => C4::Context->preference('Version'),
> +            CoceIntranet                                                               => C4::Context->preference('CoceIntranet'),
> +            CoceProviders                                                              => C4::Context->preference('CoceProviders'),
> +            CoceHost                                                                   => C4::Context->preference('CoceHost'),

Please use the TT plugin for dealing with the preferences in the templates
instead, like it's already done for the OPAC.

::: installer/data/mysql/atomicupdate/bug_18421_add_coce_intranet.perl
@@ +1,4 @@
> +#! /usr/bin/perl
> +
> +use strict;
> +use warnings;

Please always use Modern::Perl instead.

@@ +2,5 @@
> +
> +use strict;
> +use warnings;
> +use C4::Context;
> +use Data::Dumper;

Should not be here.

@@ +20,5 @@
> +    $current_coce_pref = $rows->{Coce}->{value};
> +}
> +
> +# add two new systempreferences in order to have distinct behavior between intranet and OPAC
> +$dbh->do("INSERT INTO systempreferences (variable,value,options,explanation,type) VALUES

Please always use INSERT IGNORE when adding system preferences.

@@ +26,5 @@
> +        ('CoceOPAC','$current_coce_pref', NULL, 'If on, enables cover retrieval from the configured Coce server in the OPAC', 'YesNo')
> +        ;") or die "Impossible d\'executer cam5446_ajouter_coce_intranet: erreur lors de l'ajout des nouvelles prefs: ". $dbh->errstr . "\n";
> +$dbh->do("DELETE FROM systempreferences WHERE variable = 'Coce';")
> +    or die "Impossible d\'executer cam5446_ajouter_coce_intranet: erreur lors de la suppression de la préférence 'Coce': ". $dbh->errstr . "\n";
> +print "cam5446: Add Coce image cache to the staff intranet.\n";

Please use bugzilla bug numbers in your update message.

::: installer/data/mysql/sysprefs.sql
@@ +108,5 @@
>  ('CircControl','ItemHomeLibrary','PickupLibrary|PatronLibrary|ItemHomeLibrary','Specify the agency that controls the circulation and fines policy','Choice'),
>  ('CircSidebar','0',NULL,'Activate or deactivate the navigation sidebar on all Circulation pages','YesNo'),
>  ('ClaimsBccCopy','0','','Bcc the ClaimAcquisition and ClaimIssues alerts','YesNo'),
> +('CoceIntranet','0', NULL, 'If on, enables cover retrieval from the configured Coce server in the staff intranet', 'YesNo'),
> +('CoceOPAC','0', NULL, 'If on, enables cover retrieval from the configured Coce server in the OPAC', 'YesNo'),

Please always sort prefs alphabetically in this file.
Also to be consistent with other prefs, it would be good to switch that:
OpacCoce, IntranetCoce (see other prefs for examples: *AmazonCoverImages,
*NumbersPreferPhrase, ..)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Signed Off                  |Failed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Charles Farmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Charles Farmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73401|0                           |1
        is obsolete|                            |

--- Comment #12 from Charles Farmer <[hidden email]> ---
Created attachment 73495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73495&action=edit
Bug18421 - Add Coce to the staff intranet

TEST PLAN:
    1) Apply the patch with git-bz
    2) Run updatedatabase.pl
        2.1) Console output should confirm database modification
    3) Visit the 'Enhanced Content' tab of admin/syspref
        3.1) ressource is
/cgi-bin/koha/admin/preferences.pl?tab=enhanced_content
        3.2) You should see that the previous preference, Coce, is now
CoceOPAC,
             and that a new preference was added, CoceIntranet
    4) Activate CoceIntranet
    5) Do a search for a book for which you have a Coce cover
        5.1) The cover image url should now point to a provider you defined in
Coce
        5.2) Your Coce log should show a query
    6) Click on the book's name to visit the detail.pl page
        6.1) The book's cover should also be provided by Coce on that page

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

--- Comment #13 from Charles Farmer <[hidden email]> ---
I've read your comments and applied them accordingly.

Only thing bothering me is the IGNORE. I don't know much about SQL, but aren't
we trying to avoid MySQLism? Is this something supported by other database
vendors?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

--- Comment #14 from Katrin Fischer <[hidden email]> ---
(In reply to Charles Farmer from comment #13)
> I've read your comments and applied them accordingly.
>
> Only thing bothering me is the IGNORE. I don't know much about SQL, but
> aren't we trying to avoid MySQLism? Is this something supported by other
> database vendors?

The updatedatabase file is mysql specific (it's even lives in a directory
called mysql...). But in general you are right of course.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

Charles Farmer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73495|0                           |1
        is obsolete|                            |

--- Comment #15 from Charles Farmer <[hidden email]> ---
Created attachment 74252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74252&action=edit
Bug18421 - Add Coce to the staff intranet

TEST PLAN:
    1) Apply the patch with git-bz
    2) Run updatedatabase.pl
        2.1) Console output should confirm database modification
    3) Visit the 'Enhanced Content' tab of admin/syspref
        3.1) ressource is
/cgi-bin/koha/admin/preferences.pl?tab=enhanced_content
        3.2) You should see that the previous preference, Coce, is now
CoceOPAC,
             and that a new preference was added, CoceIntranet
    4) Activate CoceIntranet
    5) Do a search for a book for which you have a Coce cover
        5.1) The cover image url should now point to a provider you defined in
Coce
        5.2) Your Coce log should show a query
    6) Click on the book's name to visit the detail.pl page
        6.1) The book's cover should also be provided by Coce on that page

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18421] Make Coce cover images available for staff search

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421

--- Comment #16 from Katrin Fischer <[hidden email]> ---
Hi Charles, please always add a separate follow-up patch with changes requested
by QA and then switch back to 'signed off' if not requested otherwise. This way
you often don't need to go through the sign-off process again. But if you
change the initial patch like here, it's good to ask for a new sign-off as the
old one is basically 'invalid'.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/