[Bug 18292] New: t/db_dependent/Circulation.t Dubious, test returned 1 even if test ok

classic Classic list List threaded Threaded
40 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] New: t/db_dependent/Circulation.t Dubious, test returned 1 even if test ok

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

            Bug ID: 18292
           Summary: t/db_dependent/Circulation.t Dubious, test returned 1
                    even if test ok
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t Dubious, test returned 1 even if test ok

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Olli-Antti Kivilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
         Depends on|                            |12596
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596
[Bug 12596] Backdating returns with SpecifiyReturnDate causes fines for items
not overdue!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Olli-Antti Kivilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|t/db_dependent/Circulation. |t/db_dependent/Circulation.
                   |t Dubious, test returned 1  |t doesn't need to return 1;
                   |even if test ok             |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

--- Comment #1 from Olli-Antti Kivilahti <[hidden email]> ---
Created attachment 61196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61196&action=edit
Bug 18292 - t/db_dependent/Circulation.t doesn't need to return 1;

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

--- Comment #2 from Olli-Antti Kivilahti <[hidden email]> ---
Initially thought the test fails because of this when ran via prove, but it was
maybe something leaking between test cases.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Marc Véron <[hidden email]> ---
What about the tons of *.t files with 1; as last line?

git grep '^1;' -- *.t

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

--- Comment #4 from Olli-Antti Kivilahti <[hidden email]> ---
(In reply to Marc Véron from comment #3)
> What about the tons of *.t files with 1; as last line?
>
> git grep '^1;' -- *.t

This patch is just cosmetic and seems to have no impact on test results.

If I had a delete button for this issue I would delete this.
But as I don't, it is better to make some use of this ticket.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from M. Tompsett <[hidden email]> ---
(In reply to Marc Véron from comment #3)
> What about the tons of *.t files with 1; as last line?
>
> git grep '^1;' -- *.t

Comparing
git grep '^1;' -- *.t | wc
with
git grep -- *.t | wc

I believe 'tons' is an exaggeration. :)
This is a small patch. It doesn't hurt.

P.S.

for i in `git grep -l '^1;' -- *.t`; do git blame $i | tail -1 | cut -f2 -d'('
| cut -f1 -d2 | sed -e "s#\s*\$##g"; done | sort -u
Alex Sassmannshausen
A. Sassmannshausen
Charles Farmer
Emmanuele Somma
Galen Charlton
Jacek Ablewicz
Jared Camins-Esakov
Jonathan Druart
Kyle M Hall
Lari Taskula
Marcel de Rooy
Martin Renvoize
Paul Poulain
Ryan Higgins
Tomás Cohen Arazi

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

--- Comment #6 from M. Tompsett <[hidden email]> ---
(In reply to Olli-Antti Kivilahti from comment #4)
> This patch is just cosmetic and seems to have no impact on test results.

Actually, while generally true, I think a microscopic time gain would happen if
all of them were fixed. 1-2 less lines for 127ish out of 1000+ tests to load.
Who knows if any of them trigger paging in the OS while running. ;)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

--- Comment #7 from M. Tompsett <[hidden email]> ---
(In reply to M. Tompsett from comment #5)
> Ryan Higgins

P.P.S. 10ish years ago. I suspect all of these are cut and paste from early in
the project.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61196|0                           |1
        is obsolete|                            |

--- Comment #8 from M. Tompsett <[hidden email]> ---
Created attachment 64097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64097&action=edit
[SIGNED-OFF] Bug 18292 - t/db_dependent/Circulation.t doesn't need to return 1;

Signed-off-by: Mark Tompsett <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] t/db_dependent/Circulation.t doesn't need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64097|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <[hidden email]> ---
Created attachment 64109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64109&action=edit
Bug 18292 - t/db_dependent/Circulation.t doesn't need to return 1;

Signed-off-by: Mark Tompsett <[hidden email]>

Signed-off-by: Marcel de Rooy <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|t/db_dependent/Circulation. |Tests do not need to return
                   |t doesn't need to return 1; |1;
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org
           Assignee|[hidden email] |[hidden email]-c
                   |                            |ommunity.org
             Status|Passed QA                   |ASSIGNED

--- Comment #10 from Jonathan Druart <[hidden email]> ---
Same for me, no need to fix only 1 occurrence when there are 115 left and a
simple regex can get rid of all of them.
Patching is coming

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

--- Comment #11 from Jonathan Druart <[hidden email]> ---
Created attachment 64127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64127&action=edit
Bug 18292: Remove return 1 statements in tests

The test files do not need to return 1

Patch generated with:
perl -p -i -e "s/^1;\n//xsm" t/**/*.t

Test plan:
  git grep '^1;$' t/**/*.t
should not return any results

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #12 from Alex Buckley <[hidden email]> ---
Hi Jonathan

Can you please merge your patches with master as they will not apply
successfully, with the below error message being thrown:

Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/www/search_utf8.t
Auto-merging t/db_dependent/www/history.t
Auto-merging t/db_dependent/www/batch.t
Auto-merging t/db_dependent/Utils/Datatables_Members.t
CONFLICT (content): Merge conflict in t/db_dependent/Utils/Datatables_Members.t
Auto-merging t/db_dependent/Serials/ReNewSubscription.t
Auto-merging t/db_dependent/Search.t
Auto-merging t/db_dependent/Reserves/MultiplePerRecord.t
Auto-merging t/db_dependent/Patron/Borrower_PrevCheckout.t
Auto-merging t/db_dependent/Patron/Borrower_Discharge.t
Auto-merging t/db_dependent/Members/IssueSlip.t
Auto-merging t/db_dependent/Members/GetPendingIssues.t
Auto-merging t/db_dependent/Members/GetAllIssues.t
Auto-merging t/db_dependent/Koha_Elasticsearch_Indexer.t
CONFLICT (content): Merge conflict in
t/db_dependent/Koha_Elasticsearch_Indexer.t
Auto-merging t/db_dependent/Koha/Patrons.t
Auto-merging t/db_dependent/Koha/Objects.t
Auto-merging t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
Auto-merging t/db_dependent/Circulation/Returns.t
Auto-merging t/db_dependent/Circulation/IsItemIssued.t
Auto-merging t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
Auto-merging t/db_dependent/Circulation/CheckIfIssuedToPatron.t
Auto-merging t/db_dependent/Circulation/Branch.t
Auto-merging t/Charset.t
CONFLICT (content): Merge conflict in t/Charset.t
Failed to merge in the changes.
Patch failed at 0001 Bug 18292: Remove return 1 statements in tests
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-18292-Remove-return-1-statements-in-tests-GqX5DD.patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64127|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart <[hidden email]> ---
Created attachment 65554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65554&action=edit
Bug 18292: Remove return 1 statements in tests

The test files do not need to return 1

Patch generated with:
perl -p -i -e "s/^1;\n//xsm" t/**/*.t

Test plan:
  git grep '^1;$' t/**/*.t
should not return any results

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Failed QA

--- Comment #14 from Katrin Fischer <[hidden email]> ---
I've found a problem in Charset.t:

ok 16 - nsb_clean removes � and �
# Subtest: SetMarcUnicodeFlag
    1..2
    # No tests run!
not ok 17 - No tests run for subtest "SetMarcUnicodeFlag"
#   Failed test 'No tests run for subtest "SetMarcUnicodeFlag"'
#   at t/Charset.t line 95.
Undefined subroutine &t::lib::Mocks::mock_preference called at t/Charset.t line
83.
# Looks like your test exited with 255 just after 17.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65554|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart <[hidden email]> ---
Created attachment 65709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65709&action=edit
Bug 18292: Remove return 1 statements in tests

The test files do not need to return 1

Patch generated with:
perl -p -i -e "s/^1;\n//xsm" t/**/*.t

Test plan:
  git grep '^1;$' t/**/*.t
should not return any results

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64109|0                           |1
        is obsolete|                            |

--- Comment #16 from M. Tompsett <[hidden email]> ---
Created attachment 65763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65763&action=edit
Bug 18292 - t/db_dependent/Circulation.t doesn't need to return 1;

Signed-off-by: Marcel de Rooy <[hidden email]>

Signed-off-by: Mark Tompsett <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65709|0                           |1
        is obsolete|                            |

--- Comment #17 from M. Tompsett <[hidden email]> ---
Created attachment 65764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65764&action=edit
Bug 18292: Remove return 1 statements in tests

The test files do not need to return 1

Patch generated with:
perl -p -i -e "s/^1;\n//xsm" t/**/*.t

Test plan:
  git grep '^1;$' t/**/*.t
should not return any results

NOTE: does not fix C4/SIP/t, nor xt tests.

Signed-off-by: Mark Tompsett <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

--- Comment #18 from Jonathan Druart <[hidden email]> ---
Created attachment 65766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65766&action=edit
Bug 18292: Tests do not need to return 1 - xt

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65766|0                           |1
        is obsolete|                            |

--- Comment #19 from M. Tompsett <[hidden email]> ---
Created attachment 65768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65768&action=edit
Bug 18292: Tests do not need to return 1 - xt

Signed-off-by: Mark Tompsett <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18292] Tests do not need to return 1;

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18292

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|[hidden email]-communit |[hidden email]
                   |y.org                       |
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12