[Bug 18267] New: Update price and tax fields in EDI to reflect DB changes

classic Classic list List threaded Threaded
22 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] New: Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

            Bug ID: 18267
           Summary: Update price and tax fields in EDI to reflect DB
                    changes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

The aqorders price and tax fields were renamed/ added to in bug 13321 but the
changes were not propagated to EDI.pm which is still creating orders with the
prices in the old fields. Update the fields used and check the correct Edifact
elements are being assigned

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |colin.campbell@ptfs-europe.
                   |ity.org                     |com
                 CC|                            |martin.renvoize@ptfs-europe
                   |                            |.com

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #1 from Colin Campbell <[hidden email]> ---
Created attachment 61600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61600&action=edit
Proposed patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #2 from Colin Campbell <[hidden email]> ---
Created attachment 61601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61601&action=edit
Proposed patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #3 from Colin Campbell <[hidden email]> ---
Created attachment 61602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61602&action=edit
Proposed patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Colin Campbell <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #4 from Colin Campbell <[hidden email]> ---
Patches should apply to both master and 16.11.x

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Colin Campbell <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61602|0                           |1
        is obsolete|                            |

--- Comment #5 from Colin Campbell <[hidden email]> ---
Created attachment 61605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61605&action=edit
proposed patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #6 from Colin Campbell <[hidden email]> ---
Created attachment 61606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61606&action=edit
proposed patch

Add test for new method added to line

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Barry Cannon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |[hidden email]

--- Comment #7 from Barry Cannon <[hidden email]> ---
Applied to customer instance and confirmed working.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
         QA Contact|[hidden email]-communit |[hidden email]
                   |y.org                       |
                 CC|                            |[hidden email]

--- Comment #8 from Nick Clemens <[hidden email]> ---
Marking as bug, asking Kyle to look as he is working with EDI

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Signed Off                  |Failed QA

--- Comment #9 from Marcel de Rooy <[hidden email]> ---
Code looks good at first glance.

But we are missing unit tests here. Sub process_invoice is changed in this
patch set and sub update_price_from_invoice is added. Although it seems to be a
private sub and could have been marked as such with an underscore.

Apart from missing tests for the complete Koha/EDI.pm module, the patches do
not have any test plans.

I understand that it takes time to write unit tests, but if we keep passing by
exception, they will not be written.

Minor detail: The four titles "Proposed patch" do not really convey much
information. We miss signoff lines.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Colin Campbell <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61600|0                           |1
        is obsolete|                            |

--- Comment #10 from Colin Campbell <[hidden email]> ---
Created attachment 65244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65244&action=edit
Fix unexported interface to Acq routine

routine is meant to be a standard interfacre but is not exported

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Colin Campbell <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61601|0                           |1
        is obsolete|                            |
  Attachment #61605|0                           |1
        is obsolete|                            |
  Attachment #61606|0                           |1
        is obsolete|                            |

--- Comment #11 from Colin Campbell <[hidden email]> ---
Created attachment 65245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65245&action=edit
patch to populate price fields using new methods

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #12 from Colin Campbell <[hidden email]> ---
Created attachment 65246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65246&action=edit
patch to populate price fields using new methods (16.11 version)

main patch uses newer interface to borrowers which is not available before
17.05 this uses the direct dbix interface as previously

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #13 from Colin Campbell <[hidden email]> ---
Created attachment 65250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65250&action=edit
Remove dead code - price method replaced by more specific methods

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #14 from Colin Campbell <[hidden email]> ---
Created attachment 65251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65251&action=edit
Record tax rate from the invoice

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #15 from Colin Campbell <[hidden email]> ---
Created attachment 65252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65252&action=edit
Unit Tests for tax-rate

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #16 from Colin Campbell <[hidden email]> ---
Created attachment 65253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65253&action=edit
Unit tests for price methods

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

--- Comment #17 from Colin Campbell <[hidden email]> ---
Created attachment 65254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65254&action=edit
Update doc for changed methods

perldoc was for old methods update to reflect the new ones

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Colin Campbell <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 18267] Update price and tax fields in EDI to reflect DB changes

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

David Bourgault <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #18 from David Bourgault <[hidden email]> ---
Both test files pass without an issue, but without a test plan I have no idea
how to test the feature.

Also I don't think this needed to be 8 patches, it just makes it more confusing
IMHO.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/