[Bug 18226] New: Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

classic Classic list List threaded Threaded
50 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] New: Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

            Bug ID: 18226
           Summary: Remove "use Test::DBIx::Class" instantiations'
                    dangerous code duplication
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

Everywhere where Test::DBIx::Class is used, a following blob of code follows:

use Test::DBIx::Class {
    schema_class => 'Koha::Schema',
    connect_info => ['dbi:SQLite:dbname=:memory:','',''],
    connect_opts => { name_sep => '.', quote_char => '`', },
    fixture_class => '::Populate',
}, 'SocialData', 'Biblioitem' ;


Instead of duplicating this same code everywhere, use a default configuration
for a Test::DBIx::Class in t/etc/schema.pl

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

--- Comment #1 from Olli-Antti Kivilahti <[hidden email]> ---
Created attachment 60885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60885&action=edit
Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication

Is 'instantiations' even a word?

Use a Test::DBIx::Class defaults instead.

Save your keyboard and prevent horrible bugs from emerging from rampant code
duplication.

This change doesn't seem to have any impact on the speed of executing those
tests.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Olli-Antti Kivilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18089


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18089
[Bug 18089] All XSLT testing singleBranchMode = 0 fails to show even if install
has only 1 branch
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Olli-Antti Kivilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Olli-Antti Kivilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14778


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778
[Bug 14778] DBIC should create/own the DB handler
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

--- Comment #2 from Olli-Antti Kivilahti <[hidden email]> ---
Created attachment 60886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60886&action=edit
Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication. Replace mock_dbh 1

t/00-load.t already checks if all of the perl modules can be compiled.

The tests deleted in this commit do a duplicate test with t/00-load.t
Hence they have become unnecessary.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

--- Comment #3 from Olli-Antti Kivilahti <[hidden email]> ---
t/db_dependent/Circulation/CalcDateDue.t fails with date calculus. SQLite is
peculiar with date calculus.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

--- Comment #4 from Olli-Antti Kivilahti <[hidden email]> ---
Created attachment 60920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60920&action=edit
Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication. Replace mock_dbh 2

Couldn't make the tests pass using Test::DBIx::Class, so reverted to the "usual
way" since these tests are
in db_dependent anyway.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Olli-Antti Kivilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18231

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Olli-Antti Kivilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60885|0                           |1
        is obsolete|                            |

--- Comment #5 from Olli-Antti Kivilahti <[hidden email]> ---
Created attachment 60923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60923&action=edit
Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication

Is 'instantiations' even a word?

Use a Test::DBIx::Class defaults instead.

Save your keyboard and prevent horrible bugs from emerging from rampant code
duplication.

This change doesn't seem to have any impact on the speed of executing those
tests.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Olli-Antti Kivilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18285, 18286


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285
[Bug 18285] Koha::Database schema cache accessors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286
[Bug 18286] Test::DBIx::Class connection/schema is shadowed by a cached
connection/schema
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Olli-Antti Kivilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18287


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287
[Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Olli-Antti Kivilahti <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18288


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288
[Bug 18288] Fix t/SocialData.t having a Test::DBIx::Class cache issue
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

--- Comment #6 from Olli-Antti Kivilahti <[hidden email]> ---
See the blocked list of Bugs for more individual test fixes.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #7 from Jonathan Druart <[hidden email]> ---
% git log --oneline

619aa5f Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous
code duplication. Replace mock_dbh 2
5fb9461 Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous
code duplication. Replace mock_dbh 1
5875738 Bug 18286 - Test::DBIx::Class connection/schema is shadowed by a cached
connection/schema
8814c10 Bug 18285 - Koha::Database schema cache accessors

Last patch from this bug does not apply:

t/Members/cardnumber.t .. # Can't initialize a schema with the given
configuration
# Returned Error: `' is not a module name
# configuration: {
#   'fixture_sets' => {}
# }

% pmvers Test::DBIx::Class
0.52

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

--- Comment #8 from Jonathan Druart <[hidden email]> ---


% git log --oneline

619aa5f Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous
code duplication. Replace mock_dbh 2
5fb9461 Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous
code duplication. Replace mock_dbh 1
5875738 Bug 18286 - Test::DBIx::Class connection/schema is shadowed by a cached
connection/schema
8814c10 Bug 18285 - Koha::Database schema cache accessors

Last patch from this bug does not apply!

% prove t/Members/cardnumber.
t/Members/cardnumber.t .. # Can't initialize a schema with the given
configuration
# Returned Error: `' is not a module name
# configuration: {
#   'fixture_sets' => {}
# }
...

% pmvers Test::DBIx::Class
0.52

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Marc VĂ©ron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18289


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18289
[Bug 18289] Fix t/Prices.t having a Test::DBIx::Class cache issue
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Mason James <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #9 from Josef Moravec <[hidden email]> ---
does not apply on top of 18285 and 18286

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18445

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #10 from Marcel de Rooy <[hidden email]> ---
Applying: Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous
code duplication
fatal: sha1 information is lacking or useless (t/Calendar.t).

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60886|0                           |1
        is obsolete|                            |
  Attachment #60920|0                           |1
        is obsolete|                            |
  Attachment #60923|0                           |1
        is obsolete|                            |

--- Comment #11 from Marcel de Rooy <[hidden email]> ---
Created attachment 62960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62960&action=edit
Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication. Replace mock_dbh 1

t/00-load.t already checks if all of the perl modules can be compiled.

The tests deleted in this commit do a duplicate test with t/00-load.t
Hence they have become unnecessary.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

--- Comment #12 from Marcel de Rooy <[hidden email]> ---
Created attachment 62961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62961&action=edit
Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication. Replace mock_dbh 2

Couldn't make the tests pass using Test::DBIx::Class, so reverted to the "usual
way" since these tests are
in db_dependent anyway.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

--- Comment #13 from Marcel de Rooy <[hidden email]> ---
Created attachment 62962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62962&action=edit
Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication

Is 'instantiations' even a word?

Use a Test::DBIx::Class defaults instead.

Save your keyboard and prevent horrible bugs from emerging from rampant code
duplication.

This change doesn't seem to have any impact on the speed of executing those
tests.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
           Assignee|[hidden email]          |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62960|0                           |1
        is obsolete|                            |

--- Comment #14 from Marcel de Rooy <[hidden email]> ---
Created attachment 62968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62968&action=edit
Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication. Replace mock_dbh 1

t/00-load.t already checks if all of the perl modules can be compiled.

The tests deleted in this commit do a duplicate test with t/00-load.t
Hence they have become unnecessary.

Signed-off-by: Marcel de Rooy <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62961|0                           |1
        is obsolete|                            |

--- Comment #15 from Marcel de Rooy <[hidden email]> ---
Created attachment 62969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62969&action=edit
Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication. Replace mock_dbh 2

Couldn't make the tests pass using Test::DBIx::Class, so reverted to the "usual
way" since these tests are
in db_dependent anyway.

Signed-off-by: Marcel de Rooy <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62962|0                           |1
        is obsolete|                            |

--- Comment #16 from Marcel de Rooy <[hidden email]> ---
Created attachment 62970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62970&action=edit
Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication

Is 'instantiations' even a word?

Use a Test::DBIx::Class defaults instead.

Save your keyboard and prevent horrible bugs from emerging from rampant code
duplication.

This change doesn't seem to have any impact on the speed of executing those
tests.

Signed-off-by: Marcel de Rooy <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

--- Comment #17 from Marcel de Rooy <[hidden email]> ---
Moved the t/etc/schema to an earlier report.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12
Loading...