Quantcast

[Bug 18110] New: Adds FR to the syspref AddressFormat

classic Classic list List threaded Threaded
60 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] New: Adds FR to the syspref AddressFormat

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

            Bug ID: 18110
           Summary: Adds FR to the syspref AddressFormat
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #1 from Baptiste <[hidden email]> ---
Created attachment 60176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60176&action=edit
Add a field FR to the syspref AddressFormat

Testplan
1 - Apply
2 - Check there is a field FR in the syspref AddressFormat

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |baptiste.wojtkowski@biblibr
                   |ity.org                     |e.com

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60176|0                           |1
        is obsolete|                            |

--- Comment #2 from Baptiste <[hidden email]> ---
Created attachment 60214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60214&action=edit
Add a field FR to the syspref AddressFormat

Testplan
1 - Apply
2 - Check there is a field FR in the syspref AddressFormat

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60214|0                           |1
        is obsolete|                            |

--- Comment #3 from Baptiste <[hidden email]> ---
Created attachment 60215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60215&action=edit
Add a field FR to the syspref AddressFormat

Testplan
1 - Apply patch
2 - Check if there is a field FR in the syspref AddressFormat, enable it
3 - Create a new borrower and check the order of the fields for the address
4 - Check if it's address appears in a propper manner

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Marc Véron <[hidden email]> ---
Hi Babtiste,
the patch adds a line
('LoadSearchHistoryToTheFirstLoggedUser',....
to installer/data/mysql/sysprefs.sql (Line 237)

It seems to me that it is not related to this Bug?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #5 from Baptiste <[hidden email]> ---
Created attachment 60426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60426&action=edit
BUG 18110 : Removed a wrong syspref from code

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #6 from Marc Véron <[hidden email]> ---
On the patron's detail page, street number goes on a separate line, something
like
11
rue de Bâle

instead of
11 rue de Bâle

I think the code should go inside the li element in
member-display-address-style-fr.inc (maybe at other places as well?)

You have something like:

[% IF streetnumber %] [% streetnumber %][% END %]
[%IF roadtype_desc %] [% roadtype_desc %][% END %]
<li class="patronaddress1">[% address %]
</li>

I think it should be something like:

<li class="patronaddress1">
    [% IF streetnumber %] [% streetnumber %][% END %]
    [%IF roadtype_desc %] [% roadtype_desc %][% END %]
    [% address %]
</li>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #7 from Baptiste <[hidden email]> ---
Hi,
Are you sure you tested the newest version of the patch ?
I remember I corrected at last a part of the problem

Could you try again and send me the exact test plan you applied to get this bug
?

I tried to make a new branch from master and apply the patch on a new branch :
I can't reproduce it.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #8 from Marc Véron <[hidden email]> ---
Created attachment 60657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60657&action=edit
Screenshot with patch

The streetnumber displays above the street (see screenshots at the left), I
would expect them on the same line.
4554 Library Rd.
instead of
4554
Library Rd.

Editing the main address (Link below "Gender") displays some stray HTML
(screenshots right).

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #9 from Baptiste <[hidden email]> ---
Hi !

Did you reapply the patch ?
I mean I can't reproduce your problem again, and I think I have corrected it,
and by reapplying it on the master I can't reproduce it again.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #10 from Marc Véron <[hidden email]> ---
Yes, I applied the patch.

I think it is in member-display-address-style-fr.inc:

The patch is as follows:
(...)
    [% IF ( address ) %]
        [% SET roadtype_desc = '' %]
        [% IF streettype %]
            [% SET roadtype_desc = AuthorisedValues.GetByCode('ROADTYPE',
streettype) %]
        [% END %]
        [% IF streetnumber %] [% streetnumber %][% END %]
        [%IF roadtype_desc %] [% roadtype_desc %][% END %]
        <li class="patronaddress1">[% address %]
       </li>
    [% END %]
(...)

If I change it to the following, the address displays OK:

(...)

    [% IF ( address ) %]
        [% SET roadtype_desc = '' %]
        [% IF streettype %]
            [% SET roadtype_desc = AuthorisedValues.GetByCode('ROADTYPE',
streettype) %]
        [% END %]

        <li class="patronaddress1">
            [% IF streetnumber %] [% streetnumber %][% END %]
            [%IF roadtype_desc %] [% roadtype_desc %][% END %]
            [% address %]
       </li>
    [% END %]


(...)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #11 from Marc Véron <[hidden email]> ---
Additionally, member-main-address-style-fr.inc line 1 misses an opening < :

fieldset class="rows" id="memberentry_mainaddress">

instead of:

<fieldset class="rows" id="memberentry_mainaddress">

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #12 from Baptiste <[hidden email]> ---
Created attachment 60689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60689&action=edit
Bug 16034 - DBRev 16.12.00.010

Signed-off-by: Kyle M Hall <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |baptiste.wojtkowski@biblibr
                   |                            |e.com

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60689|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #13 from Baptiste <[hidden email]> ---
Created attachment 60690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60690&action=edit
BUG 18110 : Modified the adresses in order to fit the french standards

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60690|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #14 from Baptiste <[hidden email]> ---
Created attachment 60694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60694&action=edit
BUG 18110 : Correct display and syspref AddFormat

Add a field FR to the syspref AddressFormat

Testplan
1 - Apply patch
2 - Check if there is a field FR in the syspref AddressFormat, enable it
3 - Create a new borrower and check the order of the fields for the address
4 - Check if it's address appears in a propper manner

27/02/17 : Fixed the display

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60694|0                           |1
        is obsolete|                            |

--- Comment #15 from Baptiste <[hidden email]> ---
Created attachment 60695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60695&action=edit
BUG 18110 : Correct display and syspref AddFormat

Add a field FR to the syspref AddressFormat

Testplan
1 - Apply patch
2 - Check if there is a field FR in the syspref AddressFormat, enable it
3 - Create a new borrower and check the order of the fields for the address
4 - Check if it's address appears in a propper manner

27/02/17 : Fixed the display

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60426|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60215|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #16 from Marc Véron <[hidden email]> ---
I'm really sorry, but there is still a problem with
koha-tmpl/intranet-tmpl/prog/en/includes/member-display-address-style-fr.inc

The streetnumber still does not display on the same line as the address.

Your code reads (line 7 and following):

        <li>
        [% IF streetnumber %] [% streetnumber %][% END %]
        [%IF roadtype_desc %] [% roadtype_desc %][% END %]
        </li>
            <li class="patronaddress1">[% address %]
            </li>

It should be:

            <li class="patronaddress1">
                [% IF streetnumber %] [% streetnumber %][% END %]
                [%IF roadtype_desc %] [% roadtype_desc %][% END %]
                [% address %]
            </li>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #17 from Baptiste <[hidden email]> ---
Hi !
Do you think we should have everything printed on the same line ? I wasn't sure
it would we best way to display the address, but is ok, I'll change it again ;)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #18 from Marc Véron <[hidden email]> ---
Hi Baptiste,

Yes, I think that number, street and address should display on the same line.
See:

https://fr.wikipedia.org/wiki/Adresse_postale#Recommandations_de_La_Poste

(...) numéro dans la voie (éventuellement suivi d’un complément de numéro tel
bis, ter, quater, etc.), immédiatement suivi du type de voie (rue, avenue,
etc.) et du nom de celle-ci (...)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

jmbroust <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jean-manuel.broust@univ-lyo
                   |                            |n2.fr
             Status|Needs Signoff               |Failed QA

--- Comment #19 from jmbroust <[hidden email]> ---
There is a problem when b.streettype is used, address 1 :

1 -  is displayed on separate line at :
http://pro.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/circ/circulation.pl?borrowernumber=7020

http://pro.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/members/moremember.pl?borrowernumber=7020

Furthermore, streettype is not displayed at all on some pages :
For example :
http://pro.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/members/boraccount.pl?borrowernumber=7020

Other point : streetnumber nor streettype are not displayed here :
http://pro.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/members/member-password.pl?member=7020

but  I guess these should be filled in another bugzilla ticket).

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #20 from Baptiste <[hidden email]> ---
Created attachment 61610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61610&action=edit
BUG 18110: Corrected display address format

- minor changes on address format
- corrected member-password so that steetnumber is given to the template

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Baptiste <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #21 from Baptiste <[hidden email]> ---
I corrected the display of streetnumber in this ticket, I don't think it's
necessary to open a new ticket just for one code line.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 18110] Adds FR to the syspref AddressFormat

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #22 from Marc Véron <[hidden email]> ---
Hi Babtiste,

Changes work fine, but please have a look at Alternate address as well,
streetnumber is on a separate line and street type is after address.

See: member-display-alt-address-style-fr.inc

Marc

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12
Loading...