[Bug 17765] New: Hide 'Holds' link in staff result list when user has no permission to place holds

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 17765] New: Hide 'Holds' link in staff result list when user has no permission to place holds

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

            Bug ID: 17765
           Summary: Hide 'Holds' link in staff result list when user has
                    no permission to place holds
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff Client
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

The "Holds" link on the staff result list is still visible, even if the  user
has no "reserveforothers" permission.

At the same time it's not possible to place a hold from the detail page and you
get a permission error when trying to use the link.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

--- Comment #1 from Zoe Bennett <[hidden email]> ---
Created attachment 70584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70584&action=edit
Bug 17765: Hid 'Holds' link on the 'Details' and 'Checkout' pages when the user
does not have the permission to 'reserveforothers'.

Test Plan:
1) With a user who has the permission to 'reserveforothers' check that the
'Holds' link is on the 'Details' and 'Check out' pages
2) Then with a user who does not have the permission to 'reserveforothers'
check that on the 'Details' and 'Check out' pages there is no longer the
'Holds' link next to the 'Checkouts' and 'Fines & Charges' tabs.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

--- Comment #2 from Owen Leonard <[hidden email]> ---
I'm not sure if this is ready for testing or not, but in it's current state it
doesn't work for me:

"my" variable $flags masks earlier declaration in same scope at
/home/vagrant/kohaclone/circ/circulation.pl line 464. Can't call method "flags"
on an undefined value at /home/vagrant/kohaclone/circ/circulation.pl line 179.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Zoe Bennett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

--- Comment #3 from Zoe Bennett <[hidden email]> ---
Created attachment 70662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70662&action=edit
Bug 17765: Changed variable $flags to $userflags to eliminate the issue of
masking declaration in the same scope. Hides 'Holds' link on the 'Details' and
'Checkout' pages when the user does not have the permission to
'reserveforothers'.

Test Plan:
1) With a user who has the permission to 'reserveforothers' check that the
'Holds' link is on the 'Details' and 'Check out' pages
2) Then with a user who does not have the permission to 'reserveforothers'
check that on the 'Details' and 'Check out' pages there is no longer the
'Holds' link next to the 'Checkouts' and 'Fines & Charges' tabs.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

--- Comment #4 from Katrin Fischer <[hidden email]> ---
Hi Zoe, small thing: I filed this for the result page - can you change the
title of the bug to match your changes and maybe file a new one for the result
list page if the problem still shows there? The titles of bugs are used for the
release notes, so it's always good to give a good description.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Séverine Queune <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Patch doesn't apply

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17765] Hide 'Holds' link in patron account in staff

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Hide 'Holds' link in staff  |Hide 'Holds' link in patron
                   |result list when user has   |account in staff
                   |no permission to place      |
                   |holds                       |
             Status|Patch doesn't apply         |In Discussion

--- Comment #5 from Katrin Fischer <[hidden email]> ---
I feel like the patches proposed here don't do the right thing. A staff patron
without place_holds should still be able to see information about existing
holds on the circ desk.
If people disagree, we should discuss how to achieve this without causing a
disruption for libraries, maybe using a new separate pref? Marking 'In
discussion' for now.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/