Quantcast

[Bug 17702] New: Create configuration for account types

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] New: Create configuration for account types

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

            Bug ID: 17702
           Summary: Create configuration for account types
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

As using the MANUAL_INV for defining fines is not ideal, I tried another
approach by defining the two new db tables for credit types and debit types
with own administration page.

Patch will be uploaded soon

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |
   Patch complexity|---                         |Small patch
             Status|NEW                         |ASSIGNED
             Blocks|                            |17596, 14825
                 CC|                            |[hidden email],
                   |                            |[hidden email]


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596
[Bug 17596] Simplify accounting UI in staff client
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

--- Comment #1 from Josef Moravec <[hidden email]> ---
Created attachment 57856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57856&action=edit
Bug 17702: Account types configuration - db changes

Test plan:
1) Read the diff and confirm that it does make sense
2) Comment what does not make sense ;)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

--- Comment #2 from Josef Moravec <[hidden email]> ---
Created attachment 57857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57857&action=edit
Bug 17702: Account types configuration - Manual invoice and credit

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

--- Comment #3 from Josef Moravec <[hidden email]> ---
Created attachment 57858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57858&action=edit
Bug 17702: Account types configuration - Admin page

Test plan:
1) Go to admin home, note there is new Account types page in Patrons and
circulation section
2) Go to any other admin page and confirm there is link to Account types
in admin menu as welll
3) Go to Account types page
4) You should see two datatables, one for debit types and one for
credit types, ensure the datatables are working corectly
5) Try to create, edit and delete some debit types, note, that some of
them can't be deleted - they are neede for Koha internally
6) Do the same with credit types
7) Try to add some default amount to internal debits - like Acccount
management fee, New card, ...
8) Go to Patron fines page and play with account type select, when you
change thy account type, the description and amount should change as you
set it on the admin page
9) Try to add some fees and ensure they are inserted corectly
10) Pay the inserted fees
11) Try to add manual credit and ensure it is added corectly

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

--- Comment #4 from Josef Moravec <[hidden email]> ---
I attached my current work, but stay with ASSIGNED status till I write tests ;)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

--- Comment #5 from Josef Moravec <[hidden email]> ---
Created attachment 58066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58066&action=edit
Bug 17702: Add tests

Test plan:
  prove t/db_dependent/Koha/AccountTypes.t

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

Chris Kirby <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris.kirby@ilsleypubliclib
                   |                            |rary.org

--- Comment #6 from Chris Kirby <[hidden email]> ---
Hi Josef,
When I tried to add a new debit type, I got the following error:
DBIx::Class::Storage::DBI::_dbh_execute(): Table
'koha_mykoha.account_debit_types' doesn't exist at
/home/ckirby/koha/Koha/Objects.pm line 83

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

--- Comment #7 from Josef Moravec <[hidden email]> ---
(In reply to Chris Kirby from comment #6)
> Hi Josef,
> When I tried to add a new debit type, I got the following error:
> DBIx::Class::Storage::DBI::_dbh_execute(): Table
> 'koha_mykoha.account_debit_types' doesn't exist at
> /home/ckirby/koha/Koha/Objects.pm line 83

Did you upgrade your db schema? I forget to mention it in test plan, sorry.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

--- Comment #8 from Chris Kirby <[hidden email]> ---

(In reply to comment #7),
Hi Josef, thanks for the tip to upgrade the db schema.

When one creates a "manual invoice" for a patron using one of the created debit
types, both the debit type code and the description are entered into the
"Description of charges." However, for the pre-existing debit types, the debit
type description is entered twice in the "description of charges".
Is there any reason for this difference?

When one creates a credit type, there is no field for default amount. Is there
any reason for leaving a default amount out of the credit type but keeping it
in the debit?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

--- Comment #9 from Radek Šiman (R-Bit Technology, s.r.o.) <[hidden email]> ---
(In reply to Josef Moravec from comment #1)
> Created attachment 57856 [details] [review]
> Bug 17702: Account types configuration - db changes
>
> Test plan:
> 1) Read the diff and confirm that it does make sense
> 2) Comment what does not make sense ;)

According to db changes, is it possible to extend type_code from only 5 chars
to (let's say) 10 chars? It would be very useful for some libraries having a
longer list of payments not to be so cryptic. For instance, one of them (Czech
only - sorry):
mvs     50|MVS
tA4     3|Tisk a kopie A4
t2sA4   4|Tisk a kopie A4 oboustranně
toA4    6|Tisk a kopie A4 + obrázek
tbA4    15|Celobarevná A4
t20A4   2|Tisk a kopie A4 nad 20 kusů
s20A4   3|Tisk a kopie A4 oboustranně nad 20 kusů
b20A4   10|Tisk a kopie A4 barevně nad 20 kusů
tA3     5|Tisk a kopie A3
t2sA3   7|Tisk a kopie A3 oboustranně
toA3    10|Tisk a kopie A3 + obrázek
tbA3    25|Celobarevná A3
t20A3   3|Tisk a kopie A3 nad 20 kusů
s20A3   5|Tisk a kopie A3 oboustranně nad 20 kusů
b20A3   20|Tisk a kopie A3 barevně nad 20 kusů
sken    7|skenování
eursl   3|eurosložka
papsl   5|papírová složka
taskm   3|taška malá
taskv   5|taška velká
prodj   ?|prodej
plack   ?|placky
eshop   ?|e-shop
poukaz  110|Poukaz na registraci
REZER   10|Rezervace (ručně)
pspec   2|Papír speciál

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

--- Comment #10 from Josef Moravec <[hidden email]> ---
(In reply to Chris Kirby from comment #8)
> (In reply to comment #7),
> Hi Josef, thanks for the tip to upgrade the db schema.
>
> When one creates a "manual invoice" for a patron using one of the created
> debit types, both the debit type code and the description are entered into
> the "Description of charges." However, for the pre-existing debit types, the
> debit type description is entered twice in the "description of charges".
> Is there any reason for this difference?

It's a bug, I am going to work on this a bit more...


> When one creates a credit type, there is no field for default amount. Is
> there any reason for leaving a default amount out of the credit type but
> keeping it in the debit?

Yes, the reason is, the when you are creating manual invoice, you often know
the price of some kind of things, but you can't pretend which amount are people
going to pay, or so...

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

--- Comment #11 from Josef Moravec <[hidden email]> ---
(In reply to Radek Šiman (R-Bit Technology, s.r.o.) from comment #9)

> (In reply to Josef Moravec from comment #1)
> > Created attachment 57856 [details] [review] [review]
> > Bug 17702: Account types configuration - db changes
> >
> > Test plan:
> > 1) Read the diff and confirm that it does make sense
> > 2) Comment what does not make sense ;)
>
> According to db changes, is it possible to extend type_code from only 5
> chars to (let's say) 10 chars? It would be very useful for some libraries
> having a longer list of payments not to be so cryptic. For instance, one of
> them (Czech only - sorry):

I have no problem with this.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17702] Create configuration for account types

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

Lisette <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Loading...