[Bug 17656] New: Irregularities in serial prediction pattern are planned only for the current year

classic Classic list List threaded Threaded
38 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] New: Irregularities in serial prediction pattern are planned only for the current year

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

            Bug ID: 17656
           Summary: Irregularities in serial prediction pattern are
                    planned only for the current year
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P2
         Component: Serials
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

When you se, through test prediction pattern, a serial pattern including
planned irregularities (for example a 1/month serial that you know there's no
issue on july), this is only valid fot the current subscription. Over the next
renewal, you will have to set it again which is very tedious.
We should be able to configure this in the long run (as it was possible in
previous version of Koha before 3.14, I think)

Olivier Crouzet

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for the current year

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Marjorie Barry-Vila <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |.ca

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|Irregularities in serial    |Irregularities in serial
                   |prediction pattern are      |prediction pattern are
                   |planned only for the        |planned only for current
                   |current year                |subscription

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #1 from Marcel de Rooy <[hidden email]> ---
The current irregularity feature works with saving internal fictive issue
numbers in a text field irregularity. If you edited/shifted some dates in
serial collection, you might be surprised what happens.
You cannot view the saved irregularities in serial collection (I only see e.g.
2 issues on the Planning tab); they are only visible when editing the
subscription and looking at the prediction pattern again.

Bug 18365 and friends made it easier to handle discrepancies in the schedule.
An occasional irregularity could be resolved that way.

Would it be useful to define recurring irregularities in terms of the serial
frequency chosen? If it is month, we could allow the user to select one or more
months to skip? Same for weeks or days. (Year seems less interesting.)
Doing this would replace selection of irregulars in the prediction pattern.

If so, how should we handle 'special' frequencies like 1 per 3 months or 3 per
month btw? Skip all in e.g. July or refine with skip second in July etc.?

It seems to me that we should make the irregularity info more visible to the
user too on Serial collection form.

Any feedback is appreciated.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Do we need recurring irregularities in Serials ?

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Irregularities in serial    |Do we need recurring
                   |prediction pattern are      |irregularities in Serials ?
                   |planned only for current    |
                   |subscription                |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Do we need recurring irregularities in Serials ?

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Katrin Fischer <[hidden email]> ---
I feel my expectation for this was always that it will be recurring. So say I
have a serial prediction pattern for 1/month and I say there is never an issue
in August (vacation?), I'd want this to stick. As I understood the feature, it
would allow to have patterns that are not 'regular' in some odd ways.

Like 50 issues a year, mostly weekly, where the time between issues is not
always the same, but some are just skipped.

Not sure if we could reach out to serial librarians on the mailing list maybe?

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Do we need recurring irregularities in Serials ?

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #3 from Marcel de Rooy <[hidden email]> ---
(In reply to Katrin Fischer from comment #2)
> Not sure if we could reach out to serial librarians on the mailing list
> maybe?

Sent to general ml.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Do we need recurring irregularities in Serials ?

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |francois.charbonnier@inlibr
                   |                            |o.com,
                   |                            |[hidden email]
                   |                            |, [hidden email]

--- Comment #4 from Katrin Fischer <[hidden email]> ---
We are looking for feedback on this one - adding some names to cc in hope of
more comments!

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Do we need recurring irregularities in Serials ?

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #5 from Katrin Fischer <[hidden email]> ---
Thread: https://lists.katipo.co.nz/pipermail/koha/2017-June/048380.html

Sadly no comments so far. So it's Lyon 3 and me so far considering this a bug,
maybe enough?

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Do we need recurring irregularities in Serials ?

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #6 from Marcel de Rooy <[hidden email]> ---
(In reply to Katrin Fischer from comment #5)
> Thread: https://lists.katipo.co.nz/pipermail/koha/2017-June/048380.html
>
> Sadly no comments so far. So it's Lyon 3 and me so far considering this a
> bug, maybe enough?

We can wait a little bit more :) Good things take time..
Hope to address this later, having some more feedback.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Do we need recurring irregularities in Serials ?

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Koha Team Lyon 3 <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Koha Team Lyon 3 <[hidden email]> ---
Hello Marcel,
I think it's a pity not to try to find a solution if we are several libraries
that miss this feature.
Furthermore, it existed in the previous versions of Koha and for us, it was
clearly  a regression when it disappeared.
If the solution proposed isn't correct, it will be Failed QA....

If you don't mind, I will change this bug title to the former one to give a
chance to this feature to be back in koha.

Sonia

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Koha Team Lyon 3 <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Do we need recurring        |Irregularities in serial
                   |irregularities in Serials ? |prediction pattern are
                   |                            |planned only for current
                   |                            |subscription

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #8 from Katrin Fischer <[hidden email]> ---
Hi Sonia,
it's good information that this is a regression to the older serials module. I
agree that we need to bring it back.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #9 from Alex Arnaud <[hidden email]> ---
Created attachment 68259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68259&action=edit
Bug 17656 - Keep irregularities during subscription renewals

When renewing a subscription, irregularities are lost. This patch
allows to keep them for monthly or daily serials ( 1 unit per issue
only).

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
    - From: 2017-10-09, To: 2017-10-15,
    - Frequency: 1/day,
    - 7 issues,
    - test prediction pattern
    - check Wednesday and Thursday as irregularity,
    - save
  - Edit subscription,
  - Check that Wednesday and Thursday are still checked
  - Renew subscription from 2017-10-16
  - Edit subscription,
  - Make sure that Wednesday and Thursday are still checked
    with corresponding serials

  - Do the same for a monthly subscription

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #10 from Alex Arnaud <[hidden email]> ---
Here is a proposal for keeping irregularities on subscription after renewal.
This patch save days of week or month in a new column (permanent_irregularity).
So it works only for daily and monthly subscriptions. I think that it doesn't
make sense to do this for weekly... you opinion?

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68259|0                           |1
        is obsolete|                            |

--- Comment #11 from Alex Arnaud <[hidden email]> ---
Created attachment 68261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68261&action=edit
Bug 17656 - Keep irregularities during subscription renewals

When renewing a subscription, irregularities are lost. This patch
allows to keep them for monthly or daily serials ( 1 unit per issue
only).

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
    - From: 2017-10-09, To: 2017-10-15,
    - Frequency: 1/day,
    - 7 issues,
    - test prediction pattern
    - check Wednesday and Thursday as irregularity,
    - save
  - Edit subscription,
  - Check that Wednesday and Thursday are still checked
  - Renew subscription from 2017-10-16
  - Edit subscription,
  - Make sure that Wednesday and Thursday are still checked
    with corresponding serials

  - Do the same for a monthly subscription

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Fridolin SOMERS <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
                 CC|                            |[hidden email]
                   |                            |m

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Failed QA

--- Comment #12 from Alex Buckley <[hidden email]> ---
Hi Alex

When checking if Wednesday and Thursday are still checked I have found that the
test prediction pattern div is no longer being displayed.

The errors I am getting in my intranet-error.log are:

0.0.2.2:34032] AH01215: [Fri Oct 20 00:20:18 2017] showpredictionpattern.pl:
Argument "month" isn't numeric in numeric eq (==) at
/home/vagrant/kohaclone/serials/showpredictionpattern.pl line 116., referer:
http://localhost:8081/cgi-bin/koha/serials/subscription-add.pl?op=modify&subscriptionid=4
[Fri Oct 20 00:20:18.672718 2017] [cgi:error] [pid 7358] [client
10.0.2.2:34032] AH01215: [Fri Oct 20 00:20:18 2017] showpredictionpattern.pl:
Argument "day" isn't numeric in numeric eq (==) at
/home/vagrant/kohaclone/serials/showpredictionpattern.pl line 116., referer:
http://localhost:8081/cgi-bin/koha/serials/subscription-add.pl?op=modify&subscriptionid=4
[Fri Oct 20 00:20:18.678244 2017] [cgi:error] [pid 7358] [client
10.0.2.2:34032] AH01215: [Fri Oct 20 00:20:18 2017] showpredictionpattern.pl:
The method permanent_irregularity is not covered by tests!, referer:
http://localhost:8081/cgi-bin/koha/serials/subscription-add.pl?op=modify&subscriptionid=4

Your t/db_dependent/Serials/SubscriptionIrregularity.pm test also fails because
there is no test for permanent_irregularity function

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #13 from Koha Team Lyon 3 <[hidden email]> ---
Hello Alex,

Good thing for dayly and monthly publication.
As for weekly issues, don't know if it's realistic but what about basing
calculation on week numbering (iso 8601) ?
Some review (not so unusual cases) announce clearly their "not issued weeks".
Example the New Yorker publishes 5 issues that runs along 2 weeks and they are
cited in the publication information block.

Olivier Crouzet

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #14 from Alex Arnaud <[hidden email]> ---
(In reply to Alex Buckley from comment #12)

> Hi Alex
>
> When checking if Wednesday and Thursday are still checked I have found that
> the test prediction pattern div is no longer being displayed.
>
> The errors I am getting in my intranet-error.log are:
>
> 0.0.2.2:34032] AH01215: [Fri Oct 20 00:20:18 2017] showpredictionpattern.pl:
> Argument "month" isn't numeric in numeric eq (==) at
> /home/vagrant/kohaclone/serials/showpredictionpattern.pl line 116., referer:
> http://localhost:8081/cgi-bin/koha/serials/subscription-add.
> pl?op=modify&subscriptionid=4
> [Fri Oct 20 00:20:18.672718 2017] [cgi:error] [pid 7358] [client
> 10.0.2.2:34032] AH01215: [Fri Oct 20 00:20:18 2017]
> showpredictionpattern.pl: Argument "day" isn't numeric in numeric eq (==) at
> /home/vagrant/kohaclone/serials/showpredictionpattern.pl line 116., referer:
> http://localhost:8081/cgi-bin/koha/serials/subscription-add.
> pl?op=modify&subscriptionid=4
> [Fri Oct 20 00:20:18.678244 2017] [cgi:error] [pid 7358] [client
> 10.0.2.2:34032] AH01215: [Fri Oct 20 00:20:18 2017]
> showpredictionpattern.pl: The method permanent_irregularity is not covered
> by tests!, referer:
> http://localhost:8081/cgi-bin/koha/serials/subscription-add.
> pl?op=modify&subscriptionid=4
I will fix the warning "Argument x isn't numeric" while doing the patch for
weekly.

>
> Your t/db_dependent/Serials/SubscriptionIrregularity.pm test also fails
> because there is no test for permanent_irregularity function
You must Launch misc/devel/update_dbix_class_files.pl to update
Koha/Schema/Result/Subscription.pm

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68261|0                           |1
        is obsolete|                            |

--- Comment #15 from Alex Arnaud <[hidden email]> ---
Created attachment 68607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68607&action=edit
Bug 17656 - Keep irregularities during subscription renewals

When renewing a subscription, irregularities are lost. This patch
allows to keep them for monthly, daily or weekly serials ( 1 unit per issue
only).

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
    - From: 2017-10-09, To: 2017-10-15,
    - Frequency: 1/day,
    - 7 issues,
    - test prediction pattern
    - check Wednesday and Thursday as irregularity,
    - save
  - Edit subscription,
  - Check that Wednesday and Thursday are still checked
  - Renew subscription from 2017-10-16
  - Edit subscription,
  - Make sure that Wednesday and Thursday are still checked
    with corresponding serials

  - Do the same for a monthly and weekly subscription

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #16 from Alex Arnaud <[hidden email]> ---
(In reply to Koha Team Lyon 3 from comment #13)

> Hello Alex,
>
> Good thing for dayly and monthly publication.
> As for weekly issues, don't know if it's realistic but what about basing
> calculation on week numbering (iso 8601) ?
> Some review (not so unusual cases) announce clearly their "not issued
> weeks". Example the New Yorker publishes 5 issues that runs along 2 weeks
> and they are cited in the publication information block.
>
> Olivier Crouzet

Hello Olivier,

I did it for weekly serials. Please test and give me your opinion.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68607|0                           |1
        is obsolete|                            |

--- Comment #17 from Alex Arnaud <[hidden email]> ---
Created attachment 68608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68608&action=edit
Bug 17656 - Keep irregularities during subscription renewals

When renewing a subscription, irregularities are lost. This patch
allows to keep them for monthly, daily or weekly serials ( 1 unit per issue
only).

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
    - From: 2017-10-09, To: 2017-10-15,
    - Frequency: 1/day,
    - 7 issues,
    - test prediction pattern
    - check Wednesday and Thursday as irregularity,
    - save
  - Edit subscription,
  - Check that Wednesday and Thursday are still checked
  - Renew subscription from 2017-10-16
  - Edit subscription,
  - Make sure that Wednesday and Thursday are still checked
    with corresponding serials

  - Do the same for a monthly and weekly subscription

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

Alex Arnaud <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68608|0                           |1
        is obsolete|                            |

--- Comment #18 from Alex Arnaud <[hidden email]> ---
Created attachment 68665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68665&action=edit
Bug 17656 - Keep irregularities during subscription renewals

When renewing a subscription, irregularities are lost. This patch
allows to keep them for monthly, daily or weekly serials ( 1 unit per issue
only).

Test plan:
  - Apply this patch,
  - Launch installer/data/mysql/updatedatabase.pl
  - Launch misc/devel/update_dbix_class_files.pl

  - Create a daily subscription. i.e:
    - From: 2017-10-09, To: 2017-10-15,
    - Frequency: 1/day,
    - 7 issues,
    - test prediction pattern
    - check Wednesday and Thursday as irregularity,
    - save
  - Edit subscription,
  - Check that Wednesday and Thursday are still checked
  - Renew subscription from 2017-10-16
  - Edit subscription,
  - Make sure that Wednesday and Thursday are still checked
    with corresponding serials

  - Do the same for a monthly and weekly subscription

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #19 from Koha Team Lyon 3 <[hidden email]> ---
Ok Alex, I will do it as soon as possible

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

David Bourgault <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Failed QA

--- Comment #20 from David Bourgault <[hidden email]> ---
Test plan works as described, but QA tools warns of forbidden patterns.

koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc
   FAIL   forbidden patterns
                forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 5)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #21 from Alex Arnaud <[hidden email]> ---
(In reply to David Bourgault from comment #20)
> Test plan works as described, but QA tools warns of forbidden patterns.
>
> koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.
> inc
>    FAIL  forbidden patterns
> forbidden pattern: Do not use line breaks inside template tags (bug 18675)
> (line 5)

Hello David,

I have no warning when launching the qa script (koha-qa.pl -v 3 -c 1)
For the file subscription_daily_choice file i got:

 OK    
koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   OK     tt_valid
   OK     valid_template

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12