[Bug 17560] New: Hold fee placement at point of checkout

classic Classic list List threaded Threaded
68 messages Options
123
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] New: Hold fee placement at point of checkout

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

            Bug ID: 17560
           Summary: Hold fee placement at point of checkout
 Change sponsored?: Sponsored
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

Currently, Koha charges all patrons a hold fee in all circumstances, if a hold
fee is applicable to their patron category.
This is immediately applied at point of request.
However, it would be useful to let patrons make requests without a charge
being incurred until they physically have the item in their hands and checked
out to their cards.

The hold fee will only be added to the account  as soon as the item is checked
out to the requesting patron​.
With this scenario, we will be certain that patrons have the correct item, and
they are happy with what has been supplied.
It also means that patrons can place holds via the OPAC without reaching the
usage limit that has been selected.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #1 from Jonathan Druart <[hidden email]> ---
Created attachment 57233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57233&action=edit
Bug 17560: Add a third option to HoldFeeMode

This patch adds a new 'any_time_is_collected' option to the HoldFeeMode
syspref.
The existing 'always' option is renamed with 'any_time_is_placed''

Sponsored-by: Cheshire Libraries

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #2 from Jonathan Druart <[hidden email]> ---
Created attachment 57234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57234&action=edit
Bug 17560: Update current code

This patch updates the current code to make it works with the new
option's name of the syspref.
It also refactor the tests to make them more reusable and robust.

Sponsored-by: Cheshire Libraries

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #3 from Jonathan Druart <[hidden email]> ---
Created attachment 57235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57235&action=edit
Bug 17560: Hold fee placement at point of checkout

Currently, Koha charges all patrons a hold fee in all circumstances, if
a hold fee is applicable to their patron category.
This is immediately applied at point of request.
However, it would be useful to let patrons make requests without a
charge
being incurred until they physically have the item in their hands and
checked out to their cards.

The hold fee will only be added to the account  as soon as the item is
checked out to the requesting patron.
With this scenario, we will be certain that patrons have the correct
item, and they are happy with what has been supplied.
It also means that patrons can place holds via the OPAC without reaching
the usage limit that has been selected.

Test plan:
0/ All the following steps must be done with a patron using a patron category
with a hold fee
1/ Make sure that the existing options for HoldFeeMode work as before
2/ Select the third option "any time a hold is collected"
3/ Place a hold on an item
4/ Note that the patron has not been charged
5/ Check this item from the staff interface
6/ Note that the patron has been charged
7/ Place another hold
8/ Use the self checkout feature at the OPAC for the checkin
9/ Note that the patron has been charged and a message is displayed to
inform about the fee.

Sponsored-by: Cheshire Libraries

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #4 from Jonathan Druart <[hidden email]> ---
Created attachment 57236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57236&action=edit
Bug 17560: Update the wording when a patron places a hold at the OPAC

Sponsored-by: Cheshire Libraries

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #5 from Jonathan Druart <[hidden email]> ---
Created attachment 57237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57237&action=edit
Bug 17560: Add a message when a patron checking in using the self checkout

Sponsored-by: Cheshire Libraries

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16817

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57233|0                           |1
        is obsolete|                            |
  Attachment #57234|0                           |1
        is obsolete|                            |
  Attachment #57235|0                           |1
        is obsolete|                            |
  Attachment #57236|0                           |1
        is obsolete|                            |
  Attachment #57237|0                           |1
        is obsolete|                            |

--- Comment #6 from Josef Moravec <[hidden email]> ---
Created attachment 57241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57241&action=edit
[SIGNED-OFF] Bug 17560: Add a third option to HoldFeeMode

This patch adds a new 'any_time_is_collected' option to the HoldFeeMode
syspref.
The existing 'always' option is renamed with 'any_time_is_placed''

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #7 from Josef Moravec <[hidden email]> ---
Created attachment 57242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57242&action=edit
[SIGNED-OFF] Bug 17560: Update current code

This patch updates the current code to make it works with the new
option's name of the syspref.
It also refactor the tests to make them more reusable and robust.

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #8 from Josef Moravec <[hidden email]> ---
Created attachment 57243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57243&action=edit
[SIGNED-OFF] Bug 17560: Hold fee placement at point of checkout

Currently, Koha charges all patrons a hold fee in all circumstances, if
a hold fee is applicable to their patron category.
This is immediately applied at point of request.
However, it would be useful to let patrons make requests without a
charge
being incurred until they physically have the item in their hands and
checked out to their cards.

The hold fee will only be added to the account  as soon as the item is
checked out to the requesting patron.
With this scenario, we will be certain that patrons have the correct
item, and they are happy with what has been supplied.
It also means that patrons can place holds via the OPAC without reaching
the usage limit that has been selected.

Test plan:
0/ All the following steps must be done with a patron using a patron category
with a hold fee
1/ Make sure that the existing options for HoldFeeMode work as before
2/ Select the third option "any time a hold is collected"
3/ Place a hold on an item
4/ Note that the patron has not been charged
5/ Check this item from the staff interface
6/ Note that the patron has been charged
7/ Place another hold
8/ Use the self checkout feature at the OPAC for the checkin
9/ Note that the patron has been charged and a message is displayed to
inform about the fee.

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #9 from Josef Moravec <[hidden email]> ---
Created attachment 57244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57244&action=edit
[SIGNED-OFF] Bug 17560: Update the wording when a patron places a hold at the
OPAC

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #10 from Josef Moravec <[hidden email]> ---
Created attachment 57245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57245&action=edit
[SIGNED-OFF] Bug 17560: Add a message when a patron checking in using the self
checkout

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email],
                   |                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize@ptfs-europe
                   |                            |.com

--- Comment #11 from Martin Renvoize <[hidden email]> ---
This is a dupe of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16817 right?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #12 from Martin Renvoize <[hidden email]> ---
My bad, they are subtly different.. one is 'Charge on collection' the other is
'Charge when ready for collection'.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Sally Healey <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey@cheshireshared
                   |                            |services.gov.uk

--- Comment #13 from Sally Healey <[hidden email]> ---
Hi Martin,

It's a very similar bug (it was our original spec) - but after some internal
discussion, we altered the spec, and this bug was logged and sponsored instead.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|[hidden email]-communit |[hidden email]
                   |y.org                       |
                 CC|                            |[hidden email]

--- Comment #14 from Marcel de Rooy <[hidden email]> ---
QA: Looking here now.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #15 from Marcel de Rooy <[hidden email]> ---
QA Comment
Code looks good to me. Note some wording issues and one blocker in the db
revision. Did not yet test the interface.

not_always is kind of a vague name for an option ;)
There is a charge of [% RESERVE_CHARGE %] for collecting this hold
There is a charge of [% RESERVE_CHARGE %] for placing this hold
Shouldn't it be better to say WHEN collecting this hold or WHEN placing this
hold ?
<div class="alert">You have been charged for collecting this item.</div>
Why did they charge me? Shouldn't you mention the the term "hold fee" here too?

sco-main.pl
You check if a hold exists before issuing. Shouldn't you check for the
borrowernumber too?
BTW Why not just call GetReserveFee here instead? You do not need to check
holds and account_lines anymore. And additionally you can pass the exact amount
in the message.
If you would still check account_lines, why not search for "Reserve Charge -
$title" too?

Please rename bug_XXXXX.sql.
Additionally, if the pref is set to 'always', you should now change the value
to any_time_is_placed. Since you remove always !!

Failed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #16 from Jonathan Druart <[hidden email]> ---
(In reply to Marcel de Rooy from comment #15)

> QA Comment
> Code looks good to me. Note some wording issues and one blocker in the db
> revision. Did not yet test the interface.
>
> not_always is kind of a vague name for an option ;)
> There is a charge of [% RESERVE_CHARGE %] for collecting this hold
> There is a charge of [% RESERVE_CHARGE %] for placing this hold
> Shouldn't it be better to say WHEN collecting this hold or WHEN placing this
> hold ?
> <div class="alert">You have been charged for collecting this item.</div>
> Why did they charge me? Shouldn't you mention the the term "hold fee" here
> too?


Can we get a native English speaker confirm the wordings?


> sco-main.pl
> You check if a hold exists before issuing. Shouldn't you check for the
> borrowernumber too?

Indeed.

> BTW Why not just call GetReserveFee here instead? You do not need to check
> holds and account_lines anymore. And additionally you can pass the exact
> amount in the message.

The idea was to make sure the patron has been charged. From the circulation and
reserves modules we are never really sure that what we want to happen will
happen....

> If you would still check account_lines, why not search for "Reserve Charge -
> $title" too?

To avoid to depend on a string that could change, but I can add it if you think
it's safer.

> Please rename bug_XXXXX.sql.
> Additionally, if the pref is set to 'always', you should now change the
> value to any_time_is_placed. Since you remove always !!

Indeed, will fix.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #17 from Jonathan Druart <[hidden email]> ---
Created attachment 60993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60993&action=edit
Bug 17560: Improve strenght of hold existence test

This patch is a QA follow-up to fix several issues:
- 1 call to GetReserveFee was wrong in ModReserveFill
- Update DB entry was wrong and insufficient
- Add robustness to the tests in sco-main

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #18 from Jonathan Druart <[hidden email]> ---
(In reply to Marcel de Rooy from comment #15)
> BTW Why not just call GetReserveFee here instead? You do not need to check
> holds and account_lines anymore. And additionally you can pass the exact
> amount in the message.

I tried to display the amount, but since we do not handle the display of price
yet, I do not think it is ready.
Without the currency symbol, the number alone looks weird, and with the
currency symbol the display will be wrong half of the time...

> Please rename bug_XXXXX.sql.

I do not think this is necessary, I will have to rewrite the original patches
and reupload all of them.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #19 from Marcel de Rooy <[hidden email]> ---
I will resume QA here later.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

Alex Sassmannshausen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.sassmannshausen@ptfs-e
                   |                            |urope.com

--- Comment #20 from Alex Sassmannshausen <[hidden email]> ---
(In reply to Jonathan Druart from comment #16)

> (In reply to Marcel de Rooy from comment #15)
> > QA Comment
> > Code looks good to me. Note some wording issues and one blocker in the db
> > revision. Did not yet test the interface.
> >
> > not_always is kind of a vague name for an option ;)
> > There is a charge of [% RESERVE_CHARGE %] for collecting this hold
> > There is a charge of [% RESERVE_CHARGE %] for placing this hold
> > Shouldn't it be better to say WHEN collecting this hold or WHEN placing this
> > hold ?
> > <div class="alert">You have been charged for collecting this item.</div>
> > Why did they charge me? Shouldn't you mention the the term "hold fee" here
> > too?
>
>
> Can we get a native English speaker confirm the wordings?
>

Claire and I have deliberated for a bit at the hackfest, and we think the
following would be minor improvements (though it kind of works as it is).

> There is a charge of [% RESERVE_CHARGE %] for collecting this hold
You will be charged a hold fee of [% _ %] for collecting this item

> There is a charge of [% RESERVE_CHARGE %] for placing this hold
You will be charged a hold fee of [% _ %] for placing this hold

> <div class="alert">You have been charged for collecting this item.</div>
A hold fee was charged to your account for collecting this item.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #21 from Jonathan Druart <[hidden email]> ---
Created attachment 61301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61301&action=edit
Bug 17560: Improve wordings

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #22 from Marcel de Rooy <[hidden email]> ---
(In reply to Alex Sassmannshausen from comment #20)
> Claire and I have deliberated for a bit at the hackfest, and we think the
> following would be minor improvements (though it kind of works as it is).

Great. Thanks.

> > There is a charge of [% RESERVE_CHARGE %] for collecting this hold
> You will be charged a hold fee of [% _ %] for collecting this item

Although I am not a native speaker, maybe we can still improve here :) Note
that opac-reserve tells this to the user. So the time is placing the hold, but
collecting it is still in the future. We do not charge for collecting btw, we
just charge when you collect.. Shouldn't it be better to say You will be
charged WHEN collecting? (Very strictly, we can't say THIS item; could be a
biblio level hold. Maybe: book, material, or just 'it'.)
So I would opt for: You will be charged WHEN collecting THE item.
No blocker btw.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #23 from Marcel de Rooy <[hidden email]> ---
Just another question: If we checkout in the staff client, wouldn't it be good
to also show a message? A staff member could remind the patron that the fee is
applied now, but he does not see it happening.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17560] Hold fee placement at point of checkout

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17560

--- Comment #24 from Marcel de Rooy <[hidden email]> ---
(In reply to Marcel de Rooy from comment #23)
> Just another question: If we checkout in the staff client, wouldn't it be
> good to also show a message? A staff member could remind the patron that the
> fee is applied now, but he does not see it happening.

Not to talk about SIP.
This 'fortunately' does not look very promising currently in do_hold:
    AddReserve( $branch, $borrower->{borrowernumber}, $bibno,
GetBiblioItemByBiblioNumber($bibno) );
    # unfortunately no meaningful return value
    $self->ok(1);
    return $self;

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
123
Loading...