[Bug 17355] New: Allow deletion of authorised value categories

classic Classic list List threaded Threaded
20 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] New: Allow deletion of authorised value categories

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

            Bug ID: 17355
           Summary: Allow deletion of authorised value categories
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email]

This will be a follow-up to bug 17216 that adds a separate table for authorised
value categories. Now that we store them, we need a way to delete accidentally
added categories easily.

Jonathan wrote about this:

- There is no way to delete a category (TODO). But to do so it would be
  good to have a authorised_value_categories.is_internal field to mark
  some categories as "cannot be deleted".

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Allow deletion of authorised value categories

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17216


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216
[Bug 17216] Add a new table to store authorized value categories
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Allow deletion of authorised value categories

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

--- Comment #1 from Nick Clemens <[hidden email]> ---
Created attachment 64102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64102&action=edit
Bug 17355 - Allow deletion of authorised value categories

This is jsut a ptach I was toying with - as Jonathan mentions we need a
way to prevent deletion of internal categories, I just listed them here
(we would list more)

Partial patch, so would need work but poking this bug as reminder :-)

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Barton Chittenden <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|Allow deletion of           |Authorised value categories
                   |authorised value categories |cannot be deleted
           Severity|enhancement                 |normal

--- Comment #2 from Barton Chittenden <[hidden email]> ---
*** Bug 18813 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64102|0                           |1
        is obsolete|                            |

--- Comment #3 from Liz Rea <[hidden email]> ---
Created attachment 65782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65782&action=edit
Bug 17355 - Allow deletion of authorised value categories

This is jsut a ptach I was toying with - as Jonathan mentions we need a
way to prevent deletion of internal categories, I just listed them here
(we would list more)

Partial patch, so would need work but poking this bug as reminder :-)

Signed-off-by: Liz Rea <[hidden email]>
This is a good start

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Liz Rea <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65782|0                           |1
        is obsolete|                            |

--- Comment #4 from Liz Rea <[hidden email]> ---
Created attachment 65869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65869&action=edit
Bug 17355 - Allow deletion of authorised value categories

Note that this does not capture all internal fields, and isn't a database
solution to the problem of marking internal fields.

To test:

Add an empty authorised value category, delete it. Make sure it stays deleted.

Try to delete an empty system authorised value, like ccode. You should not see
the button.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

--- Comment #5 from Liz Rea <[hidden email]> ---
Created attachment 65870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65870&action=edit
Bug 17355 - fixing typo in success message

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #6 from Katrin Fischer <[hidden email]> ---
Should this be 'Needs Sign-off'?

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

--- Comment #7 from Katrin Fischer <[hidden email]> ---
Created attachment 66022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66022&action=edit
[SIGNED OFF] Bug 17355 - Allow deletion of authorised value categories

Note that this does not capture all internal fields, and isn't a database
solution to the problem of marking internal fields.

To test:

Add an empty authorised value category, delete it. Make sure it stays deleted.

Try to delete an empty system authorised value, like ccode. You should not see
the button.

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

--- Comment #8 from Katrin Fischer <[hidden email]> ---
Created attachment 66023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66023&action=edit
[SIGNED OFF] Bug 17355 - fixing typo in success message

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

--- Comment #9 from Katrin Fischer <[hidden email]> ---
Created attachment 66024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66024&action=edit
Bug 17355 - Follow-up - Fix page structure and alert on delete

- Fixes page structure in 2 spots.
  Without the patch the second problem was manifesting in a
  display problem with the right side tool navigation.
- Adds a specific 'Are you sure you want to...' question
  instead of reusing the one for authorised values also for
  categories.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65869|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65870|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

--- Comment #10 from Jonathan Druart <[hidden email]> ---
Do not you think that my suggestion to add a new "is_internal" (or whatever)
new DB field could be better?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

--- Comment #11 from Katrin Fischer <[hidden email]> ---
I just noticed that +        LOC => 1, is doubled up in the patch.
I think the idea of a database field is good, but maybe this could be done in a
separate patch? We filed the bug a year ago :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|[hidden email]-communit |[hidden email]
                   |y.org                       |
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #12 from Julian Maurice <[hidden email]> ---
QA comment:
1. It is possible to delete protected categories by changing the URL, e.g.
/cgi-bin/koha/admin/authorised_values.pl?op=del_category&category=Bsort1
The deletion must be prevented on the server side.
2. The 'Delete category' button is inside the message box for "There are no
authorised values ...". Why not in the toolbar like the other buttons ?
3. After a successful deletion, there is no redirect, so if we refresh the page
the deletion is tried again and we end up with the following error message:
"error_on_delete_cat". This message should be more human-friendly and IMO there
should be a redirect after the deletion.
4. As comment 11 says, LOC appears twice in the hash, as well as LOST. These
duplicates must be removed.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 17355] Authorised value categories cannot be deleted

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Marjorie Barry-Vila <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |.ca

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/