[Bug 17015] New: New Koha Calendar

classic Classic list List threaded Threaded
116 messages Options
1234
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New: New Koha Calendar

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

            Bug ID: 17015
           Summary: New Koha Calendar
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Holidays
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

We are trying to create a new Koha calendar system. The one available right now
is way too slow. This is the first patch of the calendar, it doesn't affect the
functioning of the current calendar, but it works in parallel with it. Instead
of having multiple tables for the holidays, we created one table, called
discrete_calendar. This table contains the dates,branchcode, opening/closing
hours, a note about the holiday and whether the library is open or not.

The script misc/generate_discrete_calendar.pl fills the table discrete_calendar
based on tables : repeatable_holidays, special_holidays, openinghours and
branches. The script, by default, will add 2 years from the past and 1 year in
the future in the table discrete_calendar. It also has an option to added more
than 1 year in the future.

The script misc/cronjobs/add_days_discrete_calendar.pl will add days in the
future in the table discrete calendar. A day's opening and closing hours will
be based on the same weekday from the week before. It will also check if the
same day from last year was a holiday, if so, this will be counted as a
holiday.
The script makes sur there's at least 1 year in the future. So if it hasn't ran
for 8 days, 8 days will be added in he future the next time the script is
executed.

There's also an atomic update to create the table.

The current options are not final and they can be changed for convenience.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #1 from Mehdi Hamidi <[hidden email]> ---
Created attachment 53859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53859&action=edit
Bug - 17015 New calendar

The new calendar is now in the table discreate_calendar.
All holidays will be indicated in this table.
Closing and opening hours will be available on this table as well.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Katrin Fischer <[hidden email]> ---
>It will also check if the
>same day from last year was a holiday, if so, this will be counted as a
>holiday.

This sounds like a wrong assumption. Most of the holidays here are not on the
same date every year - so this would create a horrible mess. It's the reason
why you can choose to have unique holidays and holidays that repeat every year
with the current system.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Chris Cormack <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Chris Cormack <[hidden email]> ---
(In reply to Katrin Fischer from comment #2)
> >It will also check if the
> >same day from last year was a holiday, if so, this will be counted as a
> >holiday.
>
> This sounds like a wrong assumption. Most of the holidays here are not on
> the same date every year - so this would create a horrible mess. It's the
> reason why you can choose to have unique holidays and holidays that repeat
> every year with the current system.

I agree this sounds like a big step backwards in functionality. The first step
of any rewrite/refactor should be to make sure all existing functionality is
not lost.
The calendar is vitally important, so many things depend on it, it is vital we
don't lose functionality.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |francois.charbonnier@inlibr
                   |                            |o.com,
                   |                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53859|0                           |1
        is obsolete|                            |

--- Comment #4 from Mehdi Hamidi <[hidden email]> ---
Created attachment 54318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54318&action=edit
Bug 17015 - New koha calendar

The new calendar has it's own UI now.
  Added some new features to the calendar:
     - Copying calendar from branch to branch
     - Copy holidays from date to date or from range to range
- Added a column into discrete_calendar holidaytype.
- Adding new days in futureChecks type of holiday:
      - If the date from a year ago was exeption ('E'), the new day won't be a
holiday.
      - If the date from a year ago was fixed ('R') repeatable, the new day
will be a holiday.
      - If the date from a year ago was float ('F') a holiday that's not fixed,
the new day will on need validation.
      - If the date from a year ago was need validation ('N'), the new day will
still be on need validation.
  - You can change the opening and closing hours from the calendar UI directly.

  - The discrete_calendar uses sql queries for now, the next patch will be to
change that that it uses schema.
  - CSS and some client side calculation might be changed.


  - Please let us know what you think and if we should add/modify some
features.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54318|0                           |1
        is obsolete|                            |

--- Comment #5 from Mehdi Hamidi <[hidden email]> ---
Created attachment 54419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54419&action=edit
Bug 17015 - New koha calendar

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #6 from Mehdi Hamidi <[hidden email]> ---
Created attachment 59166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59166&action=edit
Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54419|0                           |1
        is obsolete|                            |
  Attachment #59166|0                           |1
        is obsolete|                            |

--- Comment #7 from Mehdi Hamidi <[hidden email]> ---
Created attachment 59167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59167&action=edit
Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #8 from Mehdi Hamidi <[hidden email]> ---
Created attachment 59168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59168&action=edit
Bug 17015 - Tests for DiscreteCalendar

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #9 from Mehdi Hamidi <[hidden email]> ---
Created attachment 59169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59169&action=edit
Bug 17015 - Koha now uses the new DiscreteCalendar module

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #10 from Mehdi Hamidi <[hidden email]> ---
Created attachment 59170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59170&action=edit
Bug 17015 - Updated Koha tests to use the new DiscreteCalendar module

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #11 from Mehdi Hamidi <[hidden email]> ---
Created attachment 59171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59171&action=edit
Bug 17015 - Peformance tests for Koha::DiscreteCalendar

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #12 from Mehdi Hamidi <[hidden email]> ---
Hello everyone, this is our new Calendar. This calendar is the combination of
Koha::Calendar and C4::Calendar.
The current calendar is very slow, especially for returns past due date.
DateTime Objects are very huge and resource consuming.
Our new calendar creates a Database Table to keep track of dates, holidays,
open and close hours per branch.
This way we can keep information about past, current and future dates/holidays.
We also depend on the database to make the calculations instead of DateTime
Objects which makes our new calendar incredibly faster than the current one for
fines and check-ins.
The last patch if for performance purposes and it show improvement in
comparison to the current calendar

-What we added/changed:
1- New UI
2- Change open and close hours for single and on range dates.
- Holiday types:
    - Float : like Thanksgiving, holiday without a fixed date (same as
exception, might be removed)
    - Needs validation : When a day is added in the future and it was an
Exception or Floating holiday 365 days in the past.
        This day is considered opened, so if the holiday still applies, it
needs to be changed to correct holiday.
- Change holiday type, override existing holiday.
- Copy range of holidays :
    - 1 day to multiple dates.
    - 7 days to another 7 days , apply  day of the week to the same day of the
week.
    - Any number of dates to the same number of dates.
  PS: This will copy everything, isopened, open/close hours and notes.
- Delete repeated and weekly holidays for a single date or all of them.
- Delete holidays on the range without a type.
- Calculate hours opened between dates based on open and close hours of the
branch.
- Copy calendar to another branch.

UI tips and tricks:
- Open/close hour, date type inputs will be emptied when selecting a range that
doesn't share the same values. Only different values will be emptied.
- Leaving one these (open/close hour, date type) inputs empty means they won't
be updated.
- Leaving the title input empty means it will be empty/deleted.
- Only dates in discrete_calendar table are selectable on the calendar.
- You can't update the information about a past date, meaning you can only
update today and future dates. This also applies to weekly holidays
- Checking delete type, will delete all :
    - Weekly holidays of that day, example : all Sundays.
    - Repeatable holidays, example : all 1 of January.
- Weekly holidays will apply the same open/close hours for all the dates
affected unless these inputs are left empty,
    this can be used to update all open/close hours of a given day of the week,
then removing the holiday.

Scripts :
  - misc/generate_discrete_calendar.pl
      This script fills the table discrete_calendar based on tables :
repeatable_holidays, special_holidays and branches.
      The script, by default, will add 2 years from the past and 1 year in the
future in the table discrete_calendar.
      It also has an option to add more than 1 year in the future.
      Opening and closing hours are by default 9:00 and 17:00 respectively,
they can be changed using the UI
  - add_days_discrete_calendar.pl
      This script will be used to add days in the future for the calendar,
default is 1 day, this can be changed using -n option for the script.
      The add day will have the following values:
          - Open/close hours based on the same day of the week, a week beofre
it. Example : new day : Friday 2018-01-19, a week before Friday 2018-01-12
          - HolidayType based on the same day a year ago, however if the
holiday type was :
                Float/Exception : the holidaytype of the the new day will be
marked as Needs validation.
                Weekly : the new day will be marked as normal day(To discuss
further).
                Fixed  : the new day will be closed as fixed holiday.

Test plan :
1- Apply patch
2- Run installer/data/mysql/updatedatabase.pl
3- Have atleast these branches CPL, FFL, LPL for test purposes (specific test :
t/db_dependent/HoldsQueue.t)
4- Run the script misc/generate_discrete_calendar.pl (one time only, this may
take a while)
5- Run the script add_days_discrete_calendar.pl to add days into the future
    - Check if the max date is now today + 1 day
6- Generate schemas by running misc/devel/update_dbix_class_files.pl
7- Run test t/db_dependent/DiscreteCalendar.t
8- Run all koha test t/

Use Discrete Calendar in Tools.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Sally Healey <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey@cheshireshared
                   |                            |services.gov.uk

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Needs Signoff               |Failed QA

--- Comment #13 from Josef Moravec <[hidden email]> ---
I am always for making Koha faster ;)

I just did first round of testing:

scripts
generate_discrete_calendar.pl
and
add_days_discrete_calendar.pl
needs to have set execution permission in filesystem


the need to run generate_discrete_calendar.pl should be somehow documented in
UI, adding holidays does not work without it and the can't know why

qa tools complain:
 FAIL   C4/Circulation.pm
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 3418)
                forbidden pattern: tab char (line 394)
                forbidden pattern: tab char (line 676)
                forbidden pattern: tab char (line 3575)
                forbidden pattern: tab char (line 3553)

 FAIL   Koha/DiscreteCalendar.pm
   FAIL   critic
                Variable declared in conditional statement at line 862, column
5. Declare variables outside of the condition.
                Variable declared in conditional statement at line 861, column
5. Declare variables outside of the condition.
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 413)
                forbidden pattern: tab char (line 412)
                forbidden pattern: tab char (line 411)
   FAIL   pod
                Spurious text after =cut
                Spurious =cut command

                *** ERROR:

                 in file Koha/DiscreteCalendar.pm
   FAIL   spelling
                 differnt  ==> different


 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/tools/discrete_calendar.tt
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 440)
                forbidden pattern: intranet-tmpl should certainly replaced with
[% interface %] (line 7)
                forbidden pattern: tab char (line 439)
                forbidden pattern: tab char (line 441)


 FAIL   misc/cronjobs/staticfines.pl
   FAIL   valid
                Can't locate C4/DiscreteCalendar.pm in @INC (you may need to
install the C4::DiscreteCalendar module) (@INC contains:
/home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2
/usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
/usr/local/lib/site_perl .)

Ad point 3 in your test plan: It would be better not to rely on existing
branchcodes, but use TestBuilder to make one you need

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #14 from Mehdi Hamidi <[hidden email]> ---
(In reply to Josef Moravec from comment #13)

Hello Josef,
thank you for testing our patches. I will push a fix for errors you mentioned
very soon.  
As for your concerns :
>- the need to run generate_discrete_calendar.pl should be somehow documented in >UI, adding holidays does not work without it and the can't know why

I added a warning to let the user know about that. As for why you can't add
holidays, it's because we need to have the date in the database beforehand,
which means if the table is empty, there's date to edit. Holidays are just date
where the column isopen=0.

>Ad point 3 in your test plan: It would be better not to rely on existing >branchcodes, but use TestBuilder to make one you need

Our calendar needs to have valid branchcodes where their date are already in
table discrete_calendar. Using TestBuilder gives random branchcodes so the
dates cannot be retrieved from database since they are generated by
generate_discrete_calendar.pl and add_days_discrete_calendar.pl.

If you have a suggestion to bypass the hard coded branchcodes, let us know!

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #15 from Mehdi Hamidi <[hidden email]> ---
(In reply to Josef Moravec from comment #13)

> >Ad point 3 in your test plan: It would be better not to rely on existing >branchcodes, but use TestBuilder to make one you need
>
> Our calendar needs to have valid branchcodes where their date are already in
> table discrete_calendar. Using TestBuilder gives random branchcodes so the
> dates cannot be retrieved from database since they are generated by
> generate_discrete_calendar.pl and add_days_discrete_calendar.pl.
>
> If you have a suggestion to bypass the hard coded branchcodes, let us know!

Please discard this part.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mubassir Ahsan <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Marjorie Barry-Vila <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |.ca

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59167|0                           |1
        is obsolete|                            |
  Attachment #59168|0                           |1
        is obsolete|                            |
  Attachment #59169|0                           |1
        is obsolete|                            |
  Attachment #59170|0                           |1
        is obsolete|                            |

--- Comment #16 from Mehdi Hamidi <[hidden email]> ---
Created attachment 59267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59267&action=edit
Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #17 from Mehdi Hamidi <[hidden email]> ---
Created attachment 59268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59268&action=edit
Bug 17015 - Tests for DiscreteCalendar

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #18 from Mehdi Hamidi <[hidden email]> ---
Created attachment 59269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59269&action=edit
Bug 17015 - Koha now uses the new DiscreteCalendar module

C4/Circulation.pm

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #19 from Mehdi Hamidi <[hidden email]> ---
Created attachment 59270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59270&action=edit
Bug 17015 - Updated Koha tests to use the new DiscreteCalendar module

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #20 from Mehdi Hamidi <[hidden email]> ---
Created attachment 59271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59271&action=edit
Bug 17015 - Peformance tests for Koha::DiscreteCalendar

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 17015] New Koha Calendar

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #21 from Mehdi Hamidi <[hidden email]> ---
Hello everyone,
I fixed the problems mentioned by Josef Moravec above, thank you once again!

Also, you no longer need to have valid branchcodes to run tests.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
1234
Loading...