[Bug 16735] New: Replace existing library search groups functionality with the new hierarchical groups system

classic Classic list List threaded Threaded
105 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #67 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 69684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69684&action=edit
Bug 16735: Remove modules no longer needed

Signed-off-by: Josef Moravec <[hidden email]>
Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #68 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 69685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69685&action=edit
Bug 16735: Remove tables no longer needed

Signed-off-by: Josef Moravec <[hidden email]>
Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #69 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 69686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69686&action=edit
Bug 16735: Clean up sample data

Signed-off-by: Josef Moravec <[hidden email]>
Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #70 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 69687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69687&action=edit
Bug 16735: Migrate library search groups into the new hierarchical groups

Test Plan:
1) Apply this patch set
2) Note your existing search groups have been ported over to the new
   __SEARCH_GROUPS__ group if you had any
3) Create the group __SEARCH_GROUPS__ if one does not already exist
4) Add some first level subgroups to this group, add libraries to those groups
5) Search the library group searching in the intranet and opac
6) Note you get the same results as pre-patch

Signed-off-by: Josef Moravec <[hidden email]>
Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #71 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 69688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69688&action=edit
Bug 16735: Don't use objects for database update

Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #72 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 69689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69689&action=edit
Bug 16735: Remove use of get_categories

Feature using it is completely undocumented as far as my research has
shown.

Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #73 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 69690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69690&action=edit
Bug 16735: Filter individual libraries from search group pulldown

Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #74 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 69691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69691&action=edit
Bug 16735: DBIC Schema files

Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #75 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 69692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69692&action=edit
Bug 16735: Use libraries in all subgroups, not just immediate children

Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #76 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 69693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69693&action=edit
Bug 16735: (QA followup) POD fixes

Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #77 from Tomás Cohen Arazi <[hidden email]> ---
Created attachment 69694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69694&action=edit
Bug 16735: (QA followup) Fix rebase error

Signed-off-by: Tomas Cohen Arazi <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Alex Buckley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply

--- Comment #78 from Alex Buckley <[hidden email]> ---
I have tried to apply these patches as they are a dependency for the patches on
bug 19765 however I have found that the patches attached to this  bug report
(16735) not longer cleanly apply on an up to date branch.

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 16735: Remove modules no longer needed
Applying: Bug 16735: Remove tables no longer needed
Applying: Bug 16735: Clean up sample data
Applying: Bug 16735: Migrate library search groups into the new hierarchical
groups
fatal: sha1 information is lacking or useless (C4/Auth.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 16735: Migrate library search groups into the new
hierarchical groups
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-16735-Migrate-library-search-groups-into-the-n-yOLkh7.patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Tomás Cohen Arazi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

--- Comment #79 from Tomás Cohen Arazi <[hidden email]> ---
It applies cleanly if you have the dependencies in your branch.

This is latest master. I've applied the dependent bug (15707) manually so it is
more readable:

tcohen@bibliotecas-1:koha(qa_16735)$ git reset --hard origin/master
HEAD is now at 03dd826757 Bug 17182: (QA follow-up) Fix call to GetMarcBiblio
tcohen@bibliotecas-1:koha(qa_16735)$ git bz apply 15707
Bug 15707 - Add ability to define hierarchical groups of libraries

69573 - Bug 15707: Update DB
69574 - Bug 15707: Add Koha::Library::Group(s) modules
69575 - Bug 15707: Add library groups editor
69576 - Bug 15707: Unit Tests
69577 - Bug 15707: Fix conflict with bug 15446 (type vs _type)
69578 - Bug 15707: (QA followup) Switch to treetable which Koha already uses
69579 - Bug 15707: (QA followup) Drop table if exists
69580 - Bug 15707: (QA followup) Fix UI issues
69581 - Bug 15707: (QA followup) Remove class for treegrid
69582 - Bug 15707: (QA followup) Allow object names to be styled without
impeding translation
69583 - Bug 15707: (followup) use cat-search instead of cities-search in header
69584 - Bug 15707: Switch datetimes to timestamps
69585 - Bug 15707: Add UNIQUE constraint to library groups table
69586 - Bug 15707: Updates for Bootstrap 3
69587 - Bug 15707: Display error if group title is already used
69588 - Bug 15707: DBIC Schema files
69589 - Bug 15707: (QA followup) Style buttons correctly

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15707: Update DB
Applying: Bug 15707: Add Koha::Library::Group(s) modules
Applying: Bug 15707: Add library groups editor
Applying: Bug 15707: Unit Tests
Applying: Bug 15707: Fix conflict with bug 15446 (type vs _type)
Applying: Bug 15707: (QA followup) Switch to treetable which Koha already uses
Applying: Bug 15707: (QA followup) Drop table if exists
Applying: Bug 15707: (QA followup) Fix UI issues
Applying: Bug 15707: (QA followup) Remove class for treegrid
Applying: Bug 15707: (QA followup) Allow object names to be styled without
impeding translation
Applying: Bug 15707: (followup) use cat-search instead of cities-search in
header
Applying: Bug 15707: Switch datetimes to timestamps
Applying: Bug 15707: Add UNIQUE constraint to library groups table
Applying: Bug 15707: Updates for Bootstrap 3
Applying: Bug 15707: Display error if group title is already used
Applying: Bug 15707: DBIC Schema files
Applying: Bug 15707: (QA followup) Style buttons correctly
tcohen@bibliotecas-1:koha(qa_16735)$ git bz apply 16735

Bug 16735 Depends on bug 15707
Follow? [(y)es, (n)o] n
Bug 16735 - Replace existing library search groups functionality with the new
hierarchical groups system

69684 - Bug 16735: Remove modules no longer needed
69685 - Bug 16735: Remove tables no longer needed
69686 - Bug 16735: Clean up sample data
69687 - Bug 16735: Migrate library search groups into the new hierarchical
groups
69688 - Bug 16735: Don't use objects for database update
69689 - Bug 16735: Remove use of get_categories
69690 - Bug 16735: Filter individual libraries from search group pulldown
69691 - Bug 16735: DBIC Schema files
69692 - Bug 16735: Use libraries in all subgroups, not just immediate children
69693 - Bug 16735: (QA followup) POD fixes
69694 - Bug 16735: (QA followup) Fix rebase error

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 16735: Remove modules no longer needed
Applying: Bug 16735: Remove tables no longer needed
Applying: Bug 16735: Clean up sample data
Applying: Bug 16735: Migrate library search groups into the new hierarchical
groups
Applying: Bug 16735: Don't use objects for database update
Applying: Bug 16735: Remove use of get_categories
Applying: Bug 16735: Filter individual libraries from search group pulldown
Applying: Bug 16735: DBIC Schema files
Applying: Bug 16735: Use libraries in all subgroups, not just immediate
children
Applying: Bug 16735: (QA followup) POD fixes
Applying: Bug 16735: (QA followup) Fix rebase error
tcohen@bibliotecas-1:koha(qa_16735)$

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Jessie Zairo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
1234