[Bug 16711] New: OPAC Password recovery: Handling if multiple accounts have the same mail address

classic Classic list List threaded Threaded
45 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] New: OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

            Bug ID: 16711
           Summary: OPAC Password recovery: Handling if multiple accounts
                    have the same mail address
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

If multiple accounts have the same email address set as primary email and you
ask for password recovery with only filling in the email address, a email is
sent for one account only.

Example:
Create 3 Accounts, login names are test01, test02, test 03, Email is the same
for all.

Go to OPAC -> Password recovery and indicate E-Mail only

You will get a mail for only one of the accounts above, something like:

---------
This email has been sent in response to your password recovery request for the
account test01

You can now create your new password using the following link:
http://.......
(...)
---------

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=2237

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Christopher Brannon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Christopher Brannon <[hidden email]> ---
Perhaps require the library card number associated with the account when
requesting the recovery/reset?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11943

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

David Cook <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from David Cook <[hidden email]> ---
I wonder how having multiple accounts with the same email address would affect
the Mozilla Persona stuff.

I seem to recall Chris saying that an email address should only belong to one
account, although that's not enforced anywhere...

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

--- Comment #3 from Christopher Brannon <[hidden email]> ---
(In reply to David Cook from comment #2)
> I wonder how having multiple accounts with the same email address would
> affect the Mozilla Persona stuff.
>
> I seem to recall Chris saying that an email address should only belong to
> one account, although that's not enforced anywhere...

It's not a realistic expectation.  Are parents supposed to start a new e-mail
account for every child that has a library card???

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

--- Comment #4 from Christopher Brannon <[hidden email]> ---
(In reply to Christopher Brannon from comment #3)
> (In reply to David Cook from comment #2)
> > I wonder how having multiple accounts with the same email address would
> > affect the Mozilla Persona stuff.
> >
> > I seem to recall Chris saying that an email address should only belong to
> > one account, although that's not enforced anywhere...
>
> It's not a realistic expectation.  Are parents supposed to start a new
> e-mail account for every child that has a library card???

That being said, it may have to come down to either logging in with the card
number or a combination of e-mail and card number.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

--- Comment #5 from David Cook <[hidden email]> ---
(In reply to Christopher Brannon from comment #3)
> It's not a realistic expectation.  Are parents supposed to start a new
> e-mail account for every child that has a library card???

That's certainly a valid point. I'm just pointing out that it will probably
cause unexpected behaviour when using Mozilla Persona, but I don't know how
many people actually use Persona anyway.

As for the password reset, yeah I think it would make sense to provide userid
or cardnumber as that's the unique identifier used for the patron, no?

You could just put in your cardnumber/userid, and then get a message saying:

"A password reset email has been send to the email address registered for
account test01"

Or something like that.

We actually have a local password reset service... I should look how I
implemented it...

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

David Kuhn <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

--- Comment #6 from David Kuhn <[hidden email]> ---
I second the idea that the card number/user id should be required to reset a
password, since that should always be a unique identifier.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

--- Comment #7 from Marc Véron <[hidden email]> ---
Thinking loud about sending information about all library accounts if in
password recovery an email with multiple library accounts attached is given:

What could be the reasons to have one email address and multiple accounts?

- An individual has multiple library accounts, e.g. one for professional
purposes and a private one. For exammple a teacher needs books for school and
wants to separate that from their private lecture.

In that case sending a reset links for multiple accounts would be OK (no
privacy breach) because it is the same person. But atm the mail contains only a
reset link, no information that would help to identifiy the account. So the
individual could reset the wrong password.

- A group (family, couple) shares the same email but they have different
library accounts

In that case, privacy is defined by the group: Either one individual has access
to the email or all of the group have access. If all have access, one
individual could change the password for an other one. That would be a privacy
breach.

OK then, it is not a good idea to send reset links for all accounts attached to
an email account.

IMO the easiest solution would be not to send recovery link(s), but to display
an information similar to the one that appears if an email address is not found
in the database (Error No account was found with the provided information.
Please...)

The message could be something like:
-------------
Information
Multiple library accounts are attached to this email. Please fill the field
'Login' to identify which password you want to reset. Please contact the
library if you need further assistance.
-------------

Additionally, there could be more enhancements (to be covered by separate
bugs):
- Have a syspref to prevent multiple accounts with same email (could get
complicated for existing installs)
- Have a precooked report that displays library accounts sharing one email
address

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]         |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

--- Comment #8 from Marc Véron <[hidden email]> ---
Created attachment 63591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63591&action=edit
Bug 16711: OPAC Password recovery: Handling if multiple accounts have the same
mail address

To reproduce:
- Create 3 Accounts, login names are test01, test02, test03, Email is the same
for all.
- Go to OPAC -> Password recovery and indicate E-Mail only
- You will get an email for only one of the accounts above.

To test:
- Apply patch, restart memcached and plack
- Go to db, delete from borrower_password_recovery;
- Try steps above to reproduce. You will get an error message:
    Account identification with this email address only is ambiguous.
    Please use the field 'Login' as well.
- Verify that other cases work as before (provide valid / invalid login only,
  provide valid email for an existing account, provide unknown email, provide
  both login and email with all combinations of valid / invalid)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Josef Moravec <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63591|0                           |1
        is obsolete|                            |

--- Comment #9 from Josef Moravec <[hidden email]> ---
Created attachment 63600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63600&action=edit
[SIGNED-OFF] Bug 16711: OPAC Password recovery: Handling if multiple accounts
have the same mail address

To reproduce:
- Create 3 Accounts, login names are test01, test02, test03, Email is the same
for all.
- Go to OPAC -> Password recovery and indicate E-Mail only
- You will get an email for only one of the accounts above.

To test:
- Apply patch, restart memcached and plack
- Go to db, delete from borrower_password_recovery;
- Try steps above to reproduce. You will get an error message:
    Account identification with this email address only is ambiguous.
    Please use the field 'Login' as well.
- Verify that other cases work as before (provide valid / invalid login only,
  provide valid email for an existing account, provide unknown email, provide
  both login and email with all combinations of valid / invalid)

Signed-off-by: Josef Moravec <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12566

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Séverine Queune <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18616

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

--- Comment #10 from David Kuhn <[hidden email]> ---
Created attachment 64064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64064&action=edit
Added the code from bug 17616, which allows patron to also use their card
number as a login id since there were merge conflicts with that patch.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

David Kuhn <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64064|Added the code from bug     |Added the code from bug
        description|17616, which allows patron  |18616, which allows patron
                   |to also use their card      |to also use their card
                   |number as a login id since  |number as a login id since
                   |there were merge conflicts  |there were merge conflicts
                   |with that patch.            |with that patch.
  Attachment #64064|Added-the-code-from-bug-176 |Added-code-from-bug-18616-w
           filename|16-which-allows-patron-.pat |hich-allows-patron-.patch
                   |ch                          |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18616


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616
[Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use
their library card number in addition to username
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #64064|0                           |1
        is obsolete|                            |

--- Comment #11 from Marc Véron <[hidden email]> ---
Comment on attachment 64064
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64064
Added the code from bug 18616, which allows patron to also use their card
number as a login id since there were merge conflicts with that patch.

Made 18616 dependent on 16711 and moved David's patch back to 18616, and signed
off 18616

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

--- Comment #12 from Marc Véron <[hidden email]> ---
Still applies on current master

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Signed Off                  |Failed QA

--- Comment #13 from Nick Clemens <[hidden email]> ---
opac-password-recovery.pl:
$search_results = [ Koha::Patrons->search( { -or => { email => $email, emailpro
=> $email, B_email  => $email } } ) ];
$resultCount = Koha::Patrons->search( { -or => { email => $email, emailpro =>
$email, B_email  => $email } } ) -> count;

It seems we could just not get the results as an array and use count directly,
casting scalar seems unnecessary as well here

i.e.
$search_results = Koha::Patrons->search( { -or => { email => $email, emailpro
=> $email, B_email  => $email } } );
...
if ( not $search_results ) {
...
elsif ( $username && $search_results->count > 1)
...
etc.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

--- Comment #14 from Marc Véron <[hidden email]> ---
Created attachment 64598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64598&action=edit
Bug 16711: (QA-followup) Use count directly

See comment # 13

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #15 from Marc Véron <[hidden email]> ---
Hope it's OK to set back to SO.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Nick Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63600|0                           |1
        is obsolete|                            |
  Attachment #64598|0                           |1
        is obsolete|                            |

--- Comment #16 from Nick Clemens <[hidden email]> ---
Created attachment 64604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64604&action=edit
Bug 16711: OPAC Password recovery: Handling if multiple accounts have the same
mail address

To reproduce:
- Create 3 Accounts, login names are test01, test02, test03, Email is the same
for all.
- Go to OPAC -> Password recovery and indicate E-Mail only
- You will get an email for only one of the accounts above.

To test:
- Apply patch, restart memcached and plack
- Go to db, delete from borrower_password_recovery;
- Try steps above to reproduce. You will get an error message:
    Account identification with this email address only is ambiguous.
    Please use the field 'Login' as well.
- Verify that other cases work as before (provide valid / invalid login only,
  provide valid email for an existing account, provide unknown email, provide
  both login and email with all combinations of valid / invalid)

Signed-off-by: Josef Moravec <[hidden email]>

Signed-off-by: Nick Clemens <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

--- Comment #17 from Nick Clemens <[hidden email]> ---
Created attachment 64605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64605&action=edit
Bug 16711: (QA-followup) Use count directly

See comment # 13

Signed-off-by: Nick Clemens <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12
Loading...