[Bug 16486] New: Display the TIME a fine was collected/written off

classic Classic list List threaded Threaded
34 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] New: Display the TIME a fine was collected/written off

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

            Bug ID: 16486
           Summary: Display the TIME a fine was collected/written off
 Change sponsored?: ---
           Product: Koha
           Version: 3.20
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

In many cases it would be very useful to be able to know the time a fine was
collected/written off (in addition to the date).

So ideally, the TIME could be shown next to the date in the Fines->Account tab.
(This would make sense in almost all cases except maybe in Accruing fines).

Alternatively, a text could be added to the description column. For example,
"Payment, thanks" could become "Payment on 15/09/2015 14:30, thanks",
"Writeoff" could become "Written off on 15/09/2015 14:30", etc

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

--- Comment #1 from Aleisha Amohia <[hidden email]> ---
Created attachment 62343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62343&action=edit
Bug 16486: Display the timestamp for account payments/writeoffs

To test:
1) Apply patch
2) Go to the patron account page, Fines tab
3) Click Account tab
4) Confirm timestamp shows next to payments and writeoffs
5) Go to Admin -> TimeFormat syspref, change the format
6) Refresh the fines page, confirm time format changes

Sponsored-by: Catalyst IT

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
  Change sponsored?|---                         |Sponsored
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

--- Comment #2 from Owen Leonard <[hidden email]> ---
I like this change but shouldn't the date formatting be done in the template
using '$KohaDates with_hours => 1' ?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Marc Véron <[hidden email]> ---
(In reply to Owen Leonard from comment #2)
> I like this change but shouldn't the date formatting be done in the template
> using '$KohaDates with_hours => 1' ?

+1

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62343|0                           |1
        is obsolete|                            |

--- Comment #4 from Aleisha Amohia <[hidden email]> ---
Created attachment 62703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62703&action=edit
Bug 16486: Display the timestamp for account payments/writeoffs

To test:
1) Apply patch
2) Go to the patron account page, Fines tab
3) Click Account tab
4) Confirm timestamp shows next to payments and writeoffs
5) Go to Admin -> TimeFormat syspref, change the format
6) Refresh the fines page, confirm time format changes

Sponsored-by: Catalyst IT

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62703|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <[hidden email]> ---
Created attachment 62995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62995&action=edit
[SIGNED OFF] Bug 16486: Display the timestamp for account payments/writeoffs

To test:
1) Apply patch
2) Go to the patron account page, Fines tab
3) Click Account tab
4) Confirm timestamp shows next to payments and writeoffs
5) Go to Admin -> TimeFormat syspref, change the format
6) Refresh the fines page, confirm time format changes

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

--- Comment #6 from Theodoros Theodoropoulos <[hidden email]> ---
Thank you all for your work on this request.
I can verify that the provided patch works as expected!
[FYI, for Koha 3.20 the patch needs one line less, because 'Hold waiting too
long' is not available]

Having said that, unless you print slips with the text from the description, I
think it would be more generic to simply change the date column to show
hours/minutes in ALL fine lines.
Following Owen's suggestion, it would be something like this:

-  <td><span title="[% account.date %]">[% account.date |$KohaDates
%]</span></td>
+  <td><span title="[% account.timestamp %]">[% account.timestamp |$KohaDates
with_hours => 1 %]</span></td>

What do you think?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.20                        |unspecified
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #7 from Jonathan Druart <[hidden email]> ---
Would not it make sense to add it everywhere?

% git grep ', thanks' **/*.tt|cut -d':' -f1|uniq
koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt

It seems that occurrences in pay.tt are not relevant, we do not display
payments in this table.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18790

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|Signed Off                  |Failed QA

--- Comment #8 from Marcel de Rooy <[hidden email]> ---
(In reply to Jonathan Druart from comment #7)

> Would not it make sense to add it everywhere?
>
> % git grep ', thanks' **/*.tt|cut -d':' -f1|uniq
> koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
> koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
> koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt
> koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account.tt
>
> It seems that occurrences in pay.tt are not relevant, we do not display
> payments in this table.

No response on this question.
Changing status to reflect need for feedback.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

--- Comment #9 from Aleisha Amohia <[hidden email]> ---
Created attachment 66826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66826&action=edit
Bug 16486: [FOLLOW-UP] Putting time in date column

In reply to Comment 6, I have moved the time into a column separate from
the description. Unfortunately the timestamp has the date and the time,
so I figured it was easier to just have them in the same column and
replace the original date column.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

--- Comment #10 from Aleisha Amohia <[hidden email]> ---
Created attachment 66827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66827&action=edit
Bug 16486: [FOLLOW-UP] Adding timestamp to date in other places

As suggested in Comment 7.
The timestamp has also been added to printfeercpt.tt, printinvoice.tt,
and opac-account.tt

To test:
1) In Staff side, go to member account, go to Fines, go to Account tab
2) Click the Print button next to a payment
3) Confirm timestamp shows on print slip
4) Create a manual invoice
5) Go back to the Account tab
6) Click the Print button next to the invoice
7) Confirm timestamp shows on print slip
8) Log into OPAC
9) Go to your fines
10) Confirm timestamp shows

Ready to test

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Dominic Pichette <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |m

--- Comment #11 from Dominic Pichette <[hidden email]> ---
I had this error trying to access the account tab in fines:

Global symbol "$input" requires explicit package name (did you forget to
declare "my $input"?) at
/inlibro/git/koha-master-dev-inlibro/members/boraccount.pl line 41.
syntax error at /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl line
44, near "1cc607141dd67a2373996a1cf5116b1334354420

"
Global symbol "$input" requires explicit package name (did you forget to
declare "my $input"?) at
/inlibro/git/koha-master-dev-inlibro/members/boraccount.pl line 56.
Execution of /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl aborted
due to compilation errors.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #12 from Jonathan Druart <[hidden email]> ---
(In reply to Dominic Pichette from comment #11)
> I had this error trying to access the account tab in fines:

Hi Dominic,
When you find an issue, you can switch the status to Failed QA.
Thanks for testing!

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62995|0                           |1
        is obsolete|                            |

--- Comment #13 from Aleisha Amohia <[hidden email]> ---
Created attachment 67537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67537&action=edit
Bug 16486: Display the timestamp for account payments/writeoffs

To test:
1) Apply patch
2) Go to the patron account page, Fines tab
3) Click Account tab
4) Confirm timestamp shows next to payments and writeoffs
5) Go to Admin -> TimeFormat syspref, change the format
6) Refresh the fines page, confirm time format changes

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67537|0                           |1
        is obsolete|                            |

--- Comment #14 from Aleisha Amohia <[hidden email]> ---
Created attachment 67538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67538&action=edit
Bug 16486: Display the timestamp for account payments/writeoffs

To test:
1) Apply patch
2) Go to the patron account page, Fines tab
3) Click Account tab
4) Confirm timestamp shows next to payments and writeoffs
5) Go to Admin -> TimeFormat syspref, change the format
6) Refresh the fines page, confirm time format changes

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

--- Comment #15 from Aleisha Amohia <[hidden email]> ---
Found a conflict in the first patch so fixed it.

(In reply to Dominic Pichette from comment #11)

> I had this error trying to access the account tab in fines:
>
> Global symbol "$input" requires explicit package name (did you forget to
> declare "my $input"?) at
> /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl line 41.
> syntax error at /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl
> line 44, near "1cc607141dd67a2373996a1cf5116b1334354420
>
> "
> Global symbol "$input" requires explicit package name (did you forget to
> declare "my $input"?) at
> /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl line 56.
> Execution of /inlibro/git/koha-master-dev-inlibro/members/boraccount.pl
> aborted due to compilation errors.

Thank you for testing but I was unable to reproduce these errors, everything
still works as expected for me. Can you please test again and make sure your
master is up to date?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Simon Pouchol <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #16 from Simon Pouchol <[hidden email]> ---
Hey,
I tried testing, and got this error message upon trying to apply the patch :

fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 16486: [FOLLOW-UP] Putting time in date column

Unsure what it means, whether it's my setup or the patches not working. (my
master is up to date)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

--- Comment #17 from Marcel de Rooy <[hidden email]> ---
Are the patches still in the right order ?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

--- Comment #18 from Aleisha Amohia <[hidden email]> ---
(In reply to Marcel de Rooy from comment #17)
> Are the patches still in the right order ?

oops no they are not - i will fix this

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67538|0                           |1
        is obsolete|                            |

--- Comment #19 from Aleisha Amohia <[hidden email]> ---
Created attachment 68302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68302&action=edit
Bug 16486: Display the timestamp for account payments/writeoffs

To test:
1) Apply patch
2) Go to the patron account page, Fines tab
3) Click Account tab
4) Confirm timestamp shows next to payments and writeoffs
5) Go to Admin -> TimeFormat syspref, change the format
6) Refresh the fines page, confirm time format changes

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16486] Display the TIME a fine was collected/written off

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Aleisha Amohia <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66826|0                           |1
        is obsolete|                            |

--- Comment #20 from Aleisha Amohia <[hidden email]> ---
Created attachment 68303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68303&action=edit
Bug 16486: [FOLLOW-UP] Putting time in date column

In reply to Comment 6, I have moved the time into a column separate from
the description. Unfortunately the timestamp has the date and the time,
so I figured it was easier to just have them in the same column and
replace the original date column.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12