[Bug 16413] New: Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

classic Classic list List threaded Threaded
20 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] New: Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

            Bug ID: 16413
           Summary: Prototype for GetLatestAutoRenewDate and
                    GetSoonestRenewDate should be changed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
        Depends on: 16344

Currently the 2 GetLatestAutoRenewDate and GetSoonestRenewDate subroutines
takes $borrowernumber and $itemnumber in parameter.
They refetch the patron, item and issue information but they already are
available from where they are called.
It would make sense to change the prototype of these 2 subroutines to accept
the patron, item and issue information directly to avoid unnecessary refetches.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344
[Bug 16344] Add a circ rule to limit the auto renewals given a specific date
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

--- Comment #1 from Jonathan Druart <[hidden email]> ---
Created attachment 51100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51100&action=edit
Bug 16413: Change prototype GetLatestAutoRenewDate

Currently the 2 GetLatestAutoRenewDate and GetSoonestRenewDate
subroutines takes $borrowernumber and $itemnumber in parameter.
They refetch the patron, item and issue information but they already are
available from where they are called.
It would make sense to change the prototype of these 2 subroutines to
accept the patron, item and issue information directly to avoid
unnecessary refetches.

Test plan:
Make sure this change does not introduce regressions on bug 15581 and bug
16344.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

--- Comment #2 from Jonathan Druart <[hidden email]> ---
Created attachment 51101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51101&action=edit
Bug 16413: Change prototype of GetSoonestRenewDate

Same change as previous patch for the GetSoonestRenewDate subroutine.

Test plan:
Make sure this change does not introduce regressions on bug 7413.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15581

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

Srdjan Jankovic <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Srdjan Jankovic <[hidden email]> ---
I think this one needs rebasing

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

--- Comment #4 from Jonathan Druart <[hidden email]> ---
(In reply to Srdjan Jankovic from comment #3)
> I think this one needs rebasing

Apply cleanly on top of dependencies (bug 15581 and bug 16344).

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

--- Comment #5 from M. Tompsett <[hidden email]> ---
Comment on attachment 51101
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51101
Bug 16413: Change prototype of GetSoonestRenewDate

Review of attachment 51101:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16413&attachment=51101)
-----------------------------------------------------------------

::: circ/renew.pl
@@ +78,5 @@
>  
>                  if ( $error && ($error eq 'too_soon' or $error eq 'auto_too_soon') ) {
>                      $soonest_renew_date = C4::Circulation::GetSoonestRenewDate(
> +                        {
> +                            borrower => $borrower->unblessed,

shouldn't this be:
patron => $borrower->unblessed,
?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

--- Comment #6 from M. Tompsett <[hidden email]> ---
Comment on attachment 51100
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51100
Bug 16413: Change prototype GetLatestAutoRenewDate

Review of attachment 51100:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16413&attachment=51100)
-----------------------------------------------------------------

::: circ/renew.pl
@@ +84,5 @@
>                  }
>                  if ( $error && ( $error eq 'auto_too_late' ) ) {
>                      $latest_auto_renew_date = C4::Circulation::GetLatestAutoRenewDate(
> +                        {
> +                            borrower => $borrower->unblessed,

shouldn't this be:
patron => $borrower->unblessed,
?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51100|0                           |1
        is obsolete|                            |
  Attachment #51101|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <[hidden email]> ---
Created attachment 58671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58671&action=edit
Bug 16413: Change prototype of GetLatestAutoRenewDate

Currently the 2 GetLatestAutoRenewDate and GetSoonestRenewDate
subroutines takes $borrowernumber and $itemnumber in parameter.
They refetch the patron, item and issue information but they already are
available from where they are called.
It would make sense to change the prototype of these 2 subroutines to
accept the patron, item and issue information directly to avoid
unnecessary refetches.

Test plan:
Make sure this change does not introduce regressions on bug 15581 and bug
16344.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

--- Comment #8 from Jonathan Druart <[hidden email]> ---
Created attachment 58672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58672&action=edit
Bug 16413: Change prototype of GetSoonestRenewDate

Same change as previous patch for the GetSoonestRenewDate subroutine.

Test plan:
Make sure this change does not introduce regressions on bug 7413.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58671|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <[hidden email]> ---
Created attachment 61514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61514&action=edit
Bug 16413: Change prototype of GetLatestAutoRenewDate

Currently the 2 GetLatestAutoRenewDate and GetSoonestRenewDate
subroutines takes $borrowernumber and $itemnumber in parameter.
They refetch the patron, item and issue information but they already are
available from where they are called.
It would make sense to change the prototype of these 2 subroutines to
accept the patron, item and issue information directly to avoid
unnecessary refetches.

Test plan:
Make sure this change does not introduce regressions on bug 15581 and bug
16344.

Signed-off-by: Jonathan Field <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58672|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <[hidden email]> ---
Created attachment 61515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61515&action=edit
Bug 16413: Change prototype of GetSoonestRenewDate

Same change as previous patch for the GetSoonestRenewDate subroutine.

Test plan:
Make sure this change does not introduce regressions on bug 7413.

Signed-off-by: Jonathan Field <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize@ptfs-europe
                   |                            |.com

--- Comment #11 from Martin Renvoize <[hidden email]> ---
Acting as git gopher to Jonathan Field who did the testing and actual signoff.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #12 from Marcel de Rooy <[hidden email]> ---
(In reply to Jonathan Druart from comment #7)
> Test plan:
> Make sure this change does not introduce regressions on bug 15581 and bug
> 16344.

Test plan?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

--- Comment #13 from Jonathan Druart <[hidden email]> ---
(In reply to Marcel de Rooy from comment #12)
> (In reply to Jonathan Druart from comment #7)
> > Test plan:
> > Make sure this change does not introduce regressions on bug 15581 and bug
> > 16344.
>
> Test plan?

Could you be more verbose please, I do not understand the question.
Yes the test plan is to test that the patches from bugs 15581 and 16344 are
still ok. At the moment of writing, none was pushed and so the goal was to test
it on top of them and QA them at the same time.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413
Bug 16413 depends on bug 16344, which changed state.

Bug 16344 Summary: Add a circ rule to limit the auto renewals given a specific date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16344

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |RESOLVED
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |[hidden email]

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61514|0                           |1
        is obsolete|                            |
  Attachment #61515|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall <[hidden email]> ---
Calls to GetSoonestRenewDate haven't been updated in opac-user.pl and
svc/checkouts at the very least.

--- Comment #15 from Jonathan Druart <[hidden email]> ---
Created attachment 65405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65405&action=edit
Bug 16413: Change prototype of GetLatestAutoRenewDate

Currently the 2 GetLatestAutoRenewDate and GetSoonestRenewDate
subroutines takes $borrowernumber and $itemnumber in parameter.
They refetch the patron, item and issue information but they already are
available from where they are called.
It would make sense to change the prototype of these 2 subroutines to
accept the patron, item and issue information directly to avoid
unnecessary refetches.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

--- Comment #16 from Jonathan Druart <[hidden email]> ---
Created attachment 65406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65406&action=edit
Bug 16413: Change prototype of GetSoonestRenewDate

Same change as previous patch for the GetSoonestRenewDate subroutine.

This is not finished, 2 other calls could not be updated (performance
issue). They may be later, when objects will be used in svc/checkouts
and opac-user.pl

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

David Cook <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/