[Bug 16246] New: Return all reserves columns in ILS-DI GetRecords response

classic Classic list List threaded Threaded
20 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] New: Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

            Bug ID: 16246
           Summary: Return all reserves columns in ILS-DI GetRecords
                    response
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]

The list of reserves fields returned in ILS-DI GetRecords response is
arbitrary. Instead we should return all the fields available in reserves table

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

--- Comment #1 from Julian Maurice <[hidden email]> ---
Created attachment 50143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50143&action=edit
Bug 16246: Return all reserves columns in ILS-DI GetRecords response

The list of reserves fields returned in ILS-DI GetRecords response is
arbitrary. Instead we should return all the fields available in reserves
table

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

--- Comment #2 from Julian Maurice <[hidden email]> ---
Created attachment 50144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50144&action=edit
Bug 16246: Add tests for ILS-DI GetRecords

+ remove some warnings in C4/ILSDI/Services.pm

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

--- Comment #3 from Julian Maurice <[hidden email]> ---
Test plan:

1. Go to http://OPAC/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX where XXX
is the biblionumber of a record that have at least one hold.
2. Confirm that you have all non-NULL fields displayed in
//record/reserves/reserve (compare with what you have in DB)
3. prove t/db_dependent/ILSDI_Services.t

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

Andreas Hedström Mace <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |u.se

--- Comment #4 from Andreas Hedström Mace <[hidden email]> ---
Patch did not apply for me. Needs a rebase?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50143|0                           |1
        is obsolete|                            |

--- Comment #5 from Julian Maurice <[hidden email]> ---
Created attachment 56829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56829&action=edit
Bug 16246: Return all reserves columns in ILS-DI GetRecords response

The list of reserves fields returned in ILS-DI GetRecords response is
arbitrary. Instead we should return all the fields available in reserves
table

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50144|0                           |1
        is obsolete|                            |

--- Comment #6 from Julian Maurice <[hidden email]> ---
Created attachment 56830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56830&action=edit
Bug 16246: Add tests for ILS-DI GetRecords

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

--- Comment #7 from Julian Maurice <[hidden email]> ---
Patches rebased on master

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56829|0                           |1
        is obsolete|                            |

--- Comment #8 from Julian Maurice <[hidden email]> ---
Created attachment 61032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61032&action=edit
Bug 16246: Return all reserves columns in ILS-DI GetRecords response

The list of reserves fields returned in ILS-DI GetRecords response is
arbitrary. Instead we should return all the fields available in reserves
table

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

Julian Maurice <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56830|0                           |1
        is obsolete|                            |

--- Comment #9 from Julian Maurice <[hidden email]> ---
Created attachment 61033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61033&action=edit
Bug 16246: Add tests for ILS-DI GetRecords

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

--- Comment #10 from Julian Maurice <[hidden email]> ---
Patches rebased on master

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

[hidden email] <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |[hidden email]

--- Comment #11 from [hidden email] <[hidden email]> ---
Patch tested with a sandbox, by Sonia BOUIS <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

[hidden email] <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61032|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

[hidden email] <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61033|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

--- Comment #12 from [hidden email] <[hidden email]> ---
Created attachment 61329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61329&action=edit
Bug 16246: Return all reserves columns in ILS-DI GetRecords response

The list of reserves fields returned in ILS-DI GetRecords response is
arbitrary. Instead we should return all the fields available in reserves
table

Signed-off-by: Sonia BOUIS <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

--- Comment #13 from [hidden email] <[hidden email]> ---
Created attachment 61330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61330&action=edit
Bug 16246: Add tests for ILS-DI GetRecords

Signed-off-by: Sonia BOUIS <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

Koha Team Lyon 3 <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #14 from Koha Team Lyon 3 <[hidden email]> ---
Tried with several holds : they are all displayed in the XML file produced by
http://OPAC/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX with the same
values than in DB (check by a SQL report)
There's no NULL value.
When we change an information, XML produced by ILSDI is updated.

cf :
<reserves><reserve><timestamp>2017-03-20
17:06:29</timestamp><borrowernumber>4024</borrowernumber><reserve_id>1424</reserve_id><biblionumber>979</biblionumber><reservedate>2017-03-20</reservedate><suspend>1</suspend><lowestPriority>0</lowestPriority><rtimestamp>2017-03-20
17:06:29</rtimestamp><priority>1</priority><suspend_until>2017-03-22
00:00:00</suspend_until><branchcode>MAURES</branchcode><reservenotes/></reserve><reserve><biblionumber>979</biblionumber><lowestPriority>1</lowestPriority><suspend>0</suspend><reservedate>2017-03-20</reservedate><borrowernumber>6128</borrowernumber><timestamp>2017-03-20
17:06:29</timestamp><reserve_id>1425</reserve_id><reservenotes>test</reservenotes><branchcode>MAURES</branchcode><priority>2</priority><rtimestamp>2017-03-20
17:06:29</rtimestamp></reserve></reserves>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #15 from Jonathan Druart <[hidden email]> ---
Julian, on but 17736 I remove occurrences of GetReservesFromBiblionumber.

See patch:  Bug 17736: Replace GetReservesFromBiblionumber with
Koha::Biblio->holds

I needed to create a new method, Koha::Holds->search is not identical as
GetReservesFromBiblionumber.

Your patch will introduce a change with existing behaviour that does not look
expected.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 16246] Return all reserves columns in ILS-DI GetRecords response

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Loading...