[Bug 15707] New: Add ability to define hierarchical groups of libraries

classic Classic list List threaded Threaded
274 messages Options
123456 ... 10
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50405|0                           |1
        is obsolete|                            |

--- Comment #54 from Jonathan Druart <[hidden email]> ---
Created attachment 52271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52271&action=edit
Bug 15707 - Add TreeGrid library to about page

Signed-off-by: Mark Tompsett <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50406|0                           |1
        is obsolete|                            |

--- Comment #55 from Jonathan Druart <[hidden email]> ---
Created attachment 52272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52272&action=edit
Bug 15707 - Unit Tests

Signed-off-by: Mark Tompsett <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50407|0                           |1
        is obsolete|                            |

--- Comment #56 from Jonathan Druart <[hidden email]> ---
Created attachment 52273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52273&action=edit
Bug 15707: Fix conflict with bug 15446 (type vs _type)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50408|0                           |1
        is obsolete|                            |

--- Comment #57 from Jonathan Druart <[hidden email]> ---
Created attachment 52274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52274&action=edit
Bug 15707 [QA Followup] - Switch to treetable which Koha already uses

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #58 from Jonathan Druart <[hidden email]> ---
Created attachment 52275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52275&action=edit
Bug 15707: QA follow-up - Drop table if exists

1/ DROP table if exists
2/ FAIL   spelling
    decendents  ==> descendants

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #59 from Jonathan Druart <[hidden email]> ---
(In reply to Kyle M Hall from comment #49)

> (In reply to Jonathan Druart from comment #37)
> > 2/ What's next for these library groups? What's the difference with our
> > existing groups? Is there a plan to move the existing ones to this new table?
>
> Bug 15708 is my first enhancement that will take advantage of this. However,
> I think there will be many other possible uses for this system in the
> future. The existing groups function is not actually used anywhere in Koha
> and should probably be removed. The search groups could go either way, but
> are fine the way they are.
>
> What makes this far more powerful is the ability to define hierarchical
> group structures. This will be a cornerstone for making Koha much more
> usable in consortial library settings.

It is weird to have 2 "library groups" features and I think the first step
should be to replace the existing one. The existing feature is used in the
advanced search form and should work.
Moreover I'd like to get Owen opinion on the modal you use to create/update a
new entry. I am going to ping him on IRC.
There are also some inconsistencies on styles, the confirmation of add/update
is a warning (orange)

Keeping it in the Signed Off queue to get other opinions.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #60 from Jonathan Druart <[hidden email]> ---
Also it might be odd to have a new feature not doing anything (if pushed as it)
:)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #61 from Jonathan Druart <[hidden email]> ---
The following patch could be obsoleted: Bug 15707 - Add TreeGrid library to
about page

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #62 from Owen Leonard <[hidden email]> ---
> (In reply to Jonathan Druart from comment #59)
> It is weird to have 2 "library groups" features and I think the first step
> should be to replace the existing one.

I agree. It is confusing to have two menu items on the administration page,
"Libraries and groups" and "Library groups." I think we should think of a way
to manage all this functionality in one section.

Some other comments:

- Nowhere else do we use the "fa-plus-circle" icon for "add." We always use
"fa-plus."

- Nowhere else in Koha do we use a modal to display an add form. We either
display a form on a separate page or we use JS to show/hide the edit form on
the page to mimic the display of a separate page. See
admin/items_search_fields.pl for example.

- Nowhere else in Koha do we use the "fa-edit" icon for "edit." We always use
"fa-pencil."

- When displaying confirmation messages we use '<div class="dialog message">'
not '<div class="dialog alert">'

- There is no reason to display an icon ("<i class="fa fa-object-group"></i>")
next to each group. It doesn't serve any function.

- There is no reason to display an icon ("<i class="fa fa-home"></i>") next to
each library in a group. It doesn't serve any function.

- Nowhere else in Koha do we use "fa-minus-circle" to mean "remove." It should
be "fa-trash."

- Nowhere else in Koha do we add an icon to the "actions" menu.

- Nowhere else in Koha do we use a modal to display a delete confirmation
message. I think I could be convinced that we should, but I'd like to hear the
argument. If we do, we should use the space given to display more information
about the deletion than this implementation does, e.g. what exactly am I
deleting?

- Instead of a "home" icon for "Add library" I think it should be the "plus"
icon which is associated with adding or creating something.

- The list of libraries in the "Add library" dropdown should be alphabetized by
library name, not library code.

- This patch adds five new instances of "onclick." I've been working very hard
to eliminate the use of "onclick" and I don't think new patches should add
them.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #63 from Kyle M Hall <[hidden email]> ---
> I agree. It is confusing to have two menu items on the administration page,
> "Libraries and groups" and "Library groups." I think we should think of a
> way to manage all this functionality in one section.

These two sub-systems are completely unrelated. They really don't belong
together. I'd be more than happy to rename it "Library hierarchies" if you find
that acceptable, or to rename the existing groups to "search groups" which is
what they are.

> Some other comments:
>
> - Nowhere else do we use the "fa-plus-circle" icon for "add." We always use
> "fa-plus."

Changed with followup.

>
> - Nowhere else in Koha do we use a modal to display an add form. We either
> display a form on a separate page or we use JS to show/hide the edit form on
> the page to mimic the display of a separate page. See
> admin/items_search_fields.pl for example.

You are correct, but I believe the modal may be a better paradigm. Would you
disagree? It means we aren't shifting elements on the page around when we
hide/display a form. I know it's without precedent at the moment but I'd like
you to consider the advantages. Think about how every other site does this
stuff. It's typically with modals. Koha is generally working against the
standard web ux by *not* using modals! Would you agree?

>
> - Nowhere else in Koha do we use the "fa-edit" icon for "edit." We always
> use "fa-pencil."

Changed with followup!
>
> - When displaying confirmation messages we use '<div class="dialog
> message">' not '<div class="dialog alert">'

Can do!

>
> - There is no reason to display an icon ("<i class="fa
> fa-object-group"></i>") next to each group. It doesn't serve any function.

Changed in followup!

>
> - There is no reason to display an icon ("<i class="fa fa-home"></i>") next
> to each library in a group. It doesn't serve any function.

Changed in followup!

>
> - Nowhere else in Koha do we use "fa-minus-circle" to mean "remove." It
> should be "fa-trash."

Fixed in followup!

>
> - Nowhere else in Koha do we add an icon to the "actions" menu.

Will do!

> - Nowhere else in Koha do we use a modal to display a delete confirmation
> message. I think I could be convinced that we should, but I'd like to hear
> the argument. If we do, we should use the space given to display more
> information about the deletion than this implementation does, e.g. what
> exactly am I deleting?

We use plenty of js confirm dialogs for delete confirmation messages. Over the
years they've gotten more and more jarring in my opinion. They cannot be styled
to match the look of Koha. Even more importantly, we tend to abuse confirm
dialogs by adding far to much text to them which we attempt to lay out with
only spaces and newlines. With the modal this is a non-issue because we can
simply use html. The modal seems much more natural and integrated, while
presenting the exact same options to the user.

>
> - Instead of a "home" icon for "Add library" I think it should be the "plus"
> icon which is associated with adding or creating something.

Fixed!

>
> - The list of libraries in the "Add library" dropdown should be alphabetized
> by library name, not library code.

Fixed!

> - This patch adds five new instances of "onclick." I've been working very
> hard to eliminate the use of "onclick" and I don't think new patches should
> add them.

Fixed! I wrote this patch before the move away from onclick and I'm happy to
see them go ; )

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #64 from Kyle M Hall <[hidden email]> ---
Created attachment 52367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52367&action=edit
Bug 15707 [QA Followup] - Fix UI issues

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #65 from Owen Leonard <[hidden email]> ---
(In reply to Kyle M Hall from comment #63)

> These two sub-systems are completely unrelated. They really don't belong
> together.

If this is a feature without any real application in Koha yet, perhaps we
shouldn't add it to the menu system at all?

> > - Nowhere else in Koha do we use a modal to display an add form.
>
> You are correct, but I believe the modal may be a better paradigm.

Perhaps. However, I think introducing a new interface pattern requires a
certain amount of commitment to making that change consistently throughout the
interface. For example, using jEditable for the Quote of the Day feature was an
interesting proof of concept, but it went nowhere after that. Introducing the
use of Font Awesome was a good improvement, but it took a lot of buy-in and
work to make it consistent.

> > - Nowhere else in Koha do we use a modal to display a delete confirmation
> > message.
>
> The modal seems much more natural and
> integrated, while presenting the exact same options to the user.

I think that's fine, especially if we take advantage of the opportunity to
display thorough information to the user. As I said above, I think making the
change requires /some/ commitment to implementing the same change throughout
the staff client.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #66 from Owen Leonard <[hidden email]> ---
> I've removed the
> patch that adds the treegrid library and have added a follow switching to
> treetables.

Treegrid is still getting added to the about page.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #67 from Kyle M Hall <[hidden email]> ---
(In reply to Owen Leonard from comment #65)
> (In reply to Kyle M Hall from comment #63)
>
> > These two sub-systems are completely unrelated. They really don't belong
> > together.
>
> If this is a feature without any real application in Koha yet, perhaps we
> shouldn't add it to the menu system at all?

I don't expect this patch set to be pushed to master until Bug 15708 is ready
to be pushed along with it. I would like to get this to Passed QA in the
meantime.

>
> > > - Nowhere else in Koha do we use a modal to display an add form.
> >
> > You are correct, but I believe the modal may be a better paradigm.
>
> Perhaps. However, I think introducing a new interface pattern requires a
> certain amount of commitment to making that change consistently throughout
> the interface. For example, using jEditable for the Quote of the Day feature
> was an interesting proof of concept, but it went nowhere after that.
> Introducing the use of Font Awesome was a good improvement, but it took a
> lot of buy-in and work to make it consistent.

I agree. I'm willing to put in some work if you can identify some areas where
you'd like to see modals. I think the low-hanging fruit would be any of the
hide/show forms we have. The audio alerts editor is the first one that comes to
mind, but I'm sure you can point out some others!

>
> > > - Nowhere else in Koha do we use a modal to display a delete confirmation
> > > message.
> >
> > The modal seems much more natural and
> > integrated, while presenting the exact same options to the user.
>
> I think that's fine, especially if we take advantage of the opportunity to
> display thorough information to the user. As I said above, I think making
> the change requires /some/ commitment to implementing the same change
> throughout the staff client.

Agreed, this latest followup takes advantage of that a bit be showing the group
to be deleted in one case, in the case of removing a library from a group it
shows the library name and the group it will be removed from with some minor
styling. Nothing amazing but definitely easier on the eyes and no unnecessary
use of quotes around the names of things because the confirm dialogs are only
plaintext. If you think my styling could be improved just let me know!
Basically it's just styled with the group and library names italicized and
bold. I think we need a standard pattern for how to style the names of things
in this fashion, and I see no reason not to start here.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #68 from Kyle M Hall <[hidden email]> ---
Created attachment 52370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52370&action=edit
Bug 15707 [QA Followup] - Remove class for treegrid

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #69 from Owen Leonard <[hidden email]> ---
(In reply to Kyle M Hall from comment #63)
> > I agree. It is confusing to have two menu items on the administration page,
> > "Libraries and groups" and "Library groups." I think we should think of a
> > way to manage all this functionality in one section.
>
> These two sub-systems are completely unrelated.

Do you not plan to replace the existing library groups functionality with this?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10276

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12599

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #70 from Jonathan Druart <[hidden email]> ---
The discussion about the modal should be brought at the next dev meeting I
think:
Is everybody (i.e. the majority) agrees on this change, who is going to
implement it to the other pages, etc.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #71 from Kyle M Hall <[hidden email]> ---
(In reply to Owen Leonard from comment #69)
> (In reply to Kyle M Hall from comment #63)
> > > I agree. It is confusing to have two menu items on the administration page,
> > > "Libraries and groups" and "Library groups." I think we should think of a
> > > way to manage all this functionality in one section.
> >
> > These two sub-systems are completely unrelated.
>
> Do you not plan to replace the existing library groups functionality with
> this?

I had not thought about it, but it would make a log of sense! That should
definitely be a separate bug to limit scope creep, but I think it's an
excellent idea. After that we could do away with the existing groups
functionality altogether.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |16735


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735
[Bug 16735] Replace existing library search groups functionality with the new
hierarchical groups system
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #72 from Kyle M Hall <[hidden email]> ---
(In reply to Jonathan Druart from comment #70)
> The discussion about the modal should be brought at the next dev meeting I
> think:
> Is everybody (i.e. the majority) agrees on this change, who is going to
> implement it to the other pages, etc.

That sounds good to me. I think we should vote to add this behavior as the
preferred "one page" viewer/editor style, deprecating the older "hide/show"
style in preference to it. Once that is voted on, we can identify pages that
use the "hide/show" style and file bugs to replace each one. I'd be happy to
work on those bugs. I think using the modal is great ux improvement and it
would be worthwhile to make that change throughout Koha.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Katrin Fischer <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #73 from Katrin Fischer <[hidden email]> ---
>Basically it's just styled with the group and library names italicized and >bold. I think we need a standard pattern for how to style the names of things >in this fashion, and I see no reason not to start here.

Please don't do this! It breaks translation by splitting the sentence into
multiple parts in the po files. Until that is fixed, using in-sentence mark-up
is a really bad thing for translators. Using TT variables works fine and they
get replaced by %s, but <b> and <i> mid-sentence are bad.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #74 from Katrin Fischer <[hidden email]> ---
Talking about these for an example:

+    <div class="dialog alert group-added">
+        [% IF added.branchcode %]
+            <i>[% added.library.branchname %]</i> added to group.
+        [% ELSE %]
+            Group <i>[% added.title %]</i> created.
+        [% END %]
+    </div>

Second example in the po file is:
- Group
- created
Instead of: Group %s created.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #75 from Kyle M Hall <[hidden email]> ---
(In reply to Katrin Fischer from comment #74)

> Talking about these for an example:
>
> +    <div class="dialog alert group-added">
> +        [% IF added.branchcode %]
> +            <i>[% added.library.branchname %]</i> added to group.
> +        [% ELSE %]
> +            Group <i>[% added.title %]</i> created.
> +        [% END %]
> +    </div>
>
> Second example in the po file is:
> - Group
> - created
> Instead of: Group %s created.

What if we were to take advantage of TT to "hide" the markup for translations?
Instead of:
Group <i>[% added.title %]</i> created.
we could do this:
Group [% "<i>" _ added.title _ "</i>" %] created.

That way, we can still emphasize names, but the markup will not show. We could
even create a filter if we standardize this so we could do something like this:

Group [% added.title | $KohaSpan id => 'myId' class => 'name'  %] created.

That solves the problem of translations while still allowing us to style
particular elements in a sentence!

What do you think?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #76 from Katrin Fischer <[hidden email]> ---
If that works with the po files - it's totally ok for me. I can see how
highlighting words or pre-formatting things can be useful.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|

[Bug 15707] Add ability to define hierarchical groups of libraries

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #77 from Marc Véron <[hidden email]> ---
(In reply to Kyle M Hall from comment #75)

> (In reply to Katrin Fischer from comment #74)
> > Talking about these for an example:
> >
> > +    <div class="dialog alert group-added">
> > +        [% IF added.branchcode %]
> > +            <i>[% added.library.branchname %]</i> added to group.
> > +        [% ELSE %]
> > +            Group <i>[% added.title %]</i> created.
> > +        [% END %]
> > +    </div>
> >
> > Second example in the po file is:
> > - Group
> > - created
> > Instead of: Group %s created.
>
> What if we were to take advantage of TT to "hide" the markup for
> translations?
> Instead of:
> Group <i>[% added.title %]</i> created.
> we could do this:
> Group [% "<i>" _ added.title _ "</i>" %] created.
>
> That way, we can still emphasize names, but the markup will not show. We
> could even create a filter if we standardize this so we could do something
> like this:
>
> Group [% added.title | $KohaSpan id => 'myId' class => 'name'  %] created.
>
> That solves the problem of translations while still allowing us to style
> particular elements in a sentence!
>
> What do you think?

That sounds interesting, see:
http://template-toolkit.org/docs/manual/Directives.html

---start snip---

You can concatenate strings together using the ' _ ' operator. In Perl 5, the .
is used for string concatenation, but in Perl 6, as in the Template Toolkit,
the . will be used as the method calling operator and ' _ ' will be used for
string concatenation. Note that the operator must be specified with surrounding
whitespace which, as Larry says, is construed as a feature:

[% copyright = '(C) Copyright' _ year _ ' ' _ author %]

You can, of course, achieve a similar effect with double quoted string
interpolation.

[% copyright = "(C) Copyright $year $author" %]

---end snip---

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
123456 ... 10