[Bug 15702] New: Patron details: Problems with leading and trailing blanks (surname, firstname, etc.)

classic Classic list List threaded Threaded
35 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] New: Patron details: Problems with leading and trailing blanks (surname, firstname, etc.)

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

            Bug ID: 15702
           Summary: Patron details: Problems with leading and trailing
                    blanks (surname, firstname, etc.)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: [hidden email]
          Reporter: [hidden email]
        QA Contact: [hidden email]
                CC: [hidden email], [hidden email]

It is possible to enter leading and trailing blanks in patron's surname,
firstname (and in other fields as well). This leads to visible and invisible
symptoms like wrong sorting, name not findable if you browse by last name,
display of blanks where you do not expect them.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Patron details: Problems with leading and trailing blanks (surname, firstname, etc.)

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

--- Comment #1 from Marc Véron <[hidden email]> ---
Created attachment 47424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47424&action=edit
Leading / trailing blanks in patron information (screenshots)

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Patron details: Problems with leading and trailing blanks (surname, firstname, etc.)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10177

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Patron details: Problems with leading and trailing blanks (surname, firstname, etc.)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14509

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Patron details: Problems with leading and trailing blanks (surname, firstname, etc.)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

--- Comment #2 from Owen Leonard <[hidden email]> ---
Thanks for filing this bug--I should have done so ages ago. This is enough of a
problem for us that I regularly run a report to catch these records and correct
them. I'm not sure why librarians here are so trigger-happy on the keyboard.

We addressed this issue a long time ago with barcodes. See in returns.pl, line
253: $barcode =~ s/^\s*|\s*$//g; # remove leading/trailing whitespace

Is there any reason not to trim leading and trailing whitespace from all the
data submitted during patron entry?

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Patron details: Problems with leading and trailing blanks (surname, firstname, etc.)

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

--- Comment #3 from Marc Véron <[hidden email]> ---
(In reply to Owen Leonard from comment #2)

> Thanks for filing this bug--I should have done so ages ago. This is enough
> of a problem for us that I regularly run a report to catch these records and
> correct them. I'm not sure why librarians here are so trigger-happy on the
> keyboard.
>
> We addressed this issue a long time ago with barcodes. See in returns.pl,
> line 253: $barcode =~ s/^\s*|\s*$//g; # remove leading/trailing whitespace
>
> Is there any reason not to trim leading and trailing whitespace from all the
> data submitted during patron entry?

I think there is no any reason to not trim trailin and leading whte spaces.
Please go ahead and I will be to signoff.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Patron details: Problems    |Trim whitespace from patron
                   |with leading and trailing   |details upon submission
                   |blanks (surname, firstname, |
                   |etc.)                       |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Martin Renvoize <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize@ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize <[hidden email]> ---
+1. No reason not to

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

--- Comment #5 from M. Tompsett <[hidden email]> ---
Created attachment 58717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58717&action=edit
Bug 15702: Trim whitespace from fields with non-whitespace data

Since space may be a valid value for something, trimming what has
non-whitespace was done.

TEST PLAN
---------
1) Enter patron with spaces before, after, and both.
2) Apply patch.
3) Attempt to enter another patron with spaces before, after, and both.
   -- attempting to edit after saving will demonstrate the spaces
      were trimmed.
4) Attempt to edit the patron initially entered.
   -- while there may be spaces before, after, and both initially,
      after saving and trying to edit again, there will not be.
5) run koha qa test tools.

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Owen Leonard <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58717|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <[hidden email]> ---
Created attachment 58768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58768&action=edit
[SIGNED-OFF] Bug 15702: Trim whitespace from fields with non-whitespace data

Since space may be a valid value for something, trimming what has
non-whitespace was done.

TEST PLAN
---------
1) Enter patron with spaces before, after, and both.
2) Apply patch.
3) Attempt to enter another patron with spaces before, after, and both.
   -- attempting to edit after saving will demonstrate the spaces
      were trimmed.
4) Attempt to edit the patron initially entered.
   -- while there may be spaces before, after, and both initially,
      after saving and trying to edit again, there will not be.
5) run koha qa test tools.

Signed-off-by: Owen Leonard <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Chris Cormack <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
           Keywords|Academy                     |

--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]-c
                   |                            |ommunity.org

--- Comment #7 from Jonathan Druart <[hidden email]> ---
I think this should be done in ModMember and AddMember, covered by tests.

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Marcel de Rooy <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]-commun |[hidden email]
                   |ity.org                     |

--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

--- Comment #8 from M. Tompsett <[hidden email]> ---
Created attachment 62519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62519&action=edit
Bug 15702: Add test cases for modified code

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58768|0                           |1
        is obsolete|                            |

--- Comment #9 from M. Tompsett <[hidden email]> ---
Created attachment 62520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62520&action=edit
Bug 15702: Recommended Counter-patch

As per comment #7, this patch affects AddMember and ModMember.
The test plan should be the same as comment #6.
Secondary patch with tests still to come.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

M. Tompsett <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #10 from M. Tompsett <[hidden email]> ---
TEST PLAN
----------
1) Apply first patch
2) Run prove -v t/db_dependent/Members.t
   -- expecting failures
3) Apply second patch
4) Run prove -v t/db_dependent/Members.t
   -- expecting success
5) run koha qa test tools
   -- two files modified with no issues

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62519|0                           |1
        is obsolete|                            |

--- Comment #11 from Marc Véron <[hidden email]> ---
Created attachment 62527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62527&action=edit
Bug 15702: Add test cases for modified code

Signed-off-by: Marc Véron <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62520|0                           |1
        is obsolete|                            |

--- Comment #12 from Marc Véron <[hidden email]> ---
Created attachment 62528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62528&action=edit
Bug 15702: Recommended Counter-patch

As per comment #7, this patch affects AddMember and ModMember.
The test plan should be the same as comment #6.
Secondary patch with tests still to come.

Signed-off-by: Marc Véron <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Marc Véron <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

--- Comment #13 from M. Tompsett <[hidden email]> ---
(In reply to Marc Véron from comment #12)
> As per comment #7, this patch affects AddMember and ModMember.

Yes. :)


> The test plan should be the same as comment #6.

No, the test plan is comment #10.

TEST PLAN
----------
1) Apply first patch
2) Run prove -v t/db_dependent/Members.t
   -- expecting failures
3) Apply second patch
4) Run prove -v t/db_dependent/Members.t
   -- expecting success
5) run koha qa test tools
   -- two files modified with no issues


> Secondary patch with tests still to come.

Because I purposefully changed two tests, there are no additional tests. The
initial failures are because I purposefully changed the add and mod to include
an extra space (. q{ }) at the end in two of the tests. With the new code, that
will not change anything, because they are filtered. :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

--- Comment #14 from Marc Véron <[hidden email]> ---
(In reply to M. Tompsett from comment #13)
> (In reply to Marc Véron from comment #12)
> > As per comment #7, this patch affects AddMember and ModMember.
>
> Yes. :)
>
>
> > The test plan should be the same as comment #6.
>
> No, the test plan is comment #10.

Sorry, I did not edit the original commit messages. I expected them to be up to
date.

>
> TEST PLAN
> ----------
> 1) Apply first patch
> 2) Run prove -v t/db_dependent/Members.t
>    -- expecting failures
> 3) Apply second patch
> 4) Run prove -v t/db_dependent/Members.t
>    -- expecting success
> 5) run koha qa test tools
>    -- two files modified with no issues
>
>
> > Secondary patch with tests still to come.
>
> Because I purposefully changed two tests, there are no additional tests. The
> initial failures are because I purposefully changed the add and mod to
> include an extra space (. q{ }) at the end in two of the tests. With the new
> code, that will not change anything, because they are filtered. :)

Not sure, is my Sign-off OK or should I do more testing?

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

--- Comment #15 from M. Tompsett <[hidden email]> ---
(In reply to Marc Véron from comment #14)
> Sorry, I did not edit the original commit messages. I expected them to be up
> to date.

Sorry, I failed to update them.
That's my fault.


> Not sure, is my Sign-off OK or should I do more testing?

If you ran the prove, your sign off is okay. If not, run the prove. :)
And feel free to update the test plan. :)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

--- Comment #16 from Marc Véron <[hidden email]> ---
(In reply to M. Tompsett from comment #15)

> (In reply to Marc Véron from comment #14)
> > Sorry, I did not edit the original commit messages. I expected them to be up
> > to date.
>
> Sorry, I failed to update them.
> That's my fault.
>
>
> > Not sure, is my Sign-off OK or should I do more testing?
>
> If you ran the prove, your sign off is okay. If not, run the prove. :)
> And feel free to update the test plan. :)

No problem, proves were OK, QA tools as well. :-)

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

Jonathan Druart <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62527|0                           |1
        is obsolete|                            |
  Attachment #62528|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <[hidden email]> ---
Created attachment 62613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62613&action=edit
Bug 15702: Add test cases for modified code

Signed-off-by: Marc Véron <[hidden email]>

Signed-off-by: Jonathan Druart <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 15702] Trim whitespace from patron details upon submission

bugzilla-daemon
In reply to this post by bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15702

--- Comment #18 from Jonathan Druart <[hidden email]> ---
Created attachment 62614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62614&action=edit
Bug 15702: Recommended Counter-patch

As per comment #7, this patch affects AddMember and ModMember.
The test plan should be the same as comment #6.
Secondary patch with tests still to come.

Signed-off-by: Marc Véron <[hidden email]>

Signed-off-by: Jonathan Druart <[hidden email]>

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
12
Loading...