After thinking about it I changed the code's behavior to always display a
reminder if the patron was previously debarred.
This makes sense to me (it's only a reminder) and it correctly stacks with
1) Select a user with active restrictions
2) Make sure finesday=0 for the user category
3) Checkout and return an item (not overdue) : a previous restriction reminder
4) Checkout and return an overdue item : no previous restriction reminder will
After applying patch:
Same steps, but a reminder should appear for step 4)
I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.
P.S.: The "finesday" setting is called "Suspension days" in the web interface,
if you're searching
for it like I did...