[Bug 14039] Add patron title to checkout screen

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[Bug 14039] Add patron title to checkout screen

bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039

--- Comment #14 from Jonathan Druart <[hidden email]> ---
Comment on attachment 64077
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64077
[SIGNED-OFF] Bug 14039 - Add patron salutation to checkout screen

Review of attachment 64077:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14039&attachment=64077)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc
@@ +5,4 @@
>          [%- IF invert_name %]
>              [%- borrower.surname | html %], [% borrower.firstname | html %] [% IF borrower.othernames %] ([% borrower.othernames | html %]) [% END %]
>          [%- ELSE %]
> +            [% IF borrower.title %] <span id="patron-title">[%- borrower.title | html %] </span>[% END %][%- borrower.firstname | html %] [% IF borrower.othernames %] ([% borrower.othernames | html %]) [% END %] [% borrower.surname | html %]

I do not think it's a good idea to have an id here, there are certainly places
where this include file is used several times.

--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[hidden email]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Loading...